[Bug 45726] Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

https://bugs.winehq.org/show_bug.cgi?id=45726

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |ad8f45095777839156168e80ff1
                   |                            |d8fba5cc265d4
             Status|NEW                         |RESOLVED

--- Comment #1 from Anastasius Focht  ---
Hello folks,

this is fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/ad8f45095777839156168e80ff...

Thanks Louis

--- snip ---
$ pwd
/home/focht/.wine/drive_c/Program Files (x86)/Mozilla Firefox

$ file *.exe
crashreporter.exe:                PE32 executable (GUI) Intel 80386, for MS
Windows
firefox.exe:                      PE32 executable (GUI) Intel 80386, for MS
Windows
maintenanceservice.exe:           PE32 executable (GUI) Intel 80386, for MS
Windows
maintenanceservice_installer.exe: PE32 executable (GUI) Intel 80386, for MS
Windows, Nullsoft Installer self-extracting archive
minidump-analyzer.exe:            PE32 executable (console) Intel 80386, for MS
Windows
pingsender.exe:                   PE32 executable (console) Intel 80386, for MS
Windows
plugin-container.exe:             PE32 executable (GUI) Intel 80386, for MS
Windows
plugin-hang-ui.exe:               PE32 executable (console) Intel 80386, for MS
Windows
updater.exe:                      PE32 executable (GUI) Intel 80386, for MS
Windows

$ WINEDEBUG=+seh,+relay wine ./firefox.exe >>log.txt 2>&1
...
002b:Call ucrtbase.strncpy(0f7542e0,033a91c8
"toolkit.winRegisterApplicationRestart",00000025) ret=10002c46
002b:Ret  ucrtbase.strncpy() retval=0f7542e0 ret=10002c46
002b:Call
KERNEL32.GetApplicationRestartSettings(ffffffff,00000000,0033f44c,00000000)
ret=0150ec5a
002b:fixme:process:GetApplicationRestartSettings 0xffffffff, (nil), 0x33f44c,
(nil))
002b:Ret  KERNEL32.GetApplicationRestartSettings() retval=80004001 ret=0150ec5a 
...
--- snip ---

https://github.com/mozilla/gecko-dev/blob/master/widget/windows/nsWindow.cpp...

--- snip ---
const char16_t*
GetQuitType()
{
  if (Preferences::GetBool(PREF_WIN_REGISTER_APPLICATION_RESTART, false)) {
    DWORD cchCmdLine = 0;
    HRESULT rc =
      ::GetApplicationRestartSettings(::GetCurrentProcess(), nullptr,
&cchCmdLine, nullptr);
    if (rc == S_OK) {
      return u"os-restart";
    }
  }
  return nullptr;
}
--- snip ---

https://github.com/mozilla/gecko-dev/blob/403038737ba75af3842ba6b43b6e2fb47e...

--- snip ---
#define PREF_WIN_REGISTER_APPLICATION_RESTART
"toolkit.winRegisterApplicationRestart"
--- snip ---

$ wine --version
wine-3.14-323-g6edf38c205

Regards