https://bugs.winehq.org/show_bug.cgi?id=31836
--- Comment #21 from Andrew Eikum aeikum@codeweavers.com --- (In reply to Rafał Mużyło from comment #19)
Thanks for the credit, though I don't consider it fully earned.
I can remove the credit if you want, but I really did start with your patch and build on top of it. You had done much of the groundwork.
Anyway, the patch builds - it might even work, but I'm not sure which apps were using it.
I've been testing mostly with a program called Graph Studio. Once that was working, I tested with GTA:VC, Echoes, Lego Designer, and PowerPoint and all seem to work.
Though a couple minor points:
- it seems new GST_QUERY_ types should be added to switch, query_function,
so that "Unknown query" are printed only for *unknown* values
Sure, I'll make this a little better.
- not quite sure if it's generic or app specific, but sometimes if a video
fails to play due to a missing codec ("err:msvideo:ICLocate Required media codec 'vidc I420' not found!), on a retry the app crashes
I'll test the failure cases (missing gstreamer plugins) better and make sure we're handling the problem correctly.
- not sure if it can be helped, but I wonder if some kind of null input can
be provided, so that the apps don't crash if a needed gst plugin isn't installed
This could maybe be a future improvement.