[Bug 26016] Multiple Microsoft installers crash with heap corruption (private heap for StringTableXXX allocation wrapper in setupapi needed)(XmlLite, XPSEP, IE7)

https://bugs.winehq.org/show_bug.cgi?id=26016

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|xmllite installer crashes   |Multiple Microsoft
                   |about 1 in 30 runs          |installers crash with heap
                   |                            |corruption (private heap
                   |                            |for StringTableXXX
                   |                            |allocation wrapper in
                   |                            |setupapi needed)(XmlLite,
                   |                            |XPSEP, IE7)

--- Comment #13 from Anastasius Focht  ---
Hello folks,

merging bug 32554 also here.

I had some discussion on IRC yesterday where I guessed this might be the same
issue as bug 32554 (and others), suggesting use of private heap.

See http://bugs.winehq.org/show_bug.cgi?id=32554#c15 (private heap for
StringTableXXX allocator).

Actually I thought you would only change the allocation wrapper 'MyMalloc',
'MyFree' (used for StringTableXXX API) to make use of private heap, which
helped me in other setupapi/corruption bugs.

Austin your patch changes every HeapAlloc/HeapFree() in setupapi which I find a
bit too invasive.
I think having only the existing wrapper use the private heap might be the
better option. It's also easier later to figure out what's really going on.

Can you re-test a less invasive version?

Regards