[Bug 45868] New: Windower 5 beta (FF XI tool) crash: System.ArgumentNullException: Value cannot be null. Parameter name: icon at System.Windows.Interop.Imaging.CreateBitmapSourceFromHIcon() at Windower.UI.StockIcons.GetStockIcon()

https://bugs.winehq.org/show_bug.cgi?id=45868

Bug ID: 45868
           Summary: Windower 5 beta (FF XI tool) crash:
                    System.ArgumentNullException: Value cannot be null.
                    Parameter name: icon  at
                    System.Windows.Interop.Imaging.CreateBitmapSourceFromH
                    Icon() at Windower.UI.StockIcons.GetStockIcon()
           Product: Wine
           Version: 3.16
          Hardware: x86
               URL: http://files.windower.net/5/core/test/windower.portabl
                    e.zip
                OS: Linux
            Status: NEW
          Keywords: dotnet, download
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

Created attachment 62366
  --> https://bugs.winehq.org/attachment.cgi?id=62366
crashlog

Steps:

- winetricks -q dotnet45

- winetricks win7

unzip  ~/Downloads/windower.portable.zip

WINEDLLOVERRIDES=dwmapi,dbghelp=d wine windower.exe

(disable dwmapi to workaround 45832, disable dbghelp to get clear crash,
otherwise crashhandler is invoked that hides the real problem)

sha1sum windower.portable.zip 
96e8492fd229175557b376e030a96f9d50641ded  windower.portable.zip

Hack to get around this bug (showing the problem is in SHGetStockIconInfo most
likely):

diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec
index 837abd3fec..dc7ed03d7c 100644
--- a/dlls/shell32/shell32.spec
+++ b/dlls/shell32/shell32.spec
@@ -400,7 +400,7 @@
 @ stdcall SHGetSpecialFolderLocation(long long ptr)
 @ stdcall SHGetSpecialFolderPathA(long ptr long long)
 @ stdcall SHGetSpecialFolderPathW(long ptr long long)
-@ stdcall SHGetStockIconInfo(long long ptr)
+#@ stdcall SHGetStockIconInfo(long long ptr)
 @ stdcall SHHelpShortcuts_RunDLL(long long long long) SHHelpShortcuts_RunDLLA
 @ stdcall SHHelpShortcuts_RunDLLA(long long long long)
 @ stdcall SHHelpShortcuts_RunDLLW(long long long long)