https://bugs.winehq.org/show_bug.cgi?id=8036
--- Comment #45 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Claudio from comment #44)
I tried already multiple times to raise awareness on this issue, and last time a test failed on Windows, as you can see in the comments above, thus the patch was ignored.
I do not have access to any Windows machine, so keeping this patch up to date for the purpose of keeping the game working is all I can do.
You do not need to have access to a Windows machine to work on Wine. Thats what the Wine testbots are for: https://testbot.winehq.org/ Register a free account, then you can test your patches (or arbitrary crosscompiled tests) in an Windows environment.
Please note that the tests should also pass in Wine without any errors. Your latest patch fixes some issues, but doesn't remove the corresponding todo_wine. Besides that you do not follow the coding style of the sourrounding code, and you also use tabs instead of spaces, which is not allowed in the Wine source.
If you're still interested in fixing this upstream, you should make yourself familiar with the wine test suite / testbot / ..., and then write tests for all the changes you introduce. Changing all functions in a single patch is also a bad idea, better split it up in multiple patches, each with a corresponding test to show that this indeed matches Windows behaviour. Feel free to ask me (via email or in #wine-staging on IRC) if you need any help for that.
I have added a cleaned up version to Wine Staging: https://github.com/wine-compholio/wine-staging/blob/master/patches/kernel32-...