[Bug 52578] New: ShellAbout does not support # in app name

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52578

Bug ID: 52578
           Summary: ShellAbout does not support # in app name
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

EXPECTED

When calling ShellAbout*(), szApp can have a '#' character that triggers
special behavior. The substring before '#' will go in the title bar and the
substring after '#' will go in the body of the about dialog.

ACTUAL

The '#' special behavior is not implemented in Wine, leading to the wrong text
displayed in the About dialog. See the attachment "windle-about.png" that shows
the incorrect behavior. The dialog title should say "About Windle" and the
dialog body should say "Windle 1.0 16-bit".

SUGGESTED FIX

In shell32_main.c:ShellAboutW, the function should check for '#' and extract
the appropriate substrings. If the string does not contain '#', then it should
prepend "About " to the string and use that as the title.

shell32.rc will then need to have the "About %s" changed to just "%s" so that
"About" does not get duplicated.