http://bugs.winehq.org/show_bug.cgi?id=33051
--- Comment #9 from Jinhui Chen chenjh_06@hotmail.com 2013-10-29 06:19:27 CDT --- (In reply to comment #7)
(In reply to comment #6)
What's the problem then? It works quite well for me.
Works well for something is the easy part, the hard part is to clearly understand the original code and make sure not to break anything :)
I would suggest to add some test case in dlls/user32/tests/input.c:1541:test_ToUnicode() ,to approve your change is correct. It would be great to also test for some other case such as Ctrl+, Ctrl+^, Ctrl+_ and Ctrl+`, which satisfy the expression "(keysym > 'Z') && (keysym < 'a')", then we can get an idea if they works the same as Ctrl+]/[. If they works the same, we could have a more general patch. The more tests the better.
You can cross compile the test case and run on a Windows machine. If you don't have Windows you can submit either the patch or the compiled binary to our Wine testbot, see http://wiki.winehq.org/WineTestBot and http://wiki.winehq.org/CompilingDLLsUsingMingw
If you have trouble getting a testbot account please let me know.
Thanks for the work.
Hi Qian Hong, I am sorry but I have no idea of what to test or how to do the tests. Can you give me some test case or would you please do the test yourself?