[Bug 37034] New: Stars!: Crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=37034

Bug ID: 37034
           Summary: Stars!: Crashes on startup
           Product: Wine
           Version: 1.7.23
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 49213
  --> http://bugs.winehq.org/attachment.cgi?id=49213
Console output when the crash occured

Page fault happens in DOSVM_AllocCodeUMB of krnl386.exe16. The apparent cause
is that the DOS upper memory block was never actually allocated before being
used.

I don't know how to attach multiple attachments, so this is a patch I made that
appeared to fix the problem. I don't know much about the internals of Wine so
I'm not sure if this is a good patch or not.

diff --git a/dlls/krnl386.exe16/dosvm.c b/dlls/krnl386.exe16/dosvm.c
index 87adf33..7a3c96e 100644
--- a/dlls/krnl386.exe16/dosvm.c
+++ b/dlls/krnl386.exe16/dosvm.c
@@ -881,6 +881,8 @@ void DOSVM_InitSegments(void)
         0xfb, 0x66, 0xcb  /* sti and 32-bit far return */
     };

+    VirtualAlloc((void *)DOSVM_UMB_BOTTOM, DOSVM_UMB_TOP - DOSVM_UMB_BOTTOM,
MEM_RESERVE | MEM_COMMIT, PAGE_EXECUTE_READWRITE);
+
     /*
      * Allocate pointer array.
      */