[Bug 56630] Broken links in AppDB emails

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56630

--- Comment #5 from Damjan Jovanovic  ---
Indeed, looking through the raw email appdb sent me, there are no MIME type
headers at all! Saving the raw email to a local email.eml file, and opening it
in Thunderbird, also shows broken links.

Fiddling with its headers, I got Thunderbird to open it properly and display
working links by adding these 2 headers. Both were necessary -
Content-Transfer-Encoding alone did not help:

Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

The Mail_Mime class provides these headers through its headers() method, but
that isn't being called. Instead the code builds its own "$headers", without
any of those headers. If we patch appdb to merge those headers with the headers
from Mail_Mime, like this:

---snip---
diff --git a/include/mail.php b/include/mail.php
index 75e30f7..38b54b0 100644
--- a/include/mail.php
+++ b/include/mail.php
@@ -82,7 +82,7 @@ function mail_appdb($sEmailList,$sSubject,$sMsg)
             $headers[$name] = $mime->encodeHeader($name, $value, "utf-8",
"quoted-printable");
         }
         $to = $mime->encodeHeader("to", $sEmailItem, "utf-8",
"quoted-printable");
-        $ret = $mail->send($to, $headers, $sMsg);
+        $ret = $mail->send($to, array_merge($headers, $mime->headers()),
$sMsg);
         if (PEAR::isError($ret))
         {
             // FIXME: need to log email errors somewhere
---snip---

then the bug should be fixed?