[Bug 16684] cnsconf.exe fails to start, fixup error

http://bugs.winehq.org/show_bug.cgi?id=16684

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #6 from Louis Lenders   2009-08-16 10:55:13 ---
Tried the official installer from comment #5. Multiple problems encountered.
The installer only finishes fine after doing 'winetricks msxml3'. Running
cnsconf.exe just reteurns to the console silently. Running it the second time
it crashes into an unimplemented function in ntoskrnl.exe, after that it exits
again silently. A +reley log showed:

0009:Call shlwapi.StrCpyNW(0017fc88,00000000,00000104) ret=004306b2
0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0x7ee58f4f
ip=7ee58f4f tid=0009
0009:trace:seh:raise_exception  info[0]=00000000
.
.
.
0009:Call KERNEL32.CreateFileA(0045c3c0 "C:\users\louis\Local
Se.ttings\Application Data\Oracle\RTC
Client\crash-(null)-2009-08-16.log",c0000000,00000000,00000000,00000002,80000000,00000000)
ret=00431aef
0009:Ret  KERNEL32.CreateFileA() retval=000000c8 ret=00431aef

With native shlwapi at least the gui shows up, though it complains it cannot
connect to the server.

Patch/hack below fixes the problem:

diff --git a/dlls/shlwapi/string.c b/dlls/shlwapi/string.c
index 755360d..694a696 100644
--- a/dlls/shlwapi/string.c
+++ b/dlls/shlwapi/string.c
@@ -498,7 +498,7 @@ LPWSTR WINAPI StrCpyW(LPWSTR lpszStr, LPCWSTR lpszSrc)
 LPWSTR WINAPI StrCpyNW(LPWSTR lpszStr, LPCWSTR lpszSrc, int iLen)
 {
   TRACE("(%p,%s,%i)\n", lpszStr, debugstr_w(lpszSrc), iLen);
-
+  if(!lpszSrc) return 0;
   lstrcpynW(lpszStr, lpszSrc, iLen);
   return lpszStr;
 }

For now I suggest to make this bug about the shlwapi problem.