https://bugs.winehq.org/show_bug.cgi?id=22491
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d1c363424d9ed028d44658bf3ca | |50a6eca2c7528 URL|http://www.ghisler.com/amaz |https://web.archive.org/web |ons3.php |/20210210174604/http://tota | |lcommander.ch/win/old/tcmd7 | |56a.exe Summary|Total Commander: Pressing |Total Commander 7.5x: |the "Program information" |Pressing the 'Program |button opens multiple |information' button opens |windows instead of just one |multiple help (CHM) windows Component|-unknown |hhctrl.ocx CC| |focht@gmx.net
--- Comment #11 from Anastasius Focht focht@gmx.net --- Hello folks,
adding stable download link via Internet Archive for documentation.
https://web.archive.org/web/20210210174604/http://totalcommander.ch/win/old/...
Expanding on Béla's comment 7:
Wine 1.5.7 = multiple help (CHM) windows are opened Wine 1.5.8 = help window opens but TC immediately crashes -> regression
--- snip --- $ pwd /home/focht/.wine/drive_c/totalcmd
$ WINEDEBUG=+tid,+seh,+relay,+htmlhelp wine ./TOTALCMD.EXE >>log.txt 2>&1 ... 0024:trace:htmlhelp:DllMain (0x7d390000,1,(nil)) 0024:trace:htmlhelp:HtmlHelpW ((nil), L"C:\totalcmd\TOTALCMD.CHM", command=HH_DISPLAY_TOC, data=0) 0024:trace:htmlhelp:ReadChmSystem version is 2 0024:trace:htmlhelp:ReadChmSystem Time is 4d09ee08 0024:trace:htmlhelp:ReadChmSystem Version is "HHA Version 4.74.8702\x00" 0024:trace:htmlhelp:ReadChmSystem Locale is: 1033 0024:trace:htmlhelp:ReadChmSystem Default topic is "main_index.htm\x00" 0024:trace:htmlhelp:ReadChmSystem Title is "Total Commander\x00" 0024:trace:htmlhelp:ReadChmSystem Compiled file is "totalcmd\x00" 0024:trace:htmlhelp:ReadChmSystem Default window is "main\x00" 0024:trace:htmlhelp:GetChmString offset 0x1 => "main" 0024:trace:htmlhelp:GetChmString offset 0x6 => "Total Commander" 0024:trace:htmlhelp:GetChmString offset 0x35 => "main_index.htm" 0024:trace:htmlhelp:GetChmString offset 0x16 => "Ordering" 0024:trace:htmlhelp:GetChmString offset 0 => "" 0024:trace:htmlhelp:GetChmString offset 0x44 => "registration.htm" 0024:trace:htmlhelp:GetChmString offset 0 => "" 0024:trace:htmlhelp:GetChmString offset 0x35 => "main_index.htm" 0024:trace:htmlhelp:GetChmString offset 0x1f => "hsc6C4.hhc" 0024:trace:htmlhelp:GetChmString offset 0x2a => "hsc6C4.hhk" 0024:fixme:htmlhelp:TB_AddButtonsFromFlags got asked for unsupported buttons: 140000 0024:trace:htmlhelp:Site_AddRef (0x1153bb8) ref=2 0024:trace:htmlhelp:Site_QueryInterface (0x1153bb8)->({00020400-0000-0000-c000-000000000046} 0x33e1f4) 0024:trace:htmlhelp:Site_QueryInterface (0x1153bb8)->(IID_IDocHostUIHandler 0x33e1ec) 0024:trace:htmlhelp:Site_AddRef (0x1153bb8) ref=3 0024:trace:htmlhelp:Site_QueryInterface (0x1153bb8)->(IID_IOleInPlaceSite 0x33e1f8) 0024:trace:htmlhelp:Site_AddRef (0x1153bb8) ref=4 0024:trace:htmlhelp:Site_Release (0x1153bb8) ref=3 0024:trace:htmlhelp:Site_QueryInterface (0x1153bb8)->({00020400-0000-0000-c000-000000000046} 0x33e18c) 0024:trace:htmlhelp:Site_QueryInterface (0x1153bb8)->({00020400-0000-0000-c000-000000000046} 0x33e18c) 0024:trace:htmlhelp:Site_QueryInterface (0x1153bb8)->(IID_IOleInPlaceSite 0x1154470) 0024:trace:htmlhelp:Site_AddRef (0x1153bb8) ref=4 0024:trace:htmlhelp:Site_AddRef (0x1153bb8) ref=5 0024:trace:htmlhelp:SetChmPath ChmFile = {L"C:\totalcmd\TOTALCMD.CHM" L"hsc6C4.hhc"} 0024:trace:htmlhelp:GetChmStream L"C:\totalcmd\TOTALCMD.CHM" (L"C:\totalcmd\TOTALCMD.CHM" :: L"hsc6C4.hhc") 0024:trace:htmlhelp:parse_hhc <HTML> 0024:trace:htmlhelp:parse_hhc <HEAD> 0024:trace:htmlhelp:parse_hhc <META NAME="GENERATOR" CONTENT="HelpScribble 7.7.4"> 0024:trace:htmlhelp:parse_hhc <!-- Sitemap 1.0 --> 0024:trace:htmlhelp:parse_hhc </HEAD> 0024:trace:htmlhelp:parse_hhc <BODY BGCOLOR="#FFFFFF" TEXT="#000000" LINK="#008000" VLINK="#800080" ALINK="#FF0000"> 0024:trace:htmlhelp:parse_hhc <UL> 0024:trace:htmlhelp:parse_ul <LI> ... 0024:trace:htmlhelp:SetChmPath ChmFile = {L"C:\totalcmd\TOTALCMD.CHM" L"hsc6C4.hhk"} 0024:trace:htmlhelp:GetChmStream L"C:\totalcmd\TOTALCMD.CHM" (L"C:\totalcmd\TOTALCMD.CHM" :: L"hsc6C4.hhk") 0024:trace:htmlhelp:parse_hhindex <HTML> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! HTML 0024:trace:htmlhelp:parse_hhindex <HEAD> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! HEAD 0024:warn:htmlhelp:parse_hhindex Unhandled tag! META 0024:trace:htmlhelp:parse_hhindex <META NAME="GENERATOR" CONTENT="HelpScribble 7.7.4"> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! META 0024:trace:htmlhelp:parse_hhindex <!-- Sitemap 1.0 --> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! !-- 0024:trace:htmlhelp:parse_hhindex </HEAD> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! /HEAD 0024:trace:htmlhelp:parse_hhindex <BODY BGCOLOR="#FFFFFF" TEXT="#000000" LINK="#008000" VLINK="#800080" ALINK="#FF0000"> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! BODY 0024:trace:htmlhelp:parse_hhindex <OBJECT TYPE="text/site properties"> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! OBJECT 0024:trace:htmlhelp:parse_hhindex </OBJECT> 0024:warn:htmlhelp:parse_hhindex Unhandled tag! /OBJECT 0024:trace:htmlhelp:parse_hhindex <UL> 0024:trace:htmlhelp:parse_hhindex <LI> ... 0024:trace:htmlhelp:parse_li <OBJECT TYPE="text/sitemap"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Keyword" VALUE="Sort files"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Local" VALUE="show_sort.htm"> 0024:trace:htmlhelp:parse_index_sitemap_object </OBJECT> 0024:trace:htmlhelp:parse_hhindex <LI> 0024:trace:htmlhelp:parse_li <OBJECT TYPE="text/sitemap"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Keyword" VALUE="Source code"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Local" VALUE="unzipsource.htm"> 0024:trace:htmlhelp:parse_index_sitemap_object </OBJECT> 0024:trace:htmlhelp:parse_hhindex <LI> 0024:trace:htmlhelp:parse_li <OBJECT TYPE="text/sitemap"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Keyword" VALUE="Source: reread"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Local" VALUE="proc_newread.htm"> 0024:trace:htmlhelp:parse_index_sitemap_object </OBJECT> 0024:trace:htmlhelp:parse_hhindex <LI> 0024:trace:htmlhelp:parse_li <OBJECT TYPE="text/sitemap"> 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Keyword" VALUE="Source<-> 0024:warn:htmlhelp:parse_index_obj_node_param value attr not found 0024:trace:htmlhelp:parse_index_sitemap_object <PARAM NAME="Local" VALUE="options_swap.htm"> 0024:trace:htmlhelp:parse_index_sitemap_object </OBJECT> 0024:trace:seh:raise_exception code=c0000005 flags=0 addr=0x7d398ff9 ip=7d398ff9 tid=0024 0024:trace:seh:raise_exception info[0]=00000000 0024:trace:seh:raise_exception info[1]=00000000 0024:trace:seh:raise_exception eax=0119fb80 ebx=7d3a6000 ecx=00000000 edx=0119fb48 esi=0033d2c4 edi=0033d2dc 0024:trace:seh:raise_exception ebp=0033e318 esp=0033d250 cs=0023 ds=002b es=002b fs=0063 gs=006b flags=00010202 0024:trace:seh:call_stack_handlers calling handler at 0x4290c6 code=c0000005 flags=0 --- snip ---
It was likely caused by one of the following commits:
--- snip --- $ git log --oneline wine-1.5.8...wine-1.5.7 -- dlls/hhctrl.ocx
43ecfe036e7 hhctrl.ocx: Use document title for subtopics in the index. 5874d6f1fd8 hhctrl.ocx: Turn multiple index entries of the same name into a single entry. b72ac222ea8 hhctrl.ocx: Keep parsing failure from causing a segmentation fault. fc413c70a5f hhctrl.ocx: Add icons for the table of contents TreeView control. --- snip ---
Bugzilla search with regression sha1 didn't return any hits though.
The crash disappeared with Wine 1.7.14.
--- snip --- $ git log --oneline wine-1.7.13...wine-1.7.14 -- dlls/hhctrl.ocx
ee484b3140e hhctrl.ocx: Permit HTML start/end tags within quoted attributes. 5eb040253c9 hhctrl.ocx: Support delimited filenames for HH_DISPLAY_TOPIC data. --- snip ---
It was fixed by commit https://source.winehq.org/git/wine.git/commitdiff/ee484b3140ee7637f297ed8ed4... ("hhctrl.ocx: Permit HTML start/end tags within quoted attributes.").
Part of Wine 1.7.14 release
Thanks Erich
Also referenced by bug 33489 ("WinRAR 5.0 beta 1 help causes HH crash").
$ wine --version wine-1.7.13-102-gee484b3140e
===
That's not the end of the story ;-)
The regression hided the fix for the problem described here.
The problem was fixed by commit https://source.winehq.org/git/wine.git/commitdiff/d1c363424d9ed028d44658bf3c... ("hhctrl.ocx: Recognize the embedded window name for finding existing windows.").
Part of Wine 1.5.15 Release.
Thanks Erich
Although obvious to me I still validated it by cherry-picking ee484b3140e onto d1c363424d9ed02.
--- snip --- $ git log --oneline -2
255b7f2a300 (HEAD -> master) hhctrl.ocx: Permit HTML start/end tags within quoted attributes. d1c363424d9 hhctrl.ocx: Recognize the embedded window name for finding existing windows. --- snip ---
Using that commit sha1 as resolution here.
$ sha1sum tcmd756a.exe 0771334a3620ebdca43c8e73fad3cccb321284df tcmd756a.exe
$ du -sh tcmd756a.exe 3.2M tcmd756a.exe
$ wine --version wine-1.5.14-149-g255b7f2a300
Regards