http://bugs.winehq.org/show_bug.cgi?id=10134
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #10372|0 |1 is obsolete| |
--- Comment #23 from Anastasius Focht focht@gmx.net 2008-02-25 18:02:39 --- (From update of attachment 10372) Hello,
@dank --- quote --- Alexandre says he just committed http://winehq.org/pipermail/wine-cvs/2008-February/040705.html which should obsolete the patch you gave in #17? --- quote ---
Sure. Thats works too.
But if you allow to express my personal opinion ...
That commit might "cure" that specific bug but in overall it seems a bit problematic to me. Although ntdll.check_actctx is a wine internal helper, guarding it with SEH hides bugs/gaps in ntdll activation context api which could be detected by crashes otherwise (like the ActivationContextBasicInformation one).
Additionally it adds a good amount of access violations/exceptions (in case of .NET) to logs/traces which makes it more difficult to track down the real problems. When I analyze traces/debug stuff I usually hunt for exceptions first... but well.
Regards