[Bug 57163] New: Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Bug ID: 57163
           Summary: Wine Mono support msi no longer installs
           Product: Wine
           Version: 9.16
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Running "make dev-setup" in a wine-mono build tree now fails in the msiexec
step:

wine msiexec /i 'Z:\home\meh\wine-mono\image\support\winemono-support.msi'
015c:fixme:file:NtLockFile I/O completion on lock not implemented yet
make: *** [GNUmakefile:81: dev-setup] Error 123

Bisecting pointed to this commit:
14b718b69bb8d62c3ae84c52d4210e81c1d21208 is the first bad commit
commit 14b718b69bb8d62c3ae84c52d4210e81c1d21208
Author: Hans Leidekker 
Date:   Thu Aug 29 14:44:38 2024 +0200

msiexec: Don't remove quotes from properties passed on the command line.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57024

programs/msiexec/msiexec.c | 43 +++++++++++++++++++++++++++++++++----------
 1 file changed, 33 insertions(+), 10 deletions(-)

But I think the bisect is wrong. When running with a +msiexec,+msi log, it
shows the correct filename passed to MsiInstallProductW:
015c:trace:msi:MsiInstallProductW
L"Z:\home\meh\wine-mono\image\support\winemono-support.msi" (null)

But later the filename is wrong:
015c:warn:msi:MSI_OpenPackageW unable to copy package
L"Z:\home\meh\wine-mono\image\support\winemono-support.msi\0010\0006\0001uZ:\home\meh\wine-mono\image\support\winemono-support.msi"
to L"C:\windows\Installer\989.msi" (123)

Adding warn+heap to the channels causes it to succeed.

So I think what we really have is some sort of memory error in msi that the
change to msiexec happened to trigger with a different allocation pattern.