[Bug 48946] New: Uplay crash when launching Watchdogs with esync patch applied

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48946

Bug ID: 48946
           Summary: Uplay crash when launching Watchdogs with esync patch
                    applied
           Product: Wine-staging
           Version: 5.6
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Created attachment 66920
  --> https://bugs.winehq.org/attachment.cgi?id=66920
Patch to esync, adds sanity checks in queue_rawinput_message

Hello,

I first decribed the problem here: https://github.com/lutris/wine/issues/25

With wine version 5.5 and 5.6 patched with esync, wineserver crashes most of
the time (sometimes it doesn't) when Uplay is about to launch Watchdogs (when
the dialog box appears to explain that disabling uplay overlay is not such a
good idea, or when telling it is starting the game). It doesn't happen with
vanilla wine.

Wine 5.6 + esync patch + -ggdb option during compilation:

Program received signal SIGSEGV, Segmentation fault.
0x000055baca61f208 in queue_rawinput_message (process=0x55bacb873200,
user=0x7fff020150c0) at ../../wine/server/queue.c:1808
1808    ../../wine/server/queue.c: Aucun fichier ou dossier de ce type.
(gdb) backtrace
#0  0x000055baca61f208 in queue_rawinput_message (process=0x55bacb873200,
user=0x7fff020150c0) at ../../wine/server/queue.c:1808
#1  0x000055baca619558 in enum_processes (cb=cb@entry=0x55baca61f140
<queue_rawinput_message>, user=user@entry=0x7fff020150c0) at
../../wine/server/process.c:1080
#2  0x000055baca620f21 in queue_mouse_message (req_flags=<optimized out>,
sender=0x55bacbae5930, origin=1, input=0x55bacb588eb0, win=0,
desktop=0x55bacb588110) at ../../wine/server/queue.c:1901
#3  req_send_hardware_message (req=0x55bacb588ea0, reply=0x7fff02015160) at
../../wine/server/queue.c:2608
#4  0x000055baca62a8d3 in call_req_handler (thread=thread@entry=0x55bacb588d50)
at ../../wine/server/request.c:311
#5  0x000055baca62b902 in read_request (thread=thread@entry=0x55bacb588d50) at
../../wine/server/request.c:345
#6  0x000055baca6314b0 in thread_poll_event (fd=<optimized out>, event=1) at
../../wine/server/thread.c:319
#7  0x000055baca60a106 in fd_poll_event (event=<optimized out>, fd=<optimized
out>) at ../../wine/server/fd.c:486
#8  main_loop_epoll () at ../../wine/server/fd.c:581
#9  0x000055baca60a37e in main_loop () at ../../wine/server/fd.c:947
#10 0x000055baca5f9989 in main (argc=1, argv=0x7fff02015948) at
../../wine/server/main.c:154

The attached patch, applied after esync patch, fixes the problem.

Guillaume