[Bug 12837] Stack trace in socket.c when starting Call of Duty multiplayer

http://bugs.winehq.org/show_bug.cgi?id=12837

--- Comment #4 from Andrew Eleneski   2008-04-27 16:33:35 ---
(In reply to comment #3)
> (In reply to comment #1)
> > If this is CoD 1.x multiplayer then this is a regression.
> >
> > I know of it working correctly around 0.9.41 if any one wishes to do a
> > regression test.  Due to scratches I no longer have a working copy of this
> > game.
>
> I'd be interested to see if it worked before 1bcbe865. However, I don't get
> that compile warning, and I really don't see how it could happen with the
> current code.

This is the code around 3247:

if (retval->h_addr_list == 127 &&
        strcmp(name, "localhost") != 0)
    {
        /* hostname != "localhost" but has loopback address. replace by our
         * special address.*/
        memcpy(retval->h_addr_list[0], magic_loopback_addr, 4);
    }

I am also running gcc 4.2.3.

Now I also have tried changing the if to

if (retval && retval->h_addr_list == 127 &&
        strcmp(name, "localhost") != 0)

and the compile warning stays, but I am able to start COD without a stack
trace.