http://bugs.winehq.org/show_bug.cgi?id=4242
xerox_xerox2000@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@codeweavers.com
------- Additional Comments From xerox_xerox2000@yahoo.co.uk 2006-07-06 12:30 ------- regreession test shows this patch causes the crash: http://cvs.winehq.org/patch.py?id=19390 Reverting the following part of the patch makes the application start finee again. Added author of thee patch.
diff -u -p wine/dlls/user/win.c:1.16 wine/dlls/user/win.c:1.17 --- wine/dlls/user/win.c:1.16 Wed Jun 7 17:04:49 2006 +++ wine/dlls/user/win.c Wed Jun 7 17:04:49 2006 @@ -1025,7 +1025,15 @@ static HWND WIN_CreateWindowEx( CREATEST if (((wndPtr->dwStyle & (WS_CAPTION|WS_CHILD)) == WS_CAPTION) || (wndPtr->dwExStyle & WS_EX_APPWINDOW)) { - if (cs->hMenu) MENU_SetMenu(hwnd, cs->hMenu); + if (cs->hMenu) + { + if (!MENU_SetMenu(hwnd, cs->hMenu)) + { + WIN_ReleasePtr( wndPtr ); + free_window_handle( hwnd ); + return 0; + } + }