[Bug 45169] New: Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

Bug ID: 45169
           Summary: Commit "shell32: Handle writing an iconresource entry
                    in  SHGetSetFolderCustomSettings" changes return value
                    to E_FAIL
           Product: Wine
           Version: 3.7
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello,

we have a regression with new crashes of a proprietary application. A bisect
shows as _one_ problematic patch:
> From 730264609f468d7aa0973edc9a435bd20373c1cd Mon Sep 17 00:00:00 2001

From: Louis Lenders 
Date: Mon, 30 Apr 2018 09:22:42 +0200
Subject: [PATCH] shell32: Handle writing an iconresource entry in
 SHGetSetFolderCustomSettings.

Signed-off-by: Louis Lenders 
Signed-off-by: Alexandre Julliard 
---
 dlls/shell32/shlfolder.c       | 38 ++++++++++++++++++++++++++++++++++----
 dlls/shell32/tests/shlfolder.c |  4 ++--
 2 files changed, 36 insertions(+), 6 deletions(-)

Prior to this patch the function returned always E_NOTIMPL.

This patch changes the return value from E_NOTIMPL to E_FAIL even when flags is
not FCS_FORCEWRITE and when fcs->dwMask is not FCSM_ICONFILE.

At least the first case is also with the patch not implemented and should
return E_NOTIMPL.

Changing this return values changes the behavior of our application (which
shows the next crash :-).