https://bugs.winehq.org/show_bug.cgi?id=53472
Bug ID: 53472 Summary: Kerberos auth broken since 7.10 Product: Wine Version: 7.10 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: incubusrk@gmail.com Distribution: ---
Created attachment 72833 --> https://bugs.winehq.org/attachment.cgi?id=72833 Output logs with WINEDEBUG=+kerberos
After update from 7.9 to 7.10 version kerbrous authentification no longer working. Problem also exists in 7.14.
https://bugs.winehq.org/show_bug.cgi?id=53472
Konstantin incubusrk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #1 from Hans Leidekker hans@meelstraat.net --- Looks like the wow64 support patches caused this. Can you perform a regression test to narrow it down?
https://bugs.winehq.org/show_bug.cgi?id=53472
Vitaly Lipatov lav@etersoft.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lav@etersoft.ru
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #2 from Konstantin incubusrk@gmail.com --- Unfortunately I didn't succeed in bisecting. It seems to me that commit 5c56d719 may affect this.
Message in log files look like that second parameter of kerberos_SpInitLsaModeContext has wrong type casted.
https://bugs.winehq.org/show_bug.cgi?id=53472
Konstantin incubusrk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #3 from Konstantin incubusrk@gmail.com --- Created attachment 72942 --> https://bugs.winehq.org/attachment.cgi?id=72942 patch to fix kerberos_SpInitLsaModeContext logic
commit 0e6b727511e610019a8fc1d84948f2045bb10e18 broke logic in kerberos_SpInitLsaModeContext
https://bugs.winehq.org/show_bug.cgi?id=53472
Konstantin incubusrk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |0e6b727511e610019a8fc1d8494 | |8f2045bb10e18
https://bugs.winehq.org/show_bug.cgi?id=53472
Konstantin incubusrk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=53472
Konstantin incubusrk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #72942|0 |1 is obsolete| |
--- Comment #4 from Konstantin incubusrk@gmail.com --- Created attachment 72943 --> https://bugs.winehq.org/attachment.cgi?id=72943 patch kerberos_SpInitLsaModeContext kerberos_SpAcceptLsaModeContext
kerberos_SpAcceptLsaModeContext possible also need fix.
IMHO value of "new_context" must be updated regardless of the returned "status" in both cases. So it was before the commit.
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #5 from Hans Leidekker hans@meelstraat.net --- (In reply to Konstantin from comment #4)
Created attachment 72943 [details] patch kerberos_SpInitLsaModeContext kerberos_SpAcceptLsaModeContext
kerberos_SpAcceptLsaModeContext possible also need fix.
IMHO value of "new_context" must be updated regardless of the returned "status" in both cases. So it was before the commit.
It's updated when the returned status is SEC_E_OK or SEC_I_CONTINUE_NEEDED.
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #6 from Konstantin incubusrk@gmail.com --- As I see it "if (!status)" true only when status is SEC_E_OK. It must be something like "if (!status||status==SEC_I_CONTINUE_NEEDED)"... Also action that create_context_handle() makes took place inside the call initialize_context before return and checking status.
Any way put "*new_context = create_context_handle..." out of if block resolve issue in real domain network.
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #7 from Konstantin incubusrk@gmail.com --- Created attachment 72944 --> https://bugs.winehq.org/attachment.cgi?id=72944 log after patch applyed
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #8 from Hans Leidekker hans@meelstraat.net --- (In reply to Konstantin from comment #7)
Created attachment 72944 [details] log after patch applyed
This should be fixed with 0b18d0c825848abeec62b650d3b95056297c5d87, right?
https://bugs.winehq.org/show_bug.cgi?id=53472
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead@gmail.com |
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #9 from Nikolay Sivov bunglehead@gmail.com --- Thank you for taking care of this.
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #10 from Konstantin incubusrk@gmail.com --- (In reply to Hans Leidekker from comment #8)
(In reply to Konstantin from comment #7)
Created attachment 72944 [details] log after patch applyed
This should be fixed with 0b18d0c825848abeec62b650d3b95056297c5d87, right?
Yes, you are right
https://bugs.winehq.org/show_bug.cgi?id=53472
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |0b18d0c825848abeec62b650d3b | |95056297c5d87 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #11 from Hans Leidekker hans@meelstraat.net --- Thanks for your patch.
https://bugs.winehq.org/show_bug.cgi?id=53472
--- Comment #12 from Konstantin incubusrk@gmail.com --- You're welcome.
https://bugs.winehq.org/show_bug.cgi?id=53472
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.16.