[Bug 55457] New: Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

Bug ID: 55457
           Summary: Robot Battle 1.4 crashes on startup after commit
                    08dc691d
           Product: Wine
           Version: 8.13
          Hardware: x86-64
               URL: https://web.archive.org/web/20130317061354/http://www.
                    robotbattle.com/download/latest.php
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: mshtml
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 08dc691dfb410de7115db3f9c34b225327e21f67
      Distribution: ---

Created attachment 75018
  --> https://bugs.winehq.org/attachment.cgi?id=75018
Backtrace Log

Robot Battle 1.4 crashes on startup. A bisect found commit 08dc691d ("mshtml:
Explicitly hold ref to the plugin host in NPP_New.") is the cause.

I've set the URL field here to a working link for the installer.

It looks like a NULL dereference at IOleClientSite_AddRef when
container->plugin_host is failed to be created.

A simple patch that fixes this for me is to check for err before attempting
IOleClientSite_AddRef.

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

--- Comment #1 from James Beddek  ---
Created attachment 75019
  --> https://bugs.winehq.org/attachment.cgi?id=75019
Wine Log

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

--- Comment #2 from James Beddek  ---
Created attachment 75020
  --> https://bugs.winehq.org/attachment.cgi?id=75020
Patch

MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

James Beddek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, regression

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

--- Comment #3 from Gabriel Ivăncescu  ---
Sorry about that, thanks for catching this and the fix.

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

--- Comment #4 from James Beddek  ---
This should probably have been closed for the 8.14 release, no? What's the
policy around that, should I have included a 'Fixes' tag in the commit?

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |2846111765350def595de6e9d54
                   |                            |bc33d250e808b
         Resolution|---                         |FIXED

--- Comment #5 from Gijs Vermeulen  ---
(In reply to James Beddek from comment #4)
> This should probably have been closed for the 8.14 release, no? What's the
> policy around that, should I have included a 'Fixes' tag in the commit?

This bug has to be marked resolved FIXED still. This doesn't happen
automatically. Since you filed this bug, you have the ability to do this
yourself. I'll mark it as such now.

Thanks for your bug and patch!

[Bug 55457] Robot Battle 1.4 crashes on startup after commit 08dc691d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55457

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 8.15.