https://bugs.winehq.org/show_bug.cgi?id=52202
Bug ID: 52202 Summary: No audio sound - regression in winecoreaudio.drv Product: Wine Version: 6.23 Hardware: x86-64 OS: Mac OS X Status: UNCONFIRMED Severity: blocker Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: reinhold.hoffmann@hotmail.com
No audio sound on a Mac.
Regression bug in winecoreaudio.drv of Wine-6.23.
For the time being I just opened this bug to indicate that this regression is blocking for Wine-7.0 on macOS.
According to Gcenx the regression may have happen with commit 75b57ea13de48994d29401afebbbe534cd503b86 onwards as that is the start of the winecoreaudio.drv rework.
Please see the detailed discussion of this issue in the past days at https://github.com/Gcenx/macOS_Wine_builds/issues/30
Sorry that I had to open this bug report this way. But I totally busy these days and I want to make you aware due to the upcoming code freeze. Thanks for the understanding.
https://bugs.winehq.org/show_bug.cgi?id=52202
Reinhold reinhold.hoffmann@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |75b57ea13de48994d29401afebb | |be534cd503b86
https://bugs.winehq.org/show_bug.cgi?id=52202
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Component|-unknown |winecoreaudio.drv Summary|No audio sound - regression |Wine doesn't output any |in winecoreaudio.drv |sound when using | |winecoreaudio.drv
--- Comment #1 from Gijs Vermeulen gijsvrm@gmail.com --- Can this be reproduced with winecfg? If not, it would be nice to have an example of an application this could be reproduced with.
https://bugs.winehq.org/show_bug.cgi?id=52202
--- Comment #2 from Reinhold reinhold.hoffmann@hotmail.com --- Created attachment 71283 --> https://bugs.winehq.org/attachment.cgi?id=71283 Terminal output for Wine-6.22 with sound OK
https://bugs.winehq.org/show_bug.cgi?id=52202
--- Comment #3 from Reinhold reinhold.hoffmann@hotmail.com --- Created attachment 71284 --> https://bugs.winehq.org/attachment.cgi?id=71284 Terminal output for Wine-6.23 with no sound
https://bugs.winehq.org/show_bug.cgi?id=52202
--- Comment #4 from Reinhold reinhold.hoffmann@hotmail.com --- For the testing I used the Mac builds of Gcenx. See https://github.com/Gcenx/macOS_Wine_builds
After verbose testing of Wine-6.23 on Catalina and Mojave I come to the conclusion that there is something broken in Wine-6.23 package regarding the audio output on macOS. In 10:1 cases there is no sound. The issue does not exist on Linux. On Linux Ubuntu Wine-6.23 is OK and the sound is perfect. On Catalina (2 installations) and Mojave I compared Wine-6.23 with the previous versions of Wine-6.19 to Wine-6.22. All previous versions are OK. But when updating or in a fresh installation of Wine-6.23, there is no sound in 10:1 cases.
I have done the testing with our software from https://www.notation.com/Player.php which is a MIDI player which uses the fluidsynth libraries for audio output (see https://www.fluidsynth.org/). When switching the MIDI Player to forward the MIDI output to the Coreaudio MIDI engine of a Mac, the sound is OK.
Therefore I conclude there is something broken on the MAC Wine-6.23 package for audio output.
In a discussion with Gcenx we identified the changes in winecoreaudio.drv which were done beginning with the commit 75b57ea13de48994d29401afebbbe534cd503b86 may cause the regression.
In order to demontrate the problem on Catalina I used 2 Wine bottles for Wine-6.22 and Wine-6.23. Both are identical except for the Wine version. I ran the same the audio playback song on both Wine bottles.
To reproduce the problem
(1) Download Notation Player 4 from https://www.notation.com/Player.php (2) Install it (3) Start it and open a MIDI File through the link on the front page "OPEN A MIDI OR .NOT FILE" (4) Play the opened song
PROBLEM: On Wine-6.22 the sound is OK, on Wine-6.23 there is no sound
Please find attached 2 files with the terminal output (1) LOG_Wine-6_22.txt, sound is OK here (2) LOG_Wine-6_23.txt, no sound. In LOG_Wine-6_23.txt at the end of the file I cut down the number of messages fluidsynth: warning: Ringbuffer full, try increasing polyphony! to a few because there happen on and on. .
I looked into the fluidsynth code (I am not an expert here) but that looks as if the ringbuffer for audio output is not properly managed by the driver side. We use fluidsynth 2.1.0 which isn't the latest but have many thousends of installations on various platforms at thousends of users. With these findings I conclude that the issue is probably a regression in winecoreaudio.drv.
I have not tested other audio players but they probably behave the same.
The comment about winecfg I do not understand because winecfg is not an audio player.
https://bugs.winehq.org/show_bug.cgi?id=52202
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |huw.davies@physics.ox.ac.uk
https://bugs.winehq.org/show_bug.cgi?id=52202
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Ever confirmed|0 |1 URL| |https://www.notation.com/Do | |wnloadTrialProduct.php?Tria | |l_Product=Player_English Summary|Wine doesn't output any |Notation Player 4 has no |sound when using |sound while playing MIDI |winecoreaudio.drv |file when using | |winecoreaudio.drv Severity|blocker |normal Regression SHA1|75b57ea13de48994d29401afebb |61337a1d16639ce0a1f809be607 |be534cd503b86 |20c6b2aeec8b6 Status|UNCONFIRMED |NEW
--- Comment #5 from Gijs Vermeulen gijsvrm@gmail.com --- I narrowed down the commit to the following commit:
61337a1d16639ce0a1f809be60720c6b2aeec8b6 is the first bad commit commit 61337a1d16639ce0a1f809be60720c6b2aeec8b6 Author: Huw Davies huw@codeweavers.com Date: Tue Nov 30 07:56:31 2021 +0000
winecoreaudio: Switch midi_in_lock() away from a syscall prototype.
Going to the previous commit fixes the issue. When testing, sometimes it would play a few seconds of audio before completely refusing to play any audio whatsoever. The audio does play consistently on the commit before the aforementioned commit, so I'm pretty certain this is the correct commit.
https://bugs.winehq.org/show_bug.cgi?id=52202
--- Comment #6 from Reinhold reinhold.hoffmann@hotmail.com --- Thx for narrowing down.
It is not only relevant to Notation Player 4 and all Notation Software apps but impacts at least all other Windows audio software which use fluidsynth. See https://github.com/FluidSynth/fluidsynth/wiki/Applications To me a fix is a must for Wine-7.0
https://bugs.winehq.org/show_bug.cgi?id=52202
Huw Davies huw.davies@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|61337a1d16639ce0a1f809be607 |7d76fee5f48a3f8ddff25c23cd7 |20c6b2aeec8b6 |4aad4aaa4e910
--- Comment #7 from Huw Davies huw.davies@physics.ox.ac.uk --- This is actually due to commit 7d76fee5f48a3f8ddff25c23cd74aad4aaa4e910
I've sent a patch that fixes this: https://source.winehq.org/patches/data/222478
https://bugs.winehq.org/show_bug.cgi?id=52202
Huw Davies huw.davies@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |e03611ee599a47593742414540c | |d01a0ed9623c2 Resolution|--- |FIXED
--- Comment #8 from Huw Davies huw.davies@physics.ox.ac.uk --- Fix committed as e03611ee599a47593742414540cd01a0ed9623c2 which will be present in the upcoming 7.0-rc3.
https://bugs.winehq.org/show_bug.cgi?id=52202
--- Comment #9 from Reinhold reinhold.hoffmann@hotmail.com --- Thanks for fixing. I will verify the fix as soon as Wine-7.0-rc3 is available for a Mac.
https://bugs.winehq.org/show_bug.cgi?id=52202
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc3.
https://bugs.winehq.org/show_bug.cgi?id=52202
--- Comment #11 from Reinhold reinhold.hoffmann@hotmail.com --- Fix confirmed. Tested with 7.0-rc6 on various Mac versions.