[Bug 51907] New: ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

Bug ID: 51907
           Summary: ddraw games don't work in xwayland
           Product: Wine
           Version: 6.19
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

So far, I've tested Age of Empires II: The Conquerors 1.0c and Starcraft
Broodwar 1161. They both fail with the same error message:

```
0024:err:ddraw:ddraw_surface_create Failed to reset device.
```

Both games work fine in the standalone Xorg server. Neither works, whether I
use weston or sway.

Experimentally, I've determined that the games work in 5.13 and break in 5.14,
so I guess the bug was introduced in version 5.14.

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
Could you do a bisect tp see what regression breaks it?

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

Paul Gofman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Paul Gofman  ---
Maybe full (possibly compressed if it is big) log with
WINEDEBUG=+ddraw,+d3d,+x11drv,+wgl,+win,+xrandr can show something.

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

Eric Toombs  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Eric Toombs  ---
Created attachment 70875
  --> https://bugs.winehq.org/attachment.cgi?id=70875
BW1161 in wine 6.17 in sway+xwayland, detailed log
> WINEDEBUG='+ddraw,+d3d,+x11drv,+wgl,+win,+xrandr' wine ~/.wine/drive_c/Program\ Files/Starcraft/StarCraft.exe &>/tmp/bw1161.log

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

--- Comment #4 from Paul Gofman  ---
Created attachment 70876
  --> https://bugs.winehq.org/attachment.cgi?id=70876
Validate pitch against the new format in wined3d_texture_update_desc().

Although I am not sure that this is the issue here I see this in the log:
> 0024:err:winediag:wined3d_dll_init Disabling 3D support.

This suggests renderer is manually set to 'gdi' or 'no3d' in the registry. I
suggest running on the clean prefix without custom options. If you believe
there is a reason to set that then this is something worth describing, as well
as generally the fact of using any non default options when reporting a bug.

Although in this case it might be not related really, I think I see at least
immediate reason for the failure. Can you please check if the attached patch is
fixing the issue if possible?

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

--- Comment #5 from Eric Toombs  ---
(In reply to Fabian Maurer from comment #1)
> Could you do a bisect to see what regression breaks it?

I could. Are there any extra steps to running a wine compiled in the git root
with a prefix at ~/.wine?

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

--- Comment #6 from Eric Toombs  ---
(In reply to Paul Gofman from comment #4)
> Created attachment 70876 [details]
> Validate pitch against the new format in wined3d_texture_update_desc().
>
> Although I am not sure that this is the issue here I see this in the log:
> > 0024:err:winediag:wined3d_dll_init Disabling 3D support.
>
> This suggests renderer is manually set to 'gdi' or 'no3d' in the registry. I
> suggest running on the clean prefix without custom options. If you believe
> there is a reason to set that then this is something worth describing, as
> well as generally the fact of using any non default options when reporting a
> bug.
>
> Although in this case it might be not related really, I think I see at least
> immediate reason for the failure. Can you please check if the attached patch
> is fixing the issue if possible?

Can't I just set renderer= to its default option? I'd rather not have to
reinstall starcraft again. It's kind of involved. What is renderer='s default
option?

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Zebediah Figura  ---
The default is currently "gl", although you can achieve the same behaviour by
deleting the registry value.

[Bug 51907] ddraw games don't work in xwayland

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51907

--- Comment #8 from Eric Toombs  ---
Created attachment 70887
  --> https://bugs.winehq.org/attachment.cgi?id=70887
BW1161 with renderer=gl
> winetricks renderer=gl
> WINEDEBUG='+ddraw,+d3d,+x11drv,+wgl,+win,+xrandr' wine ~/.wine/drive_c/Program\ Files/Starcraft/StarCraft.exe &>/tmp/bw1161-gl.log