[Bug 54683] New: shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

Bug ID: 54683
           Summary: shlwapi:ordinal - test_SHFormatDateTimeA() fails due
                    to daylight saving time on Windows
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shlwapi
          Assignee: [e-mail]
          Reporter: [e-mail]

shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on
Windows:

ordinal.c:1734: Test failed: expected (12:00 PM), got (11:00 AM)
ordinal.c:1741: Test failed: expected (12:00:00 PM), got (11:00:00 AM)
ordinal.c:1749: Test failed: expected (12:00:00 PM), got (11:00:00 AM)
ordinal.c:1779: Test failed: expected (12:00 PM), got (11:00 AM) for time part
ordinal.c:1793: Test failed: expected (12:00:00 PM), got (11:00:00 AM) for time
part
ordinal.c:1811: Test failed: expected (2/14/2023 12:00 PM), got (2/14/2023
11:00 AM)
ordinal.c:1822: Test failed: expected (2/14/2023 12:00:00 PM), got (2/14/2023
11:00:00 AM)

See https://test.winehq.org/data/patterns.html#shlwapi:ordinal

The AM/PM translations can change the failure messages slightly but it's always
the same issue, on all Windows versions... except w10pro64v2004!

This set of failures started on 2023-03-13 which, together with the 1 hour
offset, clearly corresponds to the switch from CST to CDT (there was no
WineTest run on Sunday).

[Bug 54683] shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 54683] shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |90dfa808bfddb8a7fd6ec19a2ce
                   |                            |13953ea4a2aa0
           Keywords|                            |regression

[Bug 54683] shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

Jeff Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jeff Smith  ---
I created a fix for this as part of
https://gitlab.winehq.org/wine/wine/-/merge_requests/3700

[Bug 54683] shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

--- Comment #2 from Jeff Smith  ---
This was merged, and the tests have been succeeding since, according to:

http://test.winehq.org/data/tests/shlwapi:ordinal.html

So I think this can be marked CLOSED/FIXED.

[Bug 54683] shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9bc503b6bb269f314e593726386
                   |                            |c3cba6b1a5681
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from François Gouget  ---
Yes this is fixed. Thanks!

[Bug 54683] shlwapi:ordinal - test_SHFormatDateTimeA() fails due to daylight saving time on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54683

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.16.