[Bug 38980] New: World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Bug ID: 38980
           Summary: World of Warships/Planes/Tanks client in torrent
                    download mode crashes spuriously on high bandwidth
                    load (i/o completion ports)
           Product: Wine
           Version: 1.7.47
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

while checking out some 'World of Warships/Planes/Tanks' issues, I've seen this
"turn off torrent downloader to avoid crash" note multiple times in WineHQ
appdb entries and also on various Internet sites.

Although this workaround solves the actual client download/updater problem, it
seems no one bothered to report this here for some years?

I could reproduce crashes with all 'World of WarXXX' clients using the torrent
download mode.
The crash is caught before any registered JIT debugger ('AeDebug') as the
client installs a top level exception filter.
Upon failure it simply displays a message box with the option to restart the
download client.

Client log file:

--- snip ---
...
26/07/2015 19:46:31          Loading localized resources...
26/07/2015 19:46:32          Loading configuration...
26/07/2015 19:46:32          Setup language: content_lang="en" 
26/07/2015 19:46:32          Start "WoWSLauncher.exe"
params="C:\Games\World_of_Warships\WoWSLauncher.exe"
26/07/2015 19:46:32          Session
id="a01bae86c620733b0ed98078ba6a9bbff72bfd12"
26/07/2015 19:46:32          Info for "WoWSLauncher.exe": Version: 0.3.13.242,
Comment: "Built: 20150622 142954, Revision: #586733 (stable_3.13.3)"
26/07/2015 19:46:32          Create update folder:
path="C:\Games\World_of_Warships\Updates"
26/07/2015 19:46:32          Try access patch folder:
path="C:\Games\World_of_Warships\Updates"
26/07/2015 19:46:32          Create temp folder:
path="C:\Games\World_of_Warships\UpdatesData\temp"
26/07/2015 19:46:32          Try access temp folder:
path="C:\Games\World_of_Warships\UpdatesData\temp"
26/07/2015 19:46:32          Save configuration:
path="C:\Games\World_of_Warships\WoWSLauncher.cfg"
26/07/2015 19:46:33          Start update process
26/07/2015 19:46:33          Clear old/temp files
26/07/2015 19:46:33          Obtain patch information. target: "launcher"...
26/07/2015 19:46:33          Create update work folder:
path="C:\Games\World_of_Warships\UpdatesData\launcher"
26/07/2015 19:46:33          Try access patch work folder:
path="C:\Games\World_of_Warships\UpdatesData\launcher"
26/07/2015 19:46:33          System update. Cleaning up system update folder.
26/07/2015 19:46:33          send http request. url:
"http://update.worldofwarships.eu?target=launcher&client_ver=unknown&..."
26/07/2015 19:46:33          http request complete.
26/07/2015 19:46:33          target is up to date
26/07/2015 19:46:33          Update complete: target=launcher
26/07/2015 19:46:33          Obtain patch information. target: "client"...
26/07/2015 19:46:33          Create update work folder:
path="C:\Games\World_of_Warships\UpdatesData\client"
26/07/2015 19:46:33          Try access patch work folder:
path="C:\Games\World_of_Warships\UpdatesData\client"
26/07/2015 19:46:33          patch is available. version_from: 0.unknown,
version_to: 40.105823
26/07/2015 19:46:33          patch file. name: "wows_40.103115_client.patch",
size: 3105783438
26/07/2015 19:46:33          patch file. name:
"wows_40.103116_40.103115_client.patch", size: 1487947994
26/07/2015 19:46:33          patch file. name:
"wows_40.103886_40.103116_client.patch", size: 37739650
26/07/2015 19:46:33          patch file. name:
"wows_40.103887_40.103886_client.patch", size: 2224
26/07/2015 19:46:33          patch file. name:
"wows_40.105234_40.103887_client.patch", size: 33520274
26/07/2015 19:46:33          patch file. name:
"wows_40.105823_40.105234_client.patch", size: 230571882
26/07/2015 19:46:33          send http request. url:
"http://update.worldofwarships.eu?target=client&client_ver=unknown&la..."
26/07/2015 19:46:34          http request complete.
26/07/2015 19:46:34          patch is available. version_from: 0.unknown,
version_to: 40.105823
26/07/2015 19:46:34          patch file. name: "wows_40.103115_client.patch",
size: 3105783438
26/07/2015 19:46:34          patch file. name:
"wows_40.103116_40.103115_client.patch", size: 1487947994
26/07/2015 19:46:34          patch file. name:
"wows_40.103886_40.103116_client.patch", size: 37739650
26/07/2015 19:46:34          patch file. name:
"wows_40.103887_40.103886_client.patch", size: 2224
26/07/2015 19:46:34          patch file. name:
"wows_40.105234_40.103887_client.patch", size: 33520274
26/07/2015 19:46:34          patch file. name:
"wows_40.105823_40.105234_client.patch", size: 230571882
26/07/2015 19:46:34          Getting torrent files via http...
26/07/2015 19:46:34          send http request(attempt: 1). url:
"http://wg.gcdn.co/wows_a/eu/patches/4.0_QRWpTV0q/wows_40.103115_client.patch..."
26/07/2015 19:46:34          http request complete.
26/07/2015 19:46:34          torrent file created. name:
"wows_40.103115_client.patch.torrent"
26/07/2015 19:46:34          send http request(attempt: 1). url:
"http://wg.gcdn.co/wows_a/eu/patches/4.0_QRWpTV0q/wows_40.103116_40.103115_cl..."
26/07/2015 19:46:34          http request complete.
26/07/2015 19:46:34          torrent file created. name:
"wows_40.103116_40.103115_client.patch.torrent"
26/07/2015 19:46:34          Getting patch files via ptp...
26/07/2015 19:46:34          Initializing P2P session, extensions=true
26/07/2015 19:47:55  ERROR:    Unexpected exception:
code=EXCEPTION_ACCESS_VIOLATION flags=0 addr=0
26/07/2015 19:48:06          restart launcher: cmd="-restart" 
--- snip ---

The client makes extensive use of I/O Completion Ports (IOCP) with a
considerable number of worker threads (thread pool) for servicing them.

Although the crash occurs kind of randomly, the crash site seems not.

--- snip ---
...
00556EAB  8B4D 00         MOV ECX,DWORD PTR SS:[EBP]
00556EAE  F7D9            NEG ECX
00556EB0  1BC9            SBB ECX,ECX
00556EB2  F7C1 70E64100   TEST ECX,41E670
00556EB8  0F84 9C000000   JE WoWSLaun.00556F5A
00556EBE  8D5424 34       LEA EDX,DWORD PTR SS:[ESP+34]
00556EC2  52              PUSH EDX
00556EC3  8D8E 4C020000   LEA ECX,DWORD PTR DS:[ESI+24C]
00556EC9  E8 92C5F4FF     CALL
WoWSLaun.?address@endpoint@detail@ip@asio@boost@@QB
00556ECE  837C24 34 01    CMP DWORD PTR SS:[ESP+34],1
00556ED3  0F94C0          SETE AL
00556ED6  0FB6C8          MOVZX ECX,AL
00556ED9  51              PUSH ECX
00556EDA  57              PUSH EDI
00556EDB  8D4E 48         LEA ECX,DWORD PTR DS:[ESI+48]
00556EDE  E8 6DBCFFFF     CALL WoWSLaun.00552B50
00556EE3  8B16            MOV EDX,DWORD PTR DS:[ESI]
00556EE5  8B42 70         MOV EAX,DWORD PTR DS:[EDX+70]
00556EE8  57              PUSH EDI
00556EE9  55              PUSH EBP
00556EEA  8BCE            MOV ECX,ESI
00556EEC  FFD0            CALL EAX             ; NULL -> *boom*
00556EEE  8B16            MOV EDX,DWORD PTR DS:[ESI]
00556EF0  8B42 1C         MOV EAX,DWORD PTR DS:[EDX+1C]
00556EF3  6A 00           PUSH 0
00556EF5  55              PUSH EBP
00556EF6  8BCE            MOV ECX,ESI
00556EF8  FFD0            CALL EAX
00556EFA  8A86 B4030000   MOV AL,BYTE PTR DS:[ESI+3B4]
...
--- snip ---

I partially reconstructed the call chain for the crash site:

--- snip ---
<crash site>
...
<5-7 unknown call frames in between>
...
WoWSLaun.private: unsigned int __thiscall
boost::asio::detail::win_iocp_io_service::do_one(BOOL,class
boost::system::error_code &)
...
WoWSLaun.public: unsigned int __thiscall
boost::asio::detail::win_iocp_io_service::run(class boost::system::error_code
&)
..
WoWSLaun.public: unsigned int __thiscall boost::asio::io_service::run(class
boost::system::error_code &)
...
WoWSLaun.unsigned int __stdcall boost::asio::detail::win_thread_function(void
*)
--- snip ---

I found some hints in the launcher about the Boost library version used:

--- snip ---
e:\work\5c6ecc6fb8b7976a\libraries\boost_1_54_0\boost/exception/detail/exception_ptr.hpp
class boost::exception_ptr __cdecl
boost::exception_detail::get_static_exception_object<struct
boost::exception_detail::bad_alloc_>(void)   -  
e:\work\5c6ecc6fb8b7976a\libraries\boost_1_54_0\boost/exception/detail/exception_ptr.hpp
...
--- snip ---

Which leads to:

http://www.boost.org/doc/libs/1_54_0/boost/asio/detail/impl/win_iocp_io_serv...

There is a number of internal calls in between the crash site and Boost IOCP
code ('op->complete()' -> 'win_iocp_operation' + function pointer call
hierarchy).

Debugging/relay tracing a problem which seems to occur at random times in a
multi-Gigabyte download, also requiring high download speeds is not really
funny :|

Anyway, it's now documented here for reference.

It would be interesting to know if this torrent download problem occurs on
Windows too, albeit much less frequent.
Reading up some forums I got the impression...

$ sha1sum WoWS_internet_install_eu.exe
e9d3fcc8d4d8a2a88678fa75840d4e76a71b7977  WoWS_internet_install_eu.exe

$ du -sh WoWS_internet_install_eu.exe
6.7M    WoWS_internet_install_eu.exe

$ wine --version
wine-1.7.47-196-g4e6e9a1

Regards

[Bug 38980] World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://worldofwarships.eu/e
                   |                            |n/game/download/

[Bug 38980] World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

--- Comment #1 from Anastasius Focht  ---
Hello folks,

still encountered with recent (big) 0.5.1.x updates (1.5GB).

It seems that rate-limiting the builtin torrent client via its own settings
mitigates the problem.
For testing I set the limit to 50% of bandwidth (3 MB/s instead of maxing out
at ~6 MB/s) and didn't encounter a crash.

ProtectionID scan for exact version numbers:

--- snip ---
-=[ ProtectionID v0.6.6.7 DECEMBER]=-
(c) 2003-2015 CDKiLLER & TippeX
Build 24/12/14-22:48:13
Ready...

Scanning ->
Z:\home\focht\wine-games\wineprefix64-wargaming\drive_c\Games\World_of_Warships\WoWSLauncher.exe
File Type : 32-Bit Exe (Subsystem : Win GUI / 2), Size : 7391496 (070C908h)
Byte(s)
Compilation TimeStamp : 0x5641DAC7 -> Tue 10th Nov 2015 11:53:43 (GMT)
[TimeStamp] 0x5641DAC7 -> Tue 10th Nov 2015 11:53:43 (GMT) | PE Header | - |
Offset: 0x00000108 | VA: 0x00400108 | -
[TimeStamp] 0x5641DAC1 -> Tue 10th Nov 2015 11:53:37 (GMT) | Export | - |
Offset: 0x00473514 | VA: 0x00874B14 | -
[TimeStamp] 0x5641DAC7 -> Tue 10th Nov 2015 11:53:43 (GMT) | DebugDirectory | -
| Offset: 0x003D2184 | VA: 0x007D3784 | -
-> File Appears to be Digitally Signed @ Offset 070BC00h, size : 0D08h / 03336
byte(s)
[!] Executable uses TLS callbacks (1 total... 0 invalid addresses)
[!] Executable uses SEH Tables (/SAFESEH) (3486 calculated 3486 recorded... 0
invalid addresses) 
[File Heuristics] -> Flag #1 : 00000100000001001100000100000100 (0x0404C104)
[Entrypoint Section Entropy] : 6.47 (section #0) ".text   " | Size : 0x3C7475
(3961973) byte(s)
[DllCharacteristics] -> Flag : (0x8100) -> DEP | TSA
[SectionCount] 5 (0x5) | ImageSize 0x718000 (7438336) byte(s)
[Export] 100% of function(s) (426 of 426) are in file | 0 are forwarded | 425
code | 1 data | 0 uninit data | 0 unknown | 
[VersionInfo] Company Name : Wargaming.net
[VersionInfo] Product Name : World of Warships
[VersionInfo] Product Version : 0.3.18.0
[VersionInfo] File Description : World of Warships Launcher
[VersionInfo] File Version : 0.3.18.153
[VersionInfo] Version Comments : Built: 20151110 115033. Revision: #621518
(stable_3.18)
[VersionInfo] Legal Copyrights : Copyright © 2012-2015
[Debug Info] (record 1 of 1) (file offset 0x3D2180)
Characteristics : 0x0 | TimeDateStamp : 0x5641DAC7 (Tue 10th Nov 2015 11:53:43
(GMT)) | MajorVer : 0 / MinorVer : 0 -> (0.0)
Type : 2 (0x2) -> CodeView | Size : 0x58 (88) 
AddressOfRawData : 0x421380 | PointerToRawData : 0x41FD80
CvSig : 0x53445352 | SigGuid A5760A9E-1312-448E-8F1ACB328236B3D0
Age : 0x1 | Pdb :
e:\work\launcher_anybranch\WGLauncher\bin\WoWs\WoWsLauncher.pdb
...
[CompilerDetect] -> Visual C++ 9.0 (Visual Studio 2008)
[!] File appears to have no protection or is using an unknown protection
- Scan Took : 2.234 Second(s) [000000ACEh (2766) tick(s)] [499 of 573 scan(s)
done]

Scanning ->
Z:\home\focht\wine-games\wineprefix64-wargaming\drive_c\Games\World_of_Warships\WorldOfWarships.exe
File Type : 32-Bit Exe (Subsystem : Win GUI / 2), Size : 24241392 (0171E4F0h)
Byte(s)
Compilation TimeStamp : 0x56388919 -> Tue 03rd Nov 2015 10:14:49 (GMT)
[TimeStamp] 0x56388919 -> Tue 03rd Nov 2015 10:14:49 (GMT) | PE Header | - |
Offset: 0x00000180 | VA: 0x00400180 | -
[TimeStamp] 0x56388919 -> Tue 03rd Nov 2015 10:14:49 (GMT) | Export | - |
Offset: 0x0149FBB4 | VA: 0x018A0DB4 | -
[TimeStamp] 0x56388919 -> Tue 03rd Nov 2015 10:14:49 (GMT) | DebugDirectory | -
| Offset: 0x0119C8D4 | VA: 0x0159DAD4 | -
[TimeStamp] 0x56388919 -> Tue 03rd Nov 2015 10:14:49 (GMT) | DebugDirectory | -
| Offset: 0x0119C8F0 | VA: 0x0159DAF0 | -
-> File Appears to be Digitally Signed @ Offset 0171D800h, size : 0CF0h / 03312
byte(s)
[!] Executable uses SEH Tables (/SAFESEH) (11954 calculated 11954 recorded... 0
invalid addresses) 
[File Heuristics] -> Flag #1 : 00000100000001001101000100000100 (0x0404D104)
[Entrypoint Section Entropy] : 6.40 (section #0) ".text   " | Size : 0x11978EB
(18446571) byte(s)
[DllCharacteristics] -> Flag : (0x8140) -> ASLR | DEP | TSA
[SectionCount] 6 (0x6) | ImageSize 0x220F000 (35713024) byte(s)
[Export] 99% of function(s) (1458 of 1464) are in file | 0 are forwarded | 1288
code | 176 data | 0 uninit data | 0 unknown | 
[VersionInfo] Company Name : Wargaming St.Petersburg
[VersionInfo] Product Name : World of WarShips
[VersionInfo] Product Version : 0. 5. 1. 128424
[VersionInfo] File Description : World of WarShips
[VersionInfo] File Version : 0. 5. 1. 0
[VersionInfo] Original FileName : WorldOfWarShips.exe
[Debug Info] (record 1 of 2) (file offset 0x119C8D0)
Characteristics : 0x0 | TimeDateStamp : 0x56388919 (Tue 03rd Nov 2015 10:14:49
(GMT)) | MajorVer : 0 / MinorVer : 0 -> (0.0)
Type : 2 (0x2) -> CodeView | Size : 0x63 (99) 
AddressOfRawData : 0x13B9DE8 | PointerToRawData : 0x13B8BE8
CvSig : 0x53445352 | SigGuid 0AAD9377-BDA0-4EE9-B48632EB96B2D7D6
Age : 0x1 | Pdb :
G:\BuildAgent\checkoutdir\client\game\bin\client\win32\WorldOfWarships.pdb
[Debug Info] (record 2 of 2) (file offset 0x119C8EC)
Characteristics : 0x0 | TimeDateStamp : 0x56388919 (Tue 03rd Nov 2015 10:14:49
(GMT)) | MajorVer : 0 / MinorVer : 0 -> (0.0)
Type : 12 (0xC) -> Undocumented | Size : 0x10 (16) 
AddressOfRawData : 0x13B9E4C | PointerToRawData : 0x13B8C4C
...
[CompilerDetect] -> Visual C++ 11.0 (Visual Studio 2011)
[!] File appears to have no protection or is using an unknown protection
- Scan Took : 7.236 Second(s) [000001E54h (7764) tick(s)] [499 of 573 scan(s)
done]
--- snip ---

$ wine --version
wine-1.7.54-332-g370254c

Regards

[Bug 38980] World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

SN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from SN  ---
Hello,

I found a workaround to this bug. Go to updates.worldofwarships.com/rss. The
links all end in .patch.torrent. If you delete the .torrent part, and paste the
rest of the link in a browser you can download the patch. Place it in the
/Updates folder and it should work.

SN

[Bug 38980] World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

--- Comment #3 from Anastasius Focht  ---
Hello SN,

although a pure file-based download through browser works too, in case you
overlooked the comment history there is also another workaround, that is
rate-limiting the bandwidth for torrent-based downloads.

Recent WoWS 0.5.2 updates consisted of torrents with >1.5 GB of data and I
didn't encounter any crash during auto-update with the bandwidth throttled in
the client settings to 85-90% (in my case rate-limiting was set to 5 MB/s)

Regards

[Bug 38980] World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Wilf M  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Wilf M  ---
It does seem to be working better now, thanks :)

But with WoT 9.14 with torrents enabled it did stop with 'Unhandled Exception'
errors a lot, which stopped it downloading until 'OK' was pressed (and then it
could continue)

I did manage to download the client OK, but when it was downloading game
components it 'Unhandled Exception'd so much I disabled torrents (By changing
the `launcher_transport` transport key in
"C:\Games\World_of_Tanks\WoTLauncher.cfg" from `3` to `2`) and restarted the
download.

BTW with both downloads it maxed out at around 970kb/s, which may be the max
speed of the connection. Sorry I didn't record any log data.

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail] ---
Still happening staging 1.9.12

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

--- Comment #6 from Bruno Jesus  ---
Still in Wine 2.2.

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |42520

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
(In reply to Bruno Jesus from comment #6)
> Still in Wine 2.2.

Still valid wine-staging 2.6. Currently downlading with speed limit workaround
in use.

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Stefan Dösinger  ---
The downloader uses libtorrent. I can reproduce spurious crashes with my own
libtorrent debug build using their client_test.exe example. So much easier to
debug than banging the head against boost in binary form :-) . I don't know if
it is exactly the same crash because I am dying on an assert that is presumably
compiled out in a production build, but the backtrace looks very similar to
what Anastasius Focht found and without the assert I'd expect the code in
question to die a few lines later.

The reason for the crash is that peer_connection::on_receive_data in
libtorrent/src/peer_connection.cpp is called with an invalid (=NULL) this
pointer. The call comes from boost.

The Wine log (+my stderr debug messages in libtorrent) show this:

003e:trace:winsock:WS2_recv_base socket 00f8, wsabuf 0xf3f054, nbufs 1, flags
0, from 0x0, fromlen -1, ovl 0x5d6d318, func 0x0
003e:trace:winsock:WS2_recv_base fd=72, options=0
003e:warn:winsock:wsaErrno errno 54, (Connection reset by peer).
003e:warn:winsock:WS2_recv_base  -> ERROR 10054
003e:trace:sync:PostQueuedCompletionStatus 0x2c 0 00000002 0x5d6d318
<snip>
003e:trace:sync:GetQueuedCompletionStatus Success, key=0, overlapped=0x5d6d318
003e:trace:sync:GetQueuedCompletionStatus setting error 3221225997
on_receive_data, this=05D6D0F0
survived assert, this=05D6D0F0
003e:trace:winsock:WS_closesocket (socket 00f8) -> 0
003e:trace:sync:GetQueuedCompletionStatus (0x2c,0xf3f564,0xf3f55c,0xf3f560,-1)
003e:trace:sync:GetQueuedCompletionStatus Success, key=2, overlapped=0x5d6d318
on_receive_data, this=00000000

This is the only occurence of the pointer 0x5d6d318 in the entire log. It seems
that WS2_recv returns an error, causing boost to call
PostQueuedCompletionStatus with dwCompletionKey=2
(win_iocp_socket_service.ipp). Yet apparently something (hint: our WS2_recv)
enqueues an IO completion status with dwCompletionKey=0 and the same overlapped
pointer. If I understand the documentation right it is not supposed to enqueue
anything if it returns an error. Then boost dequeues a result from the same
operation twice. The first operation "works", although probably passes junk
data to libtorrent. Then it discards private data stored in 0x5d6d318. When the
same operation returns a result again (the right one, with completion key 2)
the callback goes wrong.

I don't have a fix yet and the theory could be completely wrong. I'll continue
on this bug later.

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Gijs Vermeulen  ---
Should be fixed by:
https://source.winehq.org/git/wine.git/commit/7a1142035d7ee04839417176ff93fd...

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

--- Comment #10 from [e-mail] ---
(In reply to winetest from comment #7)
> (In reply to Bruno Jesus from comment #6)
> > Still in Wine 2.2.
>
> Still valid wine-staging 2.6. Currently downlading with speed limit
> workaround in use.

I am convinced that this bug is fixed. I tested this not long ago and I got
constant crashes I think I even got one with the workaround on. So far I have
downloaded almost 650 Mb without any issues and the speed has been good also. I
couldnt test last time this with pure wine because I lacked some
libxml-development files. But I searched them, reconfigured wine and compiled
and the launcher started which I wasnt able to start with pure wine last time,
but it worked with staging. I tested World of Tanks launcher.

wine-2.8-47-g66c7b37

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
          Component|-unknown                    |winsock
      Fixed by SHA1|                            |7a1142035d7ee04839417176ff9
                   |                            |3fd0953e2a4e1

--- Comment #11 from Bruno Jesus  ---
(In reply to Gijs Vermeulen from comment #9)
> Should be fixed by:
> https://source.winehq.org/git/wine.git/commit/
> 7a1142035d7ee04839417176ff93fd0953e2a4e1

(In reply to winetest from comment #10)
> I am convinced that this bug is fixed....

I can confirm this is fixed too, downloaded the game yesterday 4gb + 11gb.
Before the patch crashes are very easy to reproduce in a few minutes of test.
Thanks to AF for the bug and Stefan for the fix.

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  ---
Closing bugs fixed in 2.9.

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 38980] World of Warships/Planes/ Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

https://bugs.winehq.org/show_bug.cgi?id=38980

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #13 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.3.

[Bug 38980] World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38980

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://worldofwarships.eu/e |https://web.archive.org/web
                   |n/game/download/            |/20201112043601/http://dl-w
                   |                            |ows-gc.wargaming.net/eu/fil
                   |                            |es/ilcClx1YzB/WoWS_internet
                   |                            |_install_eu.exe