[Bug 26051] New: wintrust/softpub tests show a few leaks under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26051

Summary: wintrust/softpub tests show a few leaks under valgrind
           Product: Wine
           Version: 1.3.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: wintrust
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33223)
 --> (http://bugs.winehq.org/attachment.cgi?id=33223)
valgrind log

Most look like:
 28 bytes in 1 blocks are definitely lost 
    at  notify_alloc (heap.c:254)
    by  RtlAllocateHeap (heap.c:1701)
    by  WINTRUST_Alloc (wintrust_main.c:47)
    by  SOFTPUB_GetSIP (softpub.c:135)
    by  SOFTPUB_LoadFileMessage (softpub.c:350)
    by  SoftpubLoadMessage (softpub.c:428)
    by  testObjTrust (softpub.c:341)
    by  test_provider_funcs (softpub.c:503)
    by  func_softpub (softpub.c:808)
    by  run_test (test.h:556)
    by  main (test.h:624)

[Bug 26051] wintrust/softpub tests show a few leaks under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26051

--- Comment #1 from Juan Lang  2011-02-10 09:44:24 CST ---
Yes, they do, and they're somewhat unavoidable.  The function pointers being
tested implicitly allocate memory, but there's no explicit interface for
freeing the memory they allocate.

Ordinarily, callers are expected to call WinVerifyTrust twice, once to verify
an object and a second time to release all memory allocated in the process. 
These function pointers are used by WinVerifyTrust to do their job.  The
function pointers should be tested independently of WinVerifyTrust, but since
there's no interface for freeing the memory they allocate, it's hard to do so
in the context of the test.

I could make assumptions about how the memory should be freed, but I suspect
it's better just to suppress most of the errors, since any application that
called the functions directly would also encounter leaks.  I'll send in a fix
for one leak that isn't of this sort.

[Bug 26051] wintrust/softpub tests show a few leaks under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26051

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Austin English  2011-02-10 12:33:02 CST ---
Thanks.

http://source.winehq.org/git/wine.git/?a=commitdiff;h=4325d75d5db32f01f1ca5a...

fixes that leak, I'll suppress the rest.

[Bug 26051] wintrust/softpub tests show a few leaks under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26051

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2011-02-18 12:37:02 CST ---
Closing bugs fixed in 1.3.14.