http://bugs.winehq.org/show_bug.cgi?id=27189
Summary: Hydrophobia Prophecy wants GetLogicalProcessorInformation implemented Product: Wine Version: 1.3.20 Platform: x86 OS/Version: Linux Status: NEW Severity: minor Priority: P2 Component: kernel32 AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Running the game gives me a warning:
WARNING: Your PC is below the minimum spec. Processor cores: 1; Minium spec for Hydrophobia: 2 Cores.
I see: fixme:process:GetLogicalProcessorInformation ((nil),0x33fdb4): stub fixme:process:GetLogicalProcessorInformation (0x286ff88,0x33fdb4): stub fixme:process:GetLogicalProcessorInformation ((nil),0x33fad4): stub fixme:process:GetLogicalProcessorInformation (0x2763838,0x33fad4): stub
in the terminal.
Really though, I'm sure I have more than one core: austin@aw25 ~ $ cat /proc/cpuinfo | grep -c processor 8
:)
http://bugs.winehq.org/show_bug.cgi?id=27189
Claudio sick_soul@yahoo.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sick_soul@yahoo.it
--- Comment #1 from Claudio sick_soul@yahoo.it 2011-11-19 13:21:46 CST --- the API is now documented
http://msdn.microsoft.com/en-us/library/windows/desktop/ms683194%28v=vs.85%2...
I have made a glpi and glpiex stupid implementation, with values just hard-coded in.
I am also working on a linux-only "real" implementation based on sysfs. That is, #ifdef linux, the actual values are read from sysfs, on other boxes the values are just hard-coded [waiting for OS-specific implementations for the other cases].
Interested on any of this material?
http://bugs.winehq.org/show_bug.cgi?id=27189
--- Comment #2 from Austin English austinenglish@gmail.com 2011-11-21 17:10:18 CST --- (In reply to comment #1)
the API is now documented
http://msdn.microsoft.com/en-us/library/windows/desktop/ms683194%28v=vs.85%2...
I have made a glpi and glpiex stupid implementation, with values just hard-coded in.
I am also working on a linux-only "real" implementation based on sysfs. That is, #ifdef linux, the actual values are read from sysfs, on other boxes the values are just hard-coded [waiting for OS-specific implementations for the other cases].
Interested on any of this material?
Sure :)
http://bugs.winehq.org/show_bug.cgi?id=27189
--- Comment #3 from Claudio sick_soul@yahoo.it 2011-11-22 17:38:55 CST --- Created attachment 37587 --> http://bugs.winehq.org/attachment.cgi?id=37587 kernel32: implement GetLogicalProcessorInformation
This is the patch for glpi, works for me. I added a test, removed the glpi-ex function implementation, that should be separate I think. I do not have any windows system, so tested only on my linux/x86 machines. local commit comment follows.
kernel32: implement GetLogicalProcessorInformation
First implementation of GetLogicalProcessorInformation. Limitations: all logical processors are added to the same NUMA set, and all cores are added to the same package. Only the linux-specific helper function is implemented, so for now everybody else gets the fallback hard-coded results only. The fallback is also triggered when the OS-specific APIs fail.
The linux-specific function is based on sysfs.
The new OS-specific functions can be easily added as additional ifdefs by following the linux example.
http://bugs.winehq.org/show_bug.cgi?id=27189
Claudio sick_soul@yahoo.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #37587|0 |1 is obsolete| |
--- Comment #4 from Claudio sick_soul@yahoo.it 2011-11-23 02:45:33 CST --- Created attachment 37589 --> http://bugs.winehq.org/attachment.cgi?id=37589 kernel32: implement GetLogicalProcessorInformation
removed redundant function names from TRACE logs and protect memcpy(NULL, something, 0) with an if, to be sure.
http://bugs.winehq.org/show_bug.cgi?id=27189
Dylan darkmirror96@live.com.sg changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |darkmirror96@live.com.sg
--- Comment #5 from Dylan darkmirror96@live.com.sg 2012-05-03 04:03:53 CDT --- Claudio, I appreciate your efforts in composing a patch for this problem but could you, by any chance, create one for the Mac OSX together with the Linux patch? Thanks.
http://bugs.winehq.org/show_bug.cgi?id=27189
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=27189
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=27189
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c6ac0d0fcc57b4b955289826e2e | |ffb759f74e673 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #6 from Austin English austinenglish@gmail.com 2012-09-04 13:21:39 CDT --- http://source.winehq.org/git/wine.git/commitdiff/c6ac0d0fcc57b4b955289826e2e...
http://bugs.winehq.org/show_bug.cgi?id=27189
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2012-09-14 13:36:53 CDT --- Closing bugs fixed in 1.5.13.