[Bug 25738] New: cmd.exe: enclosing quoting of builtin command and parameters confuses cmd.exe (Windows PowerShell 2.0 installer)
http://bugs.winehq.org/show_bug.cgi?id=25738
Summary: cmd.exe: enclosing quoting of builtin command and parameters confuses cmd.exe (Windows PowerShell 2.0 installer) Product: Wine Version: 1.3.11 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: cmd AssignedTo: wine-bugs@winehq.org ReportedBy: focht@gmx.net
Hello,
while installing Windows PowerShell 2.0 I noticed a flood of following console messages during install:
--- snip --- wine: cannot find L"C:\windows\system32\del.exe" File not found --- snip ---
The update.inf file being processed contains the following actions:
--- snip --- ; After File Copy [ProcessesToRun] ... """%windir%\system32\cmd.exe""" /c """del /F /Q """%windir%\system32\WindowsPowerShell\v1.0\System.Management.Automation.dll"""""" """%windir%\system32\cmd.exe""" /c """del /F /Q """%windir%\system32\WindowsPowerShell\v1.0%ReleaseNotesDir%\System.Management.Automation.resources.dll"""""" """%windir%\system32\cmd.exe""" /c """del /F /Q """%windir%\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll"""""" ... --- snip ---
That section was probably automatically created hence the ridiculous quoting - it is nevertheless valid.
The relevant trace log (+cmd):
--- snip --- 0023:trace:process:CreateProcessW app (null) cmdline L""C:\windows\system32\cmd.exe" /c "del /F /Q "C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll""" ... 0036:trace:cmd:wmain Command line parm: 'L"C:\windows\system32\cmd.exe"' 0036:trace:cmd:wmain Command line parm: 'L"/c"' 0036:trace:cmd:wmain /c command line: 'L""del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll""' 0036:trace:cmd:WCMD_DumpCommands Parsed line: 0036:trace:cmd:WCMD_DumpCommands 0x1271e0 0 00 (nil) L""del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll"" Redir:L"" 0036:trace:cmd:WCMD_process_commands Executing command: 'L""del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll""' 0036:trace:cmd:WCMD_execute command on entry:L""del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll"" (0x33f4f8), with '(null)'='(null)' 0036:trace:cmd:WCMD_execute Command: 'L""del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll""' 0036:trace:cmd:WCMD_execute param1: L"del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll", param2: L"" 0036:trace:cmd:WCMD_run_program Searching in 'L"C:\windows\del \F \Q C:\windows\system32\WindowsPowerShell\v1.0\"' for 'L"Microsoft.PowerShell.ConsoleHost.dll"' 0036:trace:cmd:WCMD_run_program ASSUMING INTERNAL 0036:trace:process:CreateProcessW app (null) cmdline L""del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll"" 0036:trace:process:find_exe_file looking for L"del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll" 0036:trace:cmd:WCMD_run_program Searching in 'L".;C:\windows\system32;C:\windows;C:\windows\system32\wbem"' for 'L"del"' 0036:trace:cmd:WCMD_run_program Found as L"C:\windows\del.*" 0036:trace:cmd:WCMD_run_program Found as L"C:\windows\system32\del.*" 0036:trace:cmd:WCMD_run_program Found as L"C:\windows\del.*" 0036:trace:cmd:WCMD_run_program ASSUMING INTERNAL 0036:trace:process:CreateProcessW app (null) cmdline L"del /F /Q C:\windows\system32\WindowsPowerShell\v1.0\Microsoft.PowerShell.ConsoleHost.dll" ... 0036:trace:process:CreateProcessW starting L"C:\windows\system32\del.exe" as 32-bit Winelib app ... wine: cannot find L"C:\windows\system32\del.exe" File not found --- snip ---
The enclosing quoting of builtin command line and parameters confuses cmd.exe. This works:
--- snip --- $ wine cmd.exe /c del /F /Q "foo.txt" --- snip ---
This does not (but should):
--- snip --- $ wine cmd.exe /c "del /F /Q "foo.txt"" --- snip ---
Regards
http://bugs.winehq.org/show_bug.cgi?id=25738
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer URL| |http://www.microsoft.com/do | |wnloads/details.aspx?Family | |Id=60cb5b6c-6532-45e0-ab0f- | |a94ae9ababf5
http://bugs.winehq.org/show_bug.cgi?id=25738
--- Comment #1 from Dan Kegel dank@kegel.com 2011-01-10 10:36:01 CST --- Created an attachment (id=32796) --> (http://bugs.winehq.org/attachment.cgi?id=32796) patch to remove surrounding quotes if entire command is quoted
Here's an ugly patch that recognizes the case of an entire commandline surrounded by quotes, and removes the outer layer of quotes. It fixes the reduced testcase you gave, though probably only because the reduced testcase doesn't quite mimic the real problem.
http://bugs.winehq.org/show_bug.cgi?id=25738
--- Comment #2 from Xavier Vachon xvachon@gmail.com 2011-04-14 19:22:53 CDT --- Created an attachment (id=34119) --> (http://bugs.winehq.org/attachment.cgi?id=34119) backtrace
Not sure if this is exactly the same issue, but I get this when I try to run a patch bundle for Dragon Age 2. It works flawlessly in Windows 7.
wine: cannot find L"C:\windows\system32\copy.exe" File not found
wine: cannot find L"C:\windows\system32\del.exe" File not found
After applying your hack, the console complains only about copy.exe not being found.
Adding the backtrace, hopefully it's useful.
http://bugs.winehq.org/show_bug.cgi?id=25738
--- Comment #3 from Anastasius Focht focht@gmx.net 2012-05-09 16:50:14 CDT --- Hello,
still present.
$ wine --version wine-1.5.3-243-g9c0486d
Regards
http://bugs.winehq.org/show_bug.cgi?id=25738
Jason Edmeades us@edmeades.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |us@edmeades.me.uk
--- Comment #4 from Jason Edmeades us@edmeades.me.uk 2012-10-02 17:48:08 CDT --- Anastasius - Are you able to retest this as of last nights commits please (specifcally 88f14bb59045e1d8c8bb0a71abb50f505620c420). It certainly should (and appears to) resolve the reported issues, for the 'del' problems, but it still logs some error messages - Analysis of those seem to be that the copy /y are trying to copy as
cmd /c command line: 'L"copy /y C:\windows\assembly\GAC_MSIL\Microsoft.PowerShell.Commands.Utility\1.0.0.0__31bf3856ad364e35\Microsoft.PowerShell.Commands.Utility.dll C:\windows\system32\WindowsPowerShell\v1.0"'
When this is actually executed, C:\windows\assembly\GAC_MSIL\Microsoft.PowerShell.Commands.Utility doesnt exist, which I think is not related to this bug, and is outside cmd as well.
(Xavier - the same commit should help you - please raise a new bug if the issues persist / for the copy issue)
Thanks!
http://bugs.winehq.org/show_bug.cgi?id=25738
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |frederic.delanoy@gmail.com Resolution| |FIXED
--- Comment #5 from Frédéric Delanoy frederic.delanoy@gmail.com 2012-11-25 15:00:44 CST --- Likely fixed by Jason's patches. I got no error message for the "del.exe" not being found. Anastasius, please reopen if this still happens for you.
http://bugs.winehq.org/show_bug.cgi?id=25738
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2012-12-07 13:36:29 CST --- Closing bugs fixed in 1.5.19.
http://bugs.winehq.org/show_bug.cgi?id=25738
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |88f14bb59045e1d8c8bb0a71abb | |50f505620c420
https://bugs.winehq.org/show_bug.cgi?id=25738
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.microsoft.com/do |https://web.archive.org/web |wnloads/details.aspx?Family |/20120604201356/http://down |Id=60cb5b6c-6532-45e0-ab0f- |load.microsoft.com/download |a94ae9ababf5 |/E/C/E/ECE99583-2003-455D-B | |681-68DB610B44A4/WindowsXP- | |KB968930-x86-ENG.exe
-
wine-bugs＠winehq.org -
WineHQ Bugzilla