[Bug 48920] New: Can't quit Legends of Runeterra by closing virtual desktop window (stack overflow) (5.6 regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48920

Bug ID: 48920
           Summary: Can't quit Legends of Runeterra by closing virtual
                    desktop window (stack overflow) (5.6 regression)
           Product: Wine
           Version: 5.6
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

In wine-staging-5.5, when running Legends of Runeterra in a virtual desktop,
you could close the game by clicking the X button on the virtual desktop's
window. The game would close, and then shortly afterwards the virtual desktop
would close.

In wine-staging-5.6, when you click the X button on the virtual desktop, the
game does not close, the virtual desktop does not close, and the following line
is printed in terminal output:

0052:err:seh:setup_exception stack overflow 1600 bytes in thread 0052 eip
000000007bce1e27 esp 0000000000120fd0 stack 0x120000-0x121000-0x220000

(The thread number changes, but all other values seem to be consistent between
attempts.)

Quitting the game using the in-game menu works fine.

Gentoo, x86_64

I'll work on getting a regression range

[Bug 48920] Can't quit Legends of Runeterra by closing virtual desktop window (stack overflow) (5.6 regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48920

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 48920] Can't quit Legends of Runeterra by closing virtual desktop window (stack overflow) (5.6 regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48920

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |036f4dca3c7f9ee8964bb4ae0c4
                   |                            |bcd106a347c7b
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
With e9d2b31c87, I can quit by clicking the X, with 036f4dca3c7 I can't, so the
first bad commit is

commit 036f4dca3c7f9ee8964bb4ae0c4bcd106a347c7b
Author: Alexandre Julliard 
Date:   Wed Apr 8 15:09:00 2020 +0200

winecrt0: Rebuild the argv array instead of getting it from libwine.

(this is paired with wine-staging bf3fbb7bdf)

[Bug 48920] Can't quit Legends of Runeterra by closing virtual desktop window (stack overflow) (5.6 regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48920

--- Comment #2 from [e-mail] ---
I forgot to mention, running the game at all requires the patch from Bug 48665
comment 2.

Also I just noticed that the thread ID that has the stack overflow increases by
2 every time the virtual desktop's X button is clicked.

[Bug 48920] Can't quit Legends of Runeterra by closing virtual desktop window (stack overflow) (5.6 regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48920

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from [e-mail] ---
Fixed sometime between wine 5.6 and 5.7. I didn't bother fully tracking down
the commit that fixed it, but it may have been related to bug 48956.

[Bug 48920] Can't quit Legends of Runeterra by closing virtual desktop window (stack overflow) (5.6 regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48920

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 5.8.