[Bug 17753] New: Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Summary: Cannot compile Wine 1.1.17 from source on Mac OS X
           Product: Wine
           Version: 1.1.17
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Attempting to compile Wine 1.1.17 from source on an Intel Mac running 10.5.6
results in a premature exit.  Using the same "configure" options I've used in
past versions (1.0.1, 1.1.15 and 1.1.16 recently), the build exists out when
building DLLs - I first see the error in dlls/acledit, and the error message is
"'stdcall' not supported for Win16" reported at acledit.spec lines 4 and 5. 
Win16 has been explicitly disabled via the "--disable-win16" configure option.

I recompiled 1.1.16 and 1.1.15 both from source using the same configure
options, and they completed successfully, so this seems like a new issue in
1.1.17.  Currently looking through the 1.1.16 to 1.1.17 diff to see what's
changed, but I'll attach the captured output of "configure && make depend &&
make" and the generated config.log and config.status files when the bug is
filed.

Couldn't find if this had been reported previously, and I'm not using MacPorts
or Fink - just compiling straight from tar.bz2 file.  Thanks!

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #1 from ryan woodsmall   2009-03-15 17:04:36 ---
Created an attachment (id=19973)
 --> (http://bugs.winehq.org/attachment.cgi?id=19973)
output of 'configure,' 'make depend' and 'make'

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #2 from ryan woodsmall   2009-03-15 17:05:29 ---
Created an attachment (id=19974)
 --> (http://bugs.winehq.org/attachment.cgi?id=19974)
config.status after running 'configure'

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #3 from ryan woodsmall   2009-03-15 17:10:22 ---
Created an attachment (id=19975)
 --> (http://bugs.winehq.org/attachment.cgi?id=19975)
config.log after configure

gzip'ped since it's >1MB uncompressed

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #4 from Vitaliy Margolen   2009-03-15 17:21:15 ---
Does it compile if you don't specify "--disable-win16"?

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #5 from ryan woodsmall   2009-03-15 17:42:02 ---
Compiling without --disable-win16 or explicitly setting --enable-win16 results
in the same error at the same point in compilation.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker

--- Comment #6 from Vitaliy Margolen   2009-03-15 17:58:21 ---
Please do a regression testing. But I think it's one of AJ's win16 patches in
the last 2-3 days.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #7 from ryan woodsmall   2009-03-15 23:16:50 ---
Created an attachment (id=19979)
 --> (http://bugs.winehq.org/attachment.cgi?id=19979)
"git bisect" output from regression testing build diffs between 1.1.16/1.1.17

Regression builds completed - looks like it was one of the win16 patches from
Alexandre.  Will keep digging as I have time, since I know he's currently on
vacation.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #8 from ryan woodsmall   2009-03-16 00:56:07 ---
Looks like winegcc is passing the "--main-module" option to winebuild by
default.  From the generated tools/winegcc/wine/Makefile:

.spec.spec.o:
        $(WINEBUILD) $(WINEBUILDFLAGS) --dll -o $@ --main-module $(MODULE)
--export $<

The tools/winebuild/main.c now sets spec->main_module when called with
-M/--main-module.  The case statement for this option is around ~362, and
simply does the following:

spec->main_module = xstrdup( optarg );

A check later in the file for spec->main_module looks to always be getting hit,
then an attempt to build the 16-bit spec errors out with the 'stdcall' warnings
I'm seeing.  Around line 586 of tools/winebuild/main.c:

if (spec->type == SPEC_WIN32 && spec->main_module)  /* embedded 16-bit module
*/
{
    spec->type = SPEC_WIN16;
    load_resources( argv, spec );
    if (parse_input_file( spec )) BuildSpec16File( spec );
    break;
}

If the above "if(){}" block is commented out and Wine rebuilt, it compiles,
installs and runs on my Mac successfully.  A couple of test programs (Windows
Firefox 2, Gothic DirectX game) work successfully under 1.1.17.  Is there a
quick check that can be done to determine if win16 compatibility has been
requested, and the code above wrapped in it?  Or is that a bad idea?  I'm
unsure of the implications of making that change, so I'll defer to those who
know way more about this than I for the time being.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

--- Comment #9 from ryan woodsmall   2009-03-28 18:49:05 ---
This is fixed in 1.1.18.  Compiling with "--enable-win16" works as expected on
my Mac.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Austin English   2009-03-28 18:55:51 ---
Fixed then.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard   2009-04-10 11:24:03 ---
Closing bugs fixed in 1.1.19.

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Macintosh                   |x86

[Bug 17753] Cannot compile Wine 1.1.17 from source on Mac OS X

http://bugs.winehq.org/show_bug.cgi?id=17753

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|Mac OS X 10.5               |Mac OS X