[Bug 21174] New: cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Summary: cmd does not support /a arithmetic expression
                    evaluation
           Product: Wine
           Version: 1.1.35
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

http://source.winehq.org/git/wine.git/?a=blob;f=programs/cmd/builtins.c;#l20...
shows that set currently does't implement the /a switch.
Quite a few batch files depend on it.

Here are a few pages with info about it:
http://blogs.msdn.com/oldnewthing/archive/2006/05/04/589884.aspx
http://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-...
http://stackoverflow.com/questions/980718/cmd-for-loop-does-not-hold-set-a-v...

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #1 from Dan Kegel   2010-01-01 13:15:48 ---
See also 
http://ss64.com/nt/set.html

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|programs                    |cmd

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jason Edmeades   2010-01-06 18:26:42 ---
Adding myself to the cmd bugs

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #3 from Dan Kegel   2010-01-22 12:25:34 ---
And woot!  Looks like gyp uses this:
http://gyp.googlecode.com/svn/trunk/pylib/gyp/generator/msvs.py
And the chromium build on wine fails without it:

To reproduce: use

http://code.google.com/p/winezeug/source/browse/trunk/testsuites/chromium/bu...
and do
 sh build.sh build webcore_bindings_sources
...
Running
"c:\chromium\src\third_party\WebKit\WebCore\WebCore.gyp........\third_party\cygwin\setup_env.bat"
&& set CYGWIN=nontsec&& set /a
NUMBER_OF_PROCESSORS_PLUS_1=%NUMBER_OF_PROCESSORS%+1&& ... && bash -c ""make"
"OutDir=`cygpath -m "${OUTDIR}"`" "IntDir=`cygpath -m "${INTDIR}"`"
"-j" "${NUMBER_OF_PROCESSORS_PLUS_1}" "-f"
"webcore_bindings_sources_rules.mk""
make: the `-j' option requires a positive integral argument

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #4 from Dan Kegel   2010-01-23 09:07:21 ---
(Incidentally, webcore_bindings_sources_rules.mk terminates early
when run with -j2.  Each time you run it, it generates a few more
output files.  Running with -j1 or without -j works around that.
But that's a different bug.)

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #5 from Dan Kegel  2011-03-13 08:38:20 CDT ---
A UCLA student had a shot at implementing this last year, see
http://www.winehq.org/pipermail/wine-patches/2010-March/085922.html
I'll attach it here just in case.

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #6 from Dan Kegel  2011-03-13 08:40:25 CDT ---
Created an attachment (id=33622)
 --> (http://bugs.winehq.org/attachment.cgi?id=33622)
Jack Kutilek's patch from March 16, 2010

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Frédéric Delanoy  2011-08-29 14:16:20 CDT ---
Tests added:
http://source.winehq.org/git/wine.git/commitdiff/28fe027eee5d093aa3fd9983916...

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #8 from Frédéric Delanoy  2011-10-16 03:58:08 CDT ---
Created attachment 36928
  --> http://bugs.winehq.org/attachment.cgi?id=36928
Rebased Jack Kutilek's patch (wine-1.3.30-154-g450111d)

Code unchanged save for the po file changes, and some trailing whitespace
removal.
Tests not included from original patch

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

--- Comment #9 from Frédéric Delanoy  2011-10-16 04:05:24 CDT ---
Does not recognize whitespace around operators, so test suite currently fails.
Also, upon cursory review, test cases in the original patch don't seem to use
propers '^' escaping.

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18346

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Bug 21174 depends on bug 18346, which changed state.

Bug 18346 Summary: cmd does not support the "^" escape character
http://bugs.winehq.org/show_bug.cgi?id=18346

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36928|0                           |1
        is obsolete|                            |

--- Comment #10 from Frédéric Delanoy  2012-11-20 11:07:43 CST ---
Created attachment 42564
  --> http://bugs.winehq.org/attachment.cgi?id=42564
Rebased Jack Kutilek's patch (wine-1.5.17-191-g5a8c97a)

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #11 from Jason Edmeades  2012-12-13 16:06:25 CST ---
Started with Jack's patch but ended up reworking it, probably so I understood
it better but also to handle odd parsing conditions. Submitted patch today
http://www.winehq.org/pipermail/wine-patches/2012-December/120743.html
Will be down to 30 todos if this gets in!

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |95279b87e4060f9f20020b7c5a6
                   |                            |11c39e0ed4951
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Jason Edmeades  2012-12-21 14:51:07 CST ---
Committed :-)

[Bug 21174] cmd does not support /a arithmetic expression evaluation

http://bugs.winehq.org/show_bug.cgi?id=21174

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2013-01-04 15:00:45 CST ---
Closing bugs fixed in 1.5.21.