[Bug 11111] New: Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

Summary: Picasa slideshow does not have focus on Gnome
           Product: Wine
           Version: 0.9.52.
          Platform: PC
               URL: http://picasa.google.com/
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: minor
          Priority: P2
         Component: x11-driver
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I'm running Ubuntu Feisty with Gnome as the window manager and X in 16-bit
mode.

While using the slideshow feature in Picasa 2.7, I noticed the slideshow no
longer have keyboard focus. One should be able to use the left and right arrow
keys to move between images, and the escape key to quit out of the slideshow.
With the latest version, that no longer happens. One has to click the mouse to
to give the slideshow focus.

A regression test shows:

f48eb1581dfe176043cbca5c46400c0f86eb5552 is first bad commit
commit f48eb1581dfe176043cbca5c46400c0f86eb5552
Author: Alexandre Julliard 
Date:   Mon Aug 20 22:06:50 2007 +0200

winex11: Force a window to managed mode when it is activated.

This doesn't seem to occur on KDE.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

Michael Moss  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Michael Moss   2008-02-28 14:43:43 ---
I think this may be specific to metacity, not Gnome. I tried Ubuntu Gutsy
running compiz, and focus worked as expected. When I turned off visual effects
(i.e. switched from compiz to metacity), I saw the focus problem described.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Dan Kegel   2008-03-19 22:32:07 ---
Michael, is this still happening with current Wine?

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #3 from Michael Moss   2008-03-20 15:21:38 ---
Yes, I still see this when running Ubuntu+Metacity with Wine as of this
morning.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Dmitry Timoshkov   2008-04-02 04:46:44 ---
It's a similar problem to the one reported in the bug 11026. Picasa creates
a window for slide show with styles WS_POPUP/WS_EX_TOOLWINDOW. Wine makes
the window managed and assignes _NET_WM_WINDOW_TYPE_UTILITY type to it.
However Metacity doesn't set input focus to windows with utility type.

As a workaround you need to click with a mouse to make the window get
input focus.

Completely removing WS_EX_TOOLWINDOW handling from dlls/winex11.drv/window.c,
X11DRV_set_wm_hints() fixes this problem as well as the bug 11026.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #5 from Dmitry Timoshkov   2008-04-02 10:23:02 ---
I've filed a bug, let's see what metacity developers say:

http://bugzilla.gnome.org/show_bug.cgi?id=525774

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #6 from Dmitry Timoshkov   2008-04-06 22:42:06 ---
In that Gnome bug Elijah Newren suggests to make utility windows dialogs
as a workaround. I'll send a patch.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #7 from Dmitry Timoshkov   2008-04-06 23:38:54 ---
I sent a patch:

http://www.winehq.org/pipermail/wine-patches/2008-April/052861.html

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #8 from Dmitry Timoshkov   2008-04-07 00:26:20 ---
Actually that patch doesn't fix this bug, the window in question does have
WS_EX_TOOLWINDOW style set, but not the dialog styles.

The bug 11026 is fixed by it though.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #9 from Dmitry Timoshkov   2008-04-07 08:30:31 ---
Here is another attempt:

http://www.winehq.org/pipermail/wine-patches/2008-April/052881.html

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Dmitry Timoshkov   2008-04-07 21:24:04 ---
The patch has been committed.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

--- Comment #11 from Lei Zhang   2008-04-07 23:09:27 ---
Thanks. It's fixed for me.

[Bug 11111] Picasa slideshow does not have focus on Gnome

http://bugs.winehq.org/show_bug.cgi?id=11111

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2008-04-18 11:03:34 ---
Closing bugs reported fixed in 0.9.60.