[Bug 57587] New: 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

Bug ID: 57587
           Summary: 10.0-rc1 regression (dsoundrender): no audio or hangs
                    in some videos
           Product: Wine
           Version: 10.0-rc1
          Hardware: x86-64
               URL: https://github.com/castaneai/microkiri/releases/downlo
                    ad/v0.1.0/microkiri_v0.1.zip
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: quartz
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 971a05f10faa0765b44287d902e3cfcc4e0c815c
      Distribution: ---

An example application is provided in the URL field. sha1sum:
56e3a30c0f361b1dc34342c418854ef2864f0e21
It depends on LANG=ja_JP.UTF-8.

In this application, the WMV video plays without audio. It might play a few
samples incoherently for a split second, then there is no audio. (The MPEG-1
video has no audio track. Though I think this bug may not occur on mpeg
videos.)
If necessary I can find and link another example application where the thread
also hangs.

MR with regression: https://gitlab.winehq.org/wine/wine/-/merge_requests/6973

Reverting both e6b8e9ee209 ("quartz/dsoundrender: Use send_sample_data() to
fill the buffer with silence at EOS.") and 971a05f10fa ("quartz/dsoundrender:
Queue samples and render them on a separate thread.") avoids the bug. (Only
reverting e6b8e9ee209 does not help)

The issue doesn't occur with
https://gitlab.winehq.org/wine/wine/-/merge_requests/6849 applied on 9.21 (but
in some other applications the audio track starts too early and is
desynchronized from the video, which didn't occur in the (modified to fix other
issues) github/ValveSoftware/wine/bleeding-edge branch).

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

Attila Fidan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

--- Comment #1 from Attila Fidan  ---
> If necessary I can find and link another example application where the
> thread also hangs.

where the thread also hangs, and the video does not play and you are unable to
exit

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

--- Comment #2 from Attila Fidan  ---
> The issue doesn't occur with
> https://gitlab.winehq.org/wine/wine/-/merge_requests/6849 applied on 9.21
> (but in some other applications the audio track starts too early and is
> desynchronized from the video, which didn't occur in the (modified to fix
> other issues) github/ValveSoftware/wine/bleeding-edge branch).

Er, I mean the audio track is too far behind the video.

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Béla Gyebrószki  ---
Music doesn't play in Age of Empires III (2007) since commit 971a05f.

wine-10.0-rc3-6-ge713c3487f9

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

--- Comment #4 from Attila Fidan  ---
The MR https://gitlab.winehq.org/wine/wine/-/merge_requests/7085 fixes the
regression for KiriKiri. I assume the same for Age of Empires III (2007).

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

--- Comment #5 from Zeb Figura  ---
It fixes both according to my testing. Both applications seem to plug
dmowrapper into dsoundrender which is basically the cause of the bug.

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

Attila Fidan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |67cb65338559f7b8623207de734
                   |                            |a8390113f677b
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Attila Fidan  ---
> It fixes both according to my testing.

Thanks for checking AoE. So this can be marked as fixed.

Fixed by
https://gitlab.winehq.org/wine/wine/-/commit/67cb65338559f7b8623207de734a839...

[Bug 57587] 10.0-rc1 regression (dsoundrender): no audio or hangs in some videos

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57587

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 10.0-rc4.