[Bug 27192] New: Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Summary: Regedit - import failure if reg-file contains ';'
           Product: Wine
           Version: 1.3.20
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The Regedit.exe didn't import REG files correctly if the reg-files contains a
';' (semicolon) at the beginning of a line. It ignores the rest of the file.

Example:
--snipp--
[HKEY_CURRENT_USER\Software\Microsoft\Internet
Explorer\SearchScopes{CF821BCD-444B-4E01-8523-ECBEECBF10C0}]
"DisplayName"="Wikipedia (de)"
;;"FaviconPath"="C:\Documents and Settings\Joerg\Local Settings\Application
Data\Microsoft\Internet
Explorer\Services\search_{CF821BCD-444B-4E01-8523-ECBEECBF10C0}.ico"
"FaviconURL"="http://de.wikipedia.org/favicon.ico"
"OSDFileURL"="http://www.ieaddons.com/de/DownloadHandler.ashx?ResourceId=840"
"ShowSearchSuggestions"=dword:00000000
"SuggestionsURL"="http://de.wikipedia.org/w/api.php?action=opensearch&format=xml&searc..."
"SuggestionsURL_JSON"="http://de.wikipedia.org/w/api.php?action=opensearch&search=%7BsearchTerm..."
"URL"="http://de.wikipedia.org/w/index.php?title=Spezial:Suche&search=%7Bsearch..."
--snapp--

Only the first line behind the reg-key will be imported. The rest, e.g.
"FaviconURL" and so on, is ignored.

The ';' is the comment sign inside a (all) reg-files.

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

snejjj  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from snejjj  2011-05-17 05:21:34 CDT ---
I can confirm this.

using 1.3.19.

following .reg-file-example:

[path\to\key]
"field1"="value1"
;;comment
"field2"="value2"

produces the bug, where

[path\to\key]
"field1"="value1"
;;comment
"field1"="value2"

and

[path\to\key]
"field1"="value1"
;;comment
[path\to\key]
"field2"="value2"

do not produce the bug.

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

--- Comment #2 from Joerg Schiermeier  2011-05-17 06:24:11 CDT ---
(In reply to comment #2)

my example is a little bit weird:
> Example:
> --snipp--
> [HKEY_CURRENT_USER\Software\Microsoft\Internet
> Explorer\SearchScopes{CF821BCD-444B-4E01-8523-ECBEECBF10C0}]
> "DisplayName"="Wikipedia (de)"

there are some linebreaks in the example. In the original file all line begin
either with '[blabla..' or with "something"="something else" or with ';' (one
or two times).

The standard behaviour of Windows (tm) is to ignore this line until the end and
continue with the next line. Wine simply stops here the import and this is
wrong.

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

--- Comment #3 from Bruno Jesus  2012-04-26 23:24:38 CDT ---
Created attachment 39932
  --> http://bugs.winehq.org/attachment.cgi?id=39932
sample file

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39932|application/octet-stream    |text/plain
          mime type|                            |

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #4 from Bruno Jesus  2012-04-26 23:43:01 CDT ---
I can confirm this issue.

Patch sent:
http://www.winehq.org/pipermail/wine-patches/2012-April/113741.html

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |1fba4a6886821ec783fc24bf3a6
                   |                            |d77dc6d5698f7
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Bruno Jesus  2012-04-27 18:04:17 CDT ---
The patch was commited.

http://source.winehq.org/git/wine.git/commitdiff/1fba4a6886821ec783fc24bf3a6...

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2012-05-11 13:21:13 CDT ---
Closing bugs fixed in 1.5.4.

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 27192] Regedit - import failure if reg-file contains ';'

http://bugs.winehq.org/show_bug.cgi?id=27192

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---