[Bug 37994] New: AVRStudio 4.18: Editor window text rendered incorrectly (transparent tab characters)
https://bugs.winehq.org/show_bug.cgi?id=37994
Bug ID: 37994 Summary: AVRStudio 4.18: Editor window text rendered incorrectly (transparent tab characters) Product: Wine Version: 1.5.20 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 Assignee: wine-bugs@winehq.org Reporter: e298903@trbvm.com Distribution: ---
Created attachment 50625 --> https://bugs.winehq.org/attachment.cgi?id=50625 Screenshot showing transparent tab characters
Within the main editor window of AVRStudio, tab characters are not drawn in background color and remain transparent, showing artefacts of the panes underneath.
This makes the application unusable as the editor shows incorrect text characters or graphic elements wherever a transparent tab character appears.
This bug was introduced in wine version 1.5.20 with the changes to gdi32.dll, in particular the changes to GetTextExtentExPoint.
The issue can be fixed for later versions of wine up to 1.7.35 by reverting to the 1.5.19 gdi32 versions of driver.c, font.c and freetype.c.
The AVRStudio 4.18 installation .exe is freely available here (requires email registration): http://www.atmel.com/tools/STUDIOARCHIVE.aspx
Checksum: f2d1e92ab59f06d5f4d029736afc9b814fdd2e1e AVRStudio4.18Setup.exe
Terminal output doesn't show anything useful. See screenshot instead.
https://bugs.winehq.org/show_bug.cgi?id=37994
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- (In reply to e298903 from comment #0)
This bug was introduced in wine version 1.5.20 with the changes to gdi32.dll, in particular the changes to GetTextExtentExPoint.
The issue can be fixed for later versions of wine up to 1.7.35 by reverting to the 1.5.19 gdi32 versions of driver.c, font.c and freetype.c.
Are you referring to this commit http://source.winehq.org/git/wine.git/commit/bbf3e8621ab2168032979489300122e... ?
https://bugs.winehq.org/show_bug.cgi?id=37994
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=37994
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.atmel.com/tools/ | |STUDIOARCHIVE.aspx
https://bugs.winehq.org/show_bug.cgi?id=37994
--- Comment #2 from e298903@trbvm.com --- (In reply to Nikolay Sivov from comment #1)
Are you referring to this commit http://source.winehq.org/git/wine.git/commit/ bbf3e8621ab2168032979489300122e54751b2c9 ?
It could be, I'm not familiar with git and I don't know how to pinpoint the change history, but the whole GetTextExtentExPoint function seems to have been rewritten going to wine version 1.5.20, when the parameter list for this function was reduced.
Fixing this should also close bug 34226, which mentions the issue together with an unrelated crashing issue.
https://bugs.winehq.org/show_bug.cgi?id=37994
--- Comment #3 from Ken Sharp imwellcushtymelike@gmail.com --- A regression test would tell you which commit is the cause.
http://wiki.winehq.org/RegressionTesting
https://bugs.winehq.org/show_bug.cgi?id=37994
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #4 from super_man@post.com --- I downloaded the same version of the program, since the shasum matches.
I don't see the issue mentioned here, maybe you should tell the exact steps how to reproduce this?
wine-1.7.49-104-gbd7f43d
https://bugs.winehq.org/show_bug.cgi?id=37994
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum@codeweavers.com
--- Comment #5 from Andrew Eikum aeikum@codeweavers.com --- I'm able to reproduce this in Wine 1.7.55. The bug seems to only happen on lines with syntax highlighting. Copy a few lines from the screenshot attachment, then flip between MDI windows and you'll see it.
https://bugs.winehq.org/show_bug.cgi?id=37994
--- Comment #6 from Andrew Eikum aeikum@codeweavers.com --- Created attachment 52748 --> https://bugs.winehq.org/attachment.cgi?id=52748 user32: Use font default height if GetTextExtentPointW returns empty rectangle
This fixes it. I'll work on writing tests for it.
https://bugs.winehq.org/show_bug.cgi?id=37994
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |bbf3e8621ab2168032979489300 | |122e54751b2c9
https://bugs.winehq.org/show_bug.cgi?id=37994
--- Comment #7 from Andrew Eikum aeikum@codeweavers.com --- This patch is in Wine now, and I believe this should be fixed.
commit c465209cc1578cf39074b4a8574f7444a0a03891 Author: Andrew Eikum aeikum@codeweavers.com Date: Fri Nov 13 14:52:10 2015 -0600
user32: Use font default height if GetTextExtentPoint returns empty rectangle.
https://bugs.winehq.org/show_bug.cgi?id=37994
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c465209cc1578cf39074b4a8574 | |f7444a0a03891 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #8 from Andrew Eikum aeikum@codeweavers.com --- Retested with wine-1.7.55-38-g19eaed6 and this seems fixed. Please re-open if you still have this problem after the next Wine release.
https://bugs.winehq.org/show_bug.cgi?id=37994
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.8-rc1.
-
wine-bugs＠winehq.org