https://bugs.winehq.org/show_bug.cgi?id=42472
Bug ID: 42472 Summary: debugtools.c static classes duplicates libs/wine/debug.c static debug_classes Product: Wine Version: 2.1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: brewmanz@gmail.com Distribution: ---
debugtools.c static classes duplicates libs/wine/debug.c static debug_classes. As it's a list of the libs/wine/debug.h names for enum __wine_debug_class, then libs/wine/debug.c is where the list should be. If it is deemed that it is indeed okay to have a duplicate list of names rather than a single source, then at the very least document this fact with the duplicated lists.
https://bugs.winehq.org/show_bug.cgi?id=42472
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX
--- Comment #1 from Alexandre Julliard julliard@winehq.org --- The duplication is not an issue, and the list of classes is not going to change anyway. I don't think there's anything to fix here.
https://bugs.winehq.org/show_bug.cgi?id=42472
--- Comment #2 from brewmanz brewmanz@gmail.com --- This was an issue for me for over a week; after a week I raised the issue https://forum.winehq.org/viewtopic.php?f=2&t=28501 and got no response. Several days later I worked out what was causing the problem, but only after I stopped assuming that the code was well written and followed usual coding standards. So maybe there is no issue, nor anything to fix, for those who already understand wine. However, if you wish to open up wine to new developers, I suggest you communicate more when outsiders have issues with your arcane bad practices which you seek to justify. And also stop treating wine development as a closed shop.
https://bugs.winehq.org/show_bug.cgi?id=42472
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- If you have questions about development, I suggest the wine-devel mailing list or the #winehackers IRC channel. Developers don't tend to read the forums.
https://bugs.winehq.org/show_bug.cgi?id=42472
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Austin English austinenglish@gmail.com --- Closing.