[Bug 46512] New: Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

Bug ID: 46512
           Summary: Window text has last letter cut off
           Product: Wine
           Version: 4.0
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 63363
  --> https://bugs.winehq.org/attachment.cgi?id=63363
Image to show the problem.

Run regedit.
In the tree, the HKEY_* items all have the last letter cut off.

If you remove the FT_LOAD_TARGET_LCD flag from
WINE_GGO_HRGB_BITMAP/WINE_GGO_HBGR_BITMAP, then the tree draws as expected.

Some windows applications have their Title cutoff also.

7da7930a10f22cf186e9454fec2807d75f239fad is the first bad commit
commit 7da7930a10f22cf186e9454fec2807d75f239fad
Author: Byeongsik Jeon 
Date:   Tue Nov 13 09:27:09 2018 +0000

gdi32: Specify the suitable hinting flags explicitly.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41639
    Signed-off-by: Byeongsik Jeon 
    Signed-off-by: Huw Davies 
    Signed-off-by: Alexandre Julliard

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |7da7930a10f22cf186e9454fec2
                   |                            |807d75f239fad
                 CC|                            |[e-mail],
                   |                            |[e-mail]
           Keywords|                            |regression

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Mint

--- Comment #1 from Alistair Leslie-Hughes  ---
Both Mint 17.3 and 18.2 have the issue.

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #2 from Byeongsik Jeon  ---
Created attachment 63365
  --> https://bugs.winehq.org/attachment.cgi?id=63365
Fix the wrong advance problem.

Please, test this patch.

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #3 from Alistair Leslie-Hughes  ---
(In reply to Byeongsik Jeon from comment #2)
> Created attachment 63365 [details]
> Fix the wrong advance problem.
>
> Please, test this patch.

Thanks. The patch fixes the issue.

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #4 from Byeongsik Jeon  ---
(In reply to Alistair Leslie-Hughes from comment #3)
> (In reply to Byeongsik Jeon from comment #2)
> > Created attachment 63365 [details]
> > Fix the wrong advance problem.
> >
> > Please, test this patch.
>
> Thanks. The patch fixes the issue.

I knew the potential for this problem. Apart from this patch, there are several
more potential problems. However, the simulation of the problem was not
realized.

I want to know the exact Linux distribution version and Freetype version.

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #5 from Alistair Leslie-Hughes  ---
(In reply to Byeongsik Jeon from comment #4)
> (In reply to Alistair Leslie-Hughes from comment #3)
> > (In reply to Byeongsik Jeon from comment #2)
> > > Created attachment 63365 [details]
> > > Fix the wrong advance problem.
> > >
> > > Please, test this patch.
> >
> > Thanks. The patch fixes the issue.
>
> I knew the potential for this problem. Apart from this patch, there are
> several more potential problems. However, the simulation of the problem was
> not realized.
>
> I want to know the exact Linux distribution version and Freetype version.

Mint 17.3 rosa

Free type 2.6.3

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #6 from Byeongsik Jeon  ---
(In reply to Alistair Leslie-Hughes from comment #5)
> (In reply to Byeongsik Jeon from comment #4)
> > I want to know the exact Linux distribution version and Freetype version.
>
> Mint 17.3 rosa
>
> Free type 2.6.3

OK. It was exactly realized.

Thans.

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #7 from Byeongsik Jeon  ---
Created attachment 63411
  --> https://bugs.winehq.org/attachment.cgi?id=63411
WineTahoma winecfg step1

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #8 from Byeongsik Jeon  ---
Created attachment 63412
  --> https://bugs.winehq.org/attachment.cgi?id=63412
WineTahoma winecfg step2

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #9 from Byeongsik Jeon  ---
Created attachment 63413
  --> https://bugs.winehq.org/attachment.cgi?id=63413
WineTahoma winecfg step3

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #10 from Byeongsik Jeon  ---
step1: run winecfg
step2: click 'Libraries' tab.
step3: click 'Applications' tab again.

Here, WineTahoma rendering is using FreType Auto-Hinter [1].

The text layout is invalid as a whole.
We can see that step1 and step3 are the same tab, but they are different.

The step1 and step2 have different text layout even though they are the same
tab. The text layout changes at runtime.

This problem is a potential Wine issue. I'll send additional patches to the
Wine-devel to solve the problem.

[1]
https://www.freetype.org/freetype2/docs/reference/ft2-base_interface.html#FT...
---
If you use strong auto-hinting, you must apply these delta values! Otherwise
you will experience far too large inter-glyph spacing at small rendering sizes
in most cases.
---

[Bug 46512] Window text has last letter cut off

https://bugs.winehq.org/show_bug.cgi?id=46512

--- Comment #11 from Alistair Leslie-Hughes  ---
This is still and issue with 4.3.

[Bug 46512] Window text has last letter cut off

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46512

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from joaopa  ---
Created attachment 71036
  --> https://bugs.winehq.org/attachment.cgi?id=71036
Screenshot showing the problem is gone

With wine-6.21, compare my screenshot with the screenshot in the comment 0.
The bug is fixed.
Can an administrator close this bug as FIXED?

[Bug 46512] Window text has last letter cut off

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46512

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #13 from Alistair Leslie-Hughes  ---
Marking as fixed.

[Bug 46512] Window text has last letter cut off

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46512

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  ---
Closing bugs fixed in 6.22.