http://bugs.winehq.org/show_bug.cgi?id=26885
Summary: del /s crashes if it encounters a directory containing a space Product: Wine Version: 1.3.18 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: cmd AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com
The following little batch file crashes cmd:
mkdir "foo bar" cd "foo bar" echo hi > hi.dat cd .. del /s hi.dat cd "foo bar" if exist hi.dat echo Del /s failed if exist hi.dat del hi.dat cd .. rmdir "foo bar"
It's hard to fix because WCMD_delete() is complex, and when it recurses, it smashes stuff into a new commandline without quoting. (dir /s doesn't seem to have the same problem?)
http://bugs.winehq.org/show_bug.cgi?id=26885
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source
http://bugs.winehq.org/show_bug.cgi?id=26885
--- Comment #1 from Dan Kegel dank@kegel.com 2011-05-01 14:20:52 CDT --- Created an attachment (id=34420) --> (http://bugs.winehq.org/attachment.cgi?id=34420) Patch series to clean up WCMD_delete a bit and fix the bug
Here are draft patches to simplify WCMD_delete a bit and fix the /s problem. I'll clean them up and post them soon. Hopefully Alexandre will like them better than he liked http://www.winehq.org/pipermail/wine-patches/2011-April/101176.html
http://bugs.winehq.org/show_bug.cgi?id=26885
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Dan Kegel dank@kegel.com 2011-05-01 19:51:56 CDT --- Sent six patches, see http://www.winehq.org/pipermail/wine-patches/2011-May/101439.html
http://bugs.winehq.org/show_bug.cgi?id=26885
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #3 from Dan Kegel dank@kegel.com 2011-06-08 14:04:10 CDT --- fixed by http://source.winehq.org/git/wine.git/?a=commit;h=32ea7d1f2eda84f9e9d687fdee...
http://bugs.winehq.org/show_bug.cgi?id=26885
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org 2011-06-10 13:16:44 CDT --- Closing bugs fixed in 1.3.22.