[Bug 18501] New: Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

Summary: Emperor 'Battle for Dune': can't build units and
                    buildings
           Product: Wine
           Version: 1.1.21
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=21140)
 --> (http://bugs.winehq.org/attachment.cgi?id=21140)
problem is in right part of the screen where you supposed to be able to build
things

this game works with 1.1.21 except that i can't build units and buildings since
i am not enable to click on them or they are hard to click. I sounds stupid but
its really an issue, i think it has to do with a transformation matrix going
bad and therefore shear/rotate/move the clickable images that supposed to be at
some fixed location.

I add a screenshot that illustrates my issue. I also tested it with 1.1.2
version i had on my system for another game. There this issue isn't appearing
so this is a regression, only i hava a sound issue with that version so i don't
advise people to use that version.

I am unable to get regression test since iam using a native 64bit system and so
lack the libraries to build a 32bit older wine version. Therefore i can't
narrow this issue down to a specific version number. Hopefully someone could...

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #1 from Arjan Nieuwenhuis   2009-05-17 06:20:08 ---
Created an attachment (id=21141)
 --> (http://bugs.winehq.org/attachment.cgi?id=21141)
as reference: this is how it supposed to be looking

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

Arjan Nieuwenhuis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21141|as reference: this is how   |a reference while using
        description|it supposed to be looking   |wine-1.1.2: this is how it
                   |                            |supposed to be looking

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
           Severity|major                       |minor

--- Comment #2 from Dmitry Timoshkov   2009-05-17 09:28:35 ---
http://bugs.winehq.org/page.cgi?id=fields.html#importance

Please perform the regression test as requested.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #3 from Arjan Nieuwenhuis   2009-05-17 15:14:01 ---
(In reply to comment #2)
> http://bugs.winehq.org/page.cgi?id=fields.html#importance
>
> Please perform the regression test as requested.

I unfortunately really can't :-(

I'm having major ./configure errors on C compiler which i think has to do with
my 64bit system and im not able to fix. So hopefully there is someone who
can...

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #4 from Vitaliy Margolen   2009-05-17 15:35:14 ---
This might be useful: http://wiki.winehq.org/WineOn64bit

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #5 from Arjan Nieuwenhuis   2009-05-19 05:13:33 ---
(In reply to comment #4)
> This might be useful: http://wiki.winehq.org/WineOn64bit

Used that site and some help from irc #winhq and wine-git is know building. so
a regression test will be there soon.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #6 from Arjan Nieuwenhuis   2009-05-19 05:49:04 ---
after succesful build of wine-git i did a git bisect test with:

git bisect start
git bisect good wine-1.1.2
git bisect bad wine-1.1.21

after going through more than 4000 revisions in about 10 steps i only got
bisect good and end up with a: Release 1.1.21. message

What to do next?

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #7 from Austin English   2009-05-19 10:30:44 ---
(In reply to comment #6)
> after succesful build of wine-git i did a git bisect test with:
>
> git bisect start
> git bisect good wine-1.1.2
> git bisect bad wine-1.1.21
>
> after going through more than 4000 revisions in about 10 steps i only got
> bisect good and end up with a: Release 1.1.21. message
>
> What to do next?

Are you sure 1.1.2 worked? The bug could be in the binary package, not wine
itself.

Try:
$ mv ~/.wine ~/.wine.bak
$ git reset --hard wine-1.1.2
$ ./configure && make depend && make
$ $HOME/wine-git/wine setup.exe
and verify it works.

Be sure

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #8 from Austin English   2009-05-19 10:38:12 ---
(In reply to comment #7)
> Be sure

Be sure the problem isn't sporadic, since that may be the source of your bad
test results.*

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #9 from Arjan Nieuwenhuis   2009-05-19 13:03:41 ---
(In reply to comment #8)
> (In reply to comment #7)
> > Be sure
>
> Be sure the problem isn't sporadic, since that may be the source of your bad
> test results.*

Yep 1.1.2 worked and my wine-git is still working after doing a git bisect. So
i also think its a binary issue.. Ill do your steps anyway soon to confirm.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #10 from Arjan Nieuwenhuis   2009-05-19 13:06:43 ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Be sure
> >
> > Be sure the problem isn't sporadic, since that may be the source of your bad
> > test results.*
>
> Yep 1.1.2 worked and my wine-git is still working after doing a git bisect. So
> i also think its a binary issue.. Ill do your steps anyway soon to confirm.

let me rephrase the working part too:  the game is still working with wine-git
after completing the bisect..

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #11 from Austin English   2009-05-19 13:19:18 ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > (In reply to comment #7)
> > > > Be sure
> > >
> > > Be sure the problem isn't sporadic, since that may be the source of your bad
> > > test results.*
> >
> > Yep 1.1.2 worked and my wine-git is still working after doing a git bisect. So
> > i also think its a binary issue.. Ill do your steps anyway soon to confirm.
>
> let me rephrase the working part too:  the game is still working with wine-git
> after completing the bisect..

So:
$ git reset --hard wine-1.1.2
and
$ git reset --hard origin

both work? If so, bug is definitely in the package, not wine itself (could be
the packagers options/compiler/etc.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #12 from Laurent   2009-11-09 13:52:19 ---
Created an attachment (id=24625)
 --> (http://bugs.winehq.org/attachment.cgi?id=24625)
Bug 18501 fix

In dlls/d3drm/math.c, function D3DRMQuaternionSlerp, there are 2 calls to
D3DRMVectorScale(). The first parameter ( a->v in the first call and b->v in
the second ) are modified by this function, but maybe they should not.

Using a temporary variable instead fixes this problem.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

Laurent  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Laurent   2009-11-09 13:57:06 ---
> So:
> $ git reset --hard wine-1.1.2
> and
> $ git reset --hard origin
>
> both work? If so, bug is definitely in the package, not wine itself (could be
> the packagers options/compiler/etc.

With "git reset --hard origin", Dune Emperor didn't work on my computer. Icons
of units and buildings were not displayed correctly.

This problem seems to be in all version since 1.1.16.

I tried to figure out where the regression was, and it seems to come from this
commit : d3drm: Simplify some functions. [Sat, 14 Feb 2009 13:45:35 +0000
(14:45 +0100)]

I gave some details in my previous post. Using this patch corrected the problem
for me.

I hope it can help to fix this bug.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #14 from Vitaliy Margolen   2009-11-09 21:38:39 ---
Path is almost correct - it needs 2 temporary vectors to prevent modification
of passed vectors a & b. Also test proving that D3DRMQuaternionSlerp does not
modify a & b will be nice.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

IvoAnjo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from IvoAnjo   2009-12-27 21:29:00 ---
I can also confirm this with Crossover Games 8.1.3 .
My screen looks like the attachment showing the problem.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #16 from IvoAnjo   2009-12-28 10:46:18 ---
Created an attachment (id=25425)
 --> (http://bugs.winehq.org/attachment.cgi?id=25425)
Revert changes that broke emperor battle for dune

Ok, I've been testing this and it's definitely commit
687ce93882529670468fa7b20ebf411ea7985e29 that broke it.

The patch from comment #12 doesn't fix it entirely, because it doesn't revert
the changes correctly -- it only re-introduces one of the D3DVECTORs, not both
-- and so it causes graphical issues.

The patch attached really reverts those changes, and makes Emperor: Battle for
Dune work for me again, including building units and structures, the loading
screen bar (that didn't show up without this patch), and the busy cursor
in-game (that also showed up strange and corrupted).

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from joaopa   2010-01-11 16:15:51 ---
Should be fixed in current git. Please check it with the current git.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

--- Comment #18 from IvoAnjo   2010-01-23 04:47:20 ---
(In reply to comment #17)
> Should be fixed in current git. Please check it with the current git.

Sorry for the delay. I can confirm that it is fixed with wine-1.1.37.
Emperor works perfectly again, thanks a lot!

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Jeff Zaroyko   2010-01-23 06:07:49 ---
Reported fixed.

[Bug 18501] Emperor 'Battle for Dune': can't build units and buildings

http://bugs.winehq.org/show_bug.cgi?id=18501

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard   2010-02-05 11:38:53 ---
Closing bugs fixed in 1.1.38.