[Bug 23986] New: datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Summary: datetime control SetRange() has no effect, enter big
                    year will cause CTime assert failed
           Product: Wine
           Version: 1.2
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When use datetime control, call SetRange() to limit time, then modified the
year value to out of range, the modification can success, so SetRange() has no
effect.

In Windows, the same application, the same SetRange() call, then modified the
year value to out of range, the datetime control will refuse the modification,
and return to old value.

I think there should be some check in DATETIME_Char() function in file
"dlls/comctl32/datetime.c" , after change the datetime, call something like
MONTHCAL_IsDateInValidRange() to validate the value.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

--- Comment #1 from Nikolay Sivov   2010-08-13 04:21:08 ---
You mean DTM_SETRANGE and later editing displayed date with keyboard input?
Attach a small test program please, with a source.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

--- Comment #2 from drangon   2010-08-15 21:32:51 ---
Created an attachment (id=30173)
 --> (http://bugs.winehq.org/attachment.cgi?id=30173)
datetime ctrl test exe

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

--- Comment #3 from drangon   2010-08-15 21:34:05 ---
Created an attachment (id=30174)
 --> (http://bugs.winehq.org/attachment.cgi?id=30174)
datetime ctrl test source code ( see test_datectlDlg.cpp )

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Nikolay Sivov   2010-08-21 10:38:30 ---
Yeah, I can see a problem.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Owen Rudge  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Owen Rudge  2012-02-13 12:39:40 CST ---
I have a fix for this I'll submit shortly.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9de240bd0ea38c1c23803c01c42
                   |                            |5cc0c57fe5cd8
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Nikolay Sivov  2013-02-17 01:42:47 CST ---
This is actually fixed with 9de240bd0ea38c1c23803c01c425cc0c57fe5cd8, I just
tested with and without this patch and range limit is checked with keyboard
input.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

--- Comment #7 from Nikolay Sivov  2013-02-17 01:52:48 CST ---
Actually another commit related to that is
c8c3c4be914481d95a9c2790716b9d973e697b37.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

--- Comment #8 from Alexandre Julliard  2013-03-01 14:50:07 CST ---
Closing bugs fixed in 1.5.25.

[Bug 23986] datetime control SetRange() has no effect, enter big year will cause CTime assert failed

http://bugs.winehq.org/show_bug.cgi?id=23986

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2013-03-01 15:09:43 CST ---
Really closing bugs fixed in 1.5.25.