[Bug 52874] New: win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

Bug ID: 52874
           Summary: win32u change prevents chromium from starting
           Product: Wine
           Version: 7.7
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The following commit breaks chromium:

commit 0528f37fdd9b11cc95d074bb9e261d5127cb6ec3
Author: Jacek Caban 
Date:   Tue Apr 19 15:34:44 2022 +0200

win32u: Move NtUserFindWindowEx implementation from user32.

Signed-off-by: Jacek Caban 
    Signed-off-by: Huw Davies 
    Signed-off-by: Alexandre Julliard

chromium just prints a few fixmes and then hangs, using one thread fully.
This only affects the sandbox, --no-sandbox is a workaround.
Reverting fixes the issue.

Download for testing (chrome-win.zip):
https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.ht...

Please use this version for testing, since it's the newest version not affected
by bug 52845.

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
                URL|                            |https://commondatastorage.g
                   |                            |oogleapis.com/chromium-brow
                   |                            |ser-snapshots/index.html?pr
                   |                            |efix=Win/946247/
           Keywords|                            |download, regression

--- Comment #1 from Fabian Maurer  ---
@Jacek, @Huw: Would you please take a look?

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

--- Comment #2 from Fabian Maurer  ---
Looks like it hangs in get_desktop_window, called from get_hwnd_message_parent
inside NtUserFindWindowEx..

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |0528f37fdd9b11cc95d074bb9e2
                   |                            |61d5127cb6ec3

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

--- Comment #3 from Fabian Maurer  ---
Edit: Please don't forget to copy the chromium folder into the WINEPREFIX
before testing, it doesn't work outside.

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

--- Comment #4 from Jacek Caban  ---
I looks like I used syscall interface for NtUserFindWindowEx. It may trigger
driver loading in some rare cases, which can't be done on kernel stack yet. For
that to work, we need drivers moved to unixlib interface. In fact, it works
fine in my local branch where I have winex11 converted. It should be ready for
Wine soon.

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

--- Comment #5 from Jacek Caban  ---
This MR should help: https://gitlab.winehq.org/wine/wine/-/merge_requests/44

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

--- Comment #6 from Fabian Maurer  ---
Seems to work fine, thanks!

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |10f38c06008a1410bc9a1f7d239
                   |                            |d831c6b21749a
         Resolution|---                         |FIXED

--- Comment #7 from Jacek Caban  ---
Fixed in git, thanks for the report:
https://source.winehq.org/git/wine.git/commitdiff/10f38c06008a1410bc9a1f7d23...

[Bug 52874] win32u change prevents chromium from starting

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52874

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 7.9.