[Bug 40704] New: foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

Bug ID: 40704
           Summary: foobar2000 crashes on alt-F (file menu shortcut)
           Product: Wine
           Version: 1.9.11
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 54588
  --> https://bugs.winehq.org/attachment.cgi?id=54588
foobar2000 crash handler log (alt-f)

Not-really-duplicate of Bug 7205, reported in 2007 and closed in 2008.

I'm using foobar2000 1.3.10. I first encountered this issue on Ubuntu 16.04
Cinnamon and Wine 1.6.2 x64, on a (I think) 32-bit wineprefix.

# Setup

* I also replicated this issue in Wine 1.9.10, 32-bit (PlayOnLinux).
* To (hopefully) avoid foobar2000-specific tweaks, I used [Install dialog] ->
_Install a non-listed program_. Then I created a new app profile and

# Instructions

* Install foobar2000 1.3.10.
* Open foobar2000. Press [Alt-F].

# Results

* foobar2000 crashes. The internal crash handler catches the crash and pops up
a dialog.
* I clicked "View Report" and saved a crash log.
* Note that this bug is somewhat random. I've experienced GUI corruption, Wine
crash handler, foobar2000 crash handler, or no issues at all.

# Notes

* [Alt-Enter] crashes.

* [Alt] *focuses* the menu bar without crash. [Alt, Enter] opens the File menu
without crash.
    * Afterwards, [Alt-F] etc. still crashes.

* Clicking on any menu opens that menu without crash.
    * Afterwards, [Alt-F] etc. does NOT crash.
* Clicking the "right-click menu" keyboard key opens an undo/redo menu.
    * This also prevents crashes.

[Bug 40704] foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |[e-mail],
                   |                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail],
                   |                            |[e-mail]
             Status|UNCONFIRMED                 |STAGED
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/user32-DrawMen
                   |                            |uItem

[Bug 40704] foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

Maik Wagner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Maik Wagner  ---
wine-staging 1.9.15 on openSUSE "Tumbleweed" here. Opening the file-menu using
keyboard shortcuts works fine and Alt+Enter doesn't crash the application.

[Bug 40704] foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

--- Comment #2 from Nikolay Sivov  ---
I can't reproduce this crash with 1.3.10 or 1.3.16 and current Wine. Alt-f
opens File menu, and Alt-F opens extended version of it. Could you retest and
clarify instructions if it still happens with Wine 2.20?

[Bug 40704] foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

--- Comment #3 from Nikolay Sivov  ---
Please retest with Wine 3.0, I can't make it crash with that shortcut and menu
displays correctly.

[Bug 40704] foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Staged patchset|https://github.com/wine-com |https://github.com/wine-sta
                   |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast
                   |ster/patches/user32-DrawMen |er/patches/user32-DrawMenuI
                   |uItem                       |tem

[Bug 40704] foobar2000 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

--- Comment #4 from jimbo1qaz  ---
seems fixed on wine-3.15 on kubuntu 18.04

[Bug 40704] foobar2000 v1.3.10 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]
             Status|STAGED                      |RESOLVED
      Fixed by SHA1|                            |962d5e6469730afb7614c0a8d65
                   |                            |a168d7c200e45
           Keywords|                            |download
                URL|                            |https://filehippo.com/downl
                   |                            |oad_foobar2000/download/2cd
                   |                            |1b2b06cd464de5392534d0771b7
                   |                            |49/
            Summary|foobar2000 crashes on alt-F |foobar2000 v1.3.10 crashes
                   |(file menu shortcut)        |on alt-F (file menu
                   |                            |shortcut)

--- Comment #5 from Anastasius Focht  ---
Hello folks,

this was fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/962d5e6469730afb7614c0a8d6...
(part of Wine 2.5 release).

Thanks Huw

Commit 962d5e64697 can be cleanly reverted on top of current Wine 3.15/master
for reverse-test (crash).

$ sha1sum foobar2000_v1.3.10.exe 
0d0d699cb3d39bf9097abb496d6515978e022304  foobar2000_v1.3.10.exe

$ du -sh foobar2000_v1.3.10.exe 
3.8M    foobar2000_v1.3.10.exe

Regards

[Bug 40704] foobar2000 v1.3.10 crashes on alt-F (file menu shortcut)

https://bugs.winehq.org/show_bug.cgi?id=40704

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 3.16.