http://bugs.winehq.org/show_bug.cgi?id=21096
Summary: utorrent drops error 12157 when using a https tracker Product: Wine Version: 1.1.35 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: howl.nsp@gmail.com CC: howl.nsp@gmail.com
utorrent fails to connect through https protocol. It's connection system fully relies on the iexplorer implementation. This error shown up in versions previous to the 1.1.14 but since 1.1.14 to 1.1.34 the ssl connection problem was solved. Now with 1.1.35 appears again.
¿Could be related to "Better certificate checking on secure connections." in 1.1.35?
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #1 from Juan Lang juan_lang@yahoo.com 2009-12-20 13:51:46 --- (In reply to comment #0)
¿Could be related to "Better certificate checking on secure connections." in 1.1.35?
Probably, yes. Please attach a +crypt,+chain log.
http://bugs.winehq.org/show_bug.cgi?id=21096
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |juan_lang@yahoo.com
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=21096
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2009-12-21 03:27:03 --- Please post the results of your regression testing: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=21096
quasi-anonymous user from bugmenot.com winehqbugs@bugmenot.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #3 from quasi-anonymous user from bugmenot.com winehqbugs@bugmenot.com 2010-01-07 06:18:43 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #4 from David Santamaría Rogado howl.nsp@gmail.com 2010-03-24 18:18:20 --- I'm sorry for the time without response, no body with µTorrent seems to be interested to provide the necesary information to solve this issue so we had deactivated globally https from our tracker.
Anyway the issue seems to be still there.
http://bugs.winehq.org/show_bug.cgi?id=21096
Alex Balut alexandru.balut@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandru.balut@gmail.com
--- Comment #5 from Alex Balut alexandru.balut@gmail.com 2010-05-11 16:05:22 --- Please provide a torrent file which has a https:// tracker so we can test and provide the necessary information to solve this issue. Thanks.
http://bugs.winehq.org/show_bug.cgi?id=21096
Danila Sentiabov dsent.zen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dsent.zen@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=21096
Jannik H. scrawl@baseoftrash.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |scrawl@baseoftrash.de
--- Comment #6 from Jannik H. scrawl@baseoftrash.de 2010-06-17 04:56:06 --- Also affects League of Legends (Multiplayer Game), I got the error when I tried to login.
So I compiled wine 1.1.44 with the wininet of wine 1.1.34, now it seems to work fine.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #7 from Juan Lang juan_lang@yahoo.com 2010-06-17 08:15:57 --- Still waiting for a +crypt,+chain log.
http://bugs.winehq.org/show_bug.cgi?id=21096
Christoph Hohmann reboot@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |reboot@gmx.ch
--- Comment #8 from Christoph Hohmann reboot@gmx.ch 2010-06-17 13:29:35 --- The login problem of League of Legends can be fixed with the patch attached to Bug 21870 as far as I know. It would be good to know, if that patch also fixes this problem. It could be a duplicate.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #9 from Jannik H. scrawl@baseoftrash.de 2010-06-18 07:25:54 --- I had enabled that patch, so it doesn't fix this issue.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #10 from Jannik H. scrawl@baseoftrash.de 2010-06-18 07:45:05 --- Relevant +crypt,+chain log:
trace:crypt:CertOpenStore (#0002, 00000000, 00000000, 00002000, (nil)) trace:crypt:CRYPT_MemOpenStore (0, 00002000, (nil)) trace:crypt:CertFreeCertificateContext ((nil)) trace:crypt:CertCloseStore (0x21c128, 00000000) trace:crypt:CertCloseStore 0x21c128's ref count is 0, freeing trace:crypt:CRYPT_MemCloseStore (0x21c128, 00000000) err:wininet:NETCON_secure_connect SSL_connect failed: 12157
By the way, using native wininet or from pre-1.1.35, there is no wine error message, but I can't login either :/
Cristoph, do you have an idea? I'm using wine with the 2 patches for LoL and I just can't login - with Windows in VirtualBox login works :/
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #11 from Juan Lang juan_lang@yahoo.com 2010-06-18 08:32:07 --- (In reply to comment #10)
Relevant +crypt,+chain log:
trace:crypt:CertOpenStore (#0002, 00000000, 00000000, 00002000, (nil)) trace:crypt:CRYPT_MemOpenStore (0, 00002000, (nil)) trace:crypt:CertFreeCertificateContext ((nil)) trace:crypt:CertCloseStore (0x21c128, 00000000) trace:crypt:CertCloseStore 0x21c128's ref count is 0, freeing trace:crypt:CRYPT_MemCloseStore (0x21c128, 00000000) err:wininet:NETCON_secure_connect SSL_connect failed: 12157
If this is from league of nations, this is probably a different bug. Please open a separate bug for it. What's happening here is that league of nations is not sending any certificate in its https connection.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #12 from Juan Lang juan_lang@yahoo.com 2010-09-24 13:36:26 CDT --- Ping: anyone able to provide a +crypt,+chain log from uTorrent?
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #13 from Jerome Leclanche adys.wh@gmail.com 2010-09-24 20:11:28 CDT --- Created an attachment (id=30946) --> (http://bugs.winehq.org/attachment.cgi?id=30946) torrent using https tracker
(In reply to comment #12)
Ping: anyone able to provide a +crypt,+chain log from uTorrent?
Im still recompiling wine with openssl/gnutls support; meanwhile, you can try this torrent, it's a 40mb file using https://betadoctor.appspot.com/announce
http://bugs.winehq.org/show_bug.cgi?id=21096
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #30946|0 |1 is obsolete| |
--- Comment #14 from Jerome Leclanche adys.wh@gmail.com 2010-09-24 20:21:13 CDT --- Created an attachment (id=30947) --> (http://bugs.winehq.org/attachment.cgi?id=30947) torrent using https tracker
Nevermind, use this one instead. Google App Engine and torrent tracking don't mix in very well...
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #15 from Austin English austinenglish@gmail.com 2010-09-25 03:05:17 CDT --- Created an attachment (id=30949) --> (http://bugs.winehq.org/attachment.cgi?id=30949) +crypt,+chain
I get http error 403, not 12157, but definitely fails to connect.
Juan, let me know if you need the regression test.
http://bugs.winehq.org/show_bug.cgi?id=21096
floppe@floppe.eu.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floppe@floppe.eu.org
--- Comment #16 from floppe@floppe.eu.org 2010-09-25 03:08:06 CDT --- (In reply to comment #15)
Created an attachment (id=30949)
--> (http://bugs.winehq.org/attachment.cgi?id=30949) [details]
+crypt,+chain
I get http error 403, not 12157, but definitely fails to connect.
Juan, let me know if you need the regression test.
Tracker maybe down. does not work in Windows7 either.
http://bugs.winehq.org/show_bug.cgi?id=21096
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #17 from Jerome Leclanche adys.wh@gmail.com 2010-09-25 04:02:37 CDT --- (In reply to comment #15)
Created an attachment (id=30949)
--> (http://bugs.winehq.org/attachment.cgi?id=30949) [details]
+crypt,+chain
I get http error 403, not 12157, but definitely fails to connect.
Juan, let me know if you need the regression test.
Yeah, tracker seems down. Looks like appspot just doesn't like torrent trackers.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #18 from Juan Lang juan_lang@yahoo.com 2010-09-27 13:20:07 CDT --- (In reply to comment #15)
I get http error 403, not 12157, but definitely fails to connect.
Juan, let me know if you need the regression test.
That would be a different error. As pointed out by others, this fails on Windows too. Unless someone can create a tracker that handles an https tracker, this is basically abandoned, which is a shame, as I wouldn't be surprised if a regression were introduced here. We used not to check certificates in https connections at all, whereas now we do. Doing so is certainly more correct, but it's possible that the checks are too strict or merely broken.
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #30947|0 |1 is obsolete| |
--- Comment #19 from Austin English austinenglish@gmail.com 2010-09-28 01:17:21 CDT --- Created an attachment (id=30985) --> (http://bugs.winehq.org/attachment.cgi?id=30985) torrent with https tracker
This is running on my laptop, so it may shut down, but I'll try to keep it up.
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #30949|0 |1 is obsolete| |
--- Comment #20 from Austin English austinenglish@gmail.com 2010-09-28 01:17:53 CDT --- Created an attachment (id=30986) --> (http://bugs.winehq.org/attachment.cgi?id=30986) +crypt,+chain
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #21 from Austin English austinenglish@gmail.com 2010-09-28 01:19:20 CDT --- I've uploaded a new torrent (of the openbsd 4.7 install iso). It's on my home machine, but it should stay up, if not, ping me.
This torrent works on that same machine with native transmission, fails in utorrent. On a friend's machine, works in native transmission, fails in utorrent (wine). Works in utorrent on windows (Vista).
http://bugs.winehq.org/show_bug.cgi?id=21096
Jannik H. scrawl@baseoftrash.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|scrawl@baseoftrash.de |
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #22 from Juan Lang juan_lang@yahoo.com 2010-09-28 11:52:03 CDT --- (In reply to comment #20)
+crypt,+chain
Hm, there's no crypto error in here. Is it failing with error 12157 for you? A regression test might be handy after all, because perhaps there's another problem.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #23 from Austin English austinenglish@gmail.com 2010-09-28 12:14:30 CDT --- (In reply to comment #22)
(In reply to comment #20)
+crypt,+chain
Hm, there's no crypto error in here. Is it failing with error 12157 for you? A regression test might be handy after all, because perhaps there's another problem.
Ah, seems I'm getting 12055, ERROR_INTERNET_SEC_CERT_ERRORS. Let me try an older wine version...
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #24 from Austin English austinenglish@gmail.com 2010-09-28 12:57:15 CDT --- Okay, I get 12157 in 1.1.36. 1.1.35 crashes running utorrent for me :-/. 1.1.33 works fine.
Now let's see what bisect finds...
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #25 from Austin English austinenglish@gmail.com 2010-09-28 13:58:38 CDT --- Created an attachment (id=31002) --> (http://bugs.winehq.org/attachment.cgi?id=31002) +crypt,+chain
This is with a wine version that has the 12157 bug. Still working on rt.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #26 from Juan Lang juan_lang@yahoo.com 2010-09-28 14:13:48 CDT --- (In reply to comment #23)
Ah, seems I'm getting 12055, ERROR_INTERNET_SEC_CERT_ERRORS. Let me try an older wine version...
That can only happen if OpenSSL is rejecting the certificate chain: http://source.winehq.org/source/dlls/wininet/netconnection.c#L297 http://source.winehq.org/source/dlls/wininet/netconnection.c#L339
In this case, no crypto code is called, and there's frankly nothing we can do about it. Are you sure the certificate used is a) valid, and b) that OpenSSL trusts it? You may have to install the root certificate somewhere.
(There's nothing in the +crypt,+chain log related to the connection, either, just the usual background noise.)
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #27 from Austin English austinenglish@gmail.com 2010-09-28 14:17:25 CDT --- (In reply to comment #26)
(In reply to comment #23)
Ah, seems I'm getting 12055, ERROR_INTERNET_SEC_CERT_ERRORS. Let me try an older wine version...
That can only happen if OpenSSL is rejecting the certificate chain: http://source.winehq.org/source/dlls/wininet/netconnection.c#L297 http://source.winehq.org/source/dlls/wininet/netconnection.c#L339
In this case, no crypto code is called, and there's frankly nothing we can do about it. Are you sure the certificate used is a) valid, and b) that OpenSSL trusts it? You may have to install the root certificate somewhere.
Crypto always confuses me, so no I can't be sure :-).
The certificate was one I generated for just this purpose (Azureus has you generate one before setting up an https tracker).
What I do know is that with no fiddling on my win7 work PC, I installed utorrent and opened that torrent, it downloads. In wine 1.1.33, the same (it does give 'err:wininet:NETCON_secure_connect couldn't verify the security of the connection, 18' though). In 1.1.35+, fails. Sometime between 1.1.35 and git, the error changed from 12157 to 12055.
I'm currently bisecting the first regression, though there are several commits that fail with a different error: err:wininet:NETCON_secure_connect SSL_connect failed: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
I've been skipping those.
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |wininet
--- Comment #28 from Austin English austinenglish@gmail.com 2010-09-28 15:01:36 CDT --- Marking this: err:wininet:NETCON_secure_connect SSL_connect failed: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
as a skip never lets me get past 7 more steps. Marking it as bad gives:
6217326a09dda8d029f80846c1ea9c2725c532b5 is the first bad commit commit 6217326a09dda8d029f80846c1ea9c2725c532b5 Author: Juan Lang juan.lang@gmail.com Date: Sun Dec 13 15:42:29 2009 -0800
wininet: Set callback to verify hostname with peer's certificate.
:040000 040000 af10cf539d98559c92c64ef0b505e88dc90ea4b1 9488ceb77f04f99cafe18b589c9b179b2f15291c M dlls
and reverting that does work.
Two questions: A) do you need more logs B) do you need a separate regression test for the 12055 error?
http://bugs.winehq.org/show_bug.cgi?id=21096
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|wininet |-unknown
--- Comment #29 from Juan Lang juan_lang@yahoo.com 2010-09-28 15:07:11 CDT --- (In reply to comment #28)
Two questions: A) do you need more logs
Not really, as this only points to a configuration error (which would make this invalid.) Let's look at the diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6217326a09dda8d029f808...
Here's the substantive change: + pSSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, netconn_secure_verify); That is, a function is set to enable checking the certificate. Before, no checking was done. Here's the function that actually checks the certificate:
+static int netconn_secure_verify(int preverify_ok, X509_STORE_CTX *ctx) +{ + SSL *ssl; + WCHAR *server; + + ssl = pX509_STORE_CTX_get_ex_data(ctx, + pSSL_get_ex_data_X509_STORE_CTX_idx()); + server = pSSL_get_ex_data(ssl, hostname_idx); + FIXME("verify %s\n", debugstr_w(server)); + return preverify_ok; +}
Basically, the function just returns preverify_ok. This is set by OpenSSL, and there's nothing we can do in Wine to fix it: you have to fix your OpenSSL configuration first.
B) do you need a separate regression test for the 12055 error?
No.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #30 from Juan Lang juan_lang@yahoo.com 2010-09-28 15:25:22 CDT --- (In reply to comment #27)
The certificate was one I generated for just this purpose (Azureus has you generate one before setting up an https tracker).
Actually, this is probably the interesting part. Could you attach a +crypt log of this? It could be that the app installs the certificate into a local "certificate store", but since OpenSSL doesn't check the crypt32 certificate stores, that's the reason the connection is failing. That would make the scope of this bug pretty large, but still valid.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #31 from Austin English austinenglish@gmail.com 2010-09-28 16:13:51 CDT --- (In reply to comment #30)
(In reply to comment #27)
The certificate was one I generated for just this purpose (Azureus has you generate one before setting up an https tracker).
Actually, this is probably the interesting part. Could you attach a +crypt log of this? It could be that the app installs the certificate into a local "certificate store", but since OpenSSL doesn't check the crypt32 certificate stores, that's the reason the connection is failing. That would make the scope of this bug pretty large, but still valid.
Azureus was the native linux version.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #32 from Juan Lang juan_lang@yahoo.com 2010-09-28 16:20:53 CDT --- (In reply to comment #31)
Azureus was the native linux version.
Ah. That puts us back into invalid territory then.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #33 from David Santamaría Rogado howl.nsp@gmail.com 2010-09-28 17:05:18 CDT --- (In reply to comment #32)
(In reply to comment #31)
Azureus was the native linux version.
Ah. That puts us back into invalid territory then.
µTorrent in windows doesn't fail with invalid certificate, it use it without problem.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #34 from Juan Lang juan_lang@yahoo.com 2010-09-28 17:12:40 CDT --- (In reply to comment #33)
µTorrent in windows doesn't fail with invalid certificate, it use it without problem.
Yes, but the failure in Austin's log can't be fixed in Wine. It can only be fixed by configuring OpenSSL correctly. That makes this not a Wine bug.
http://bugs.winehq.org/show_bug.cgi?id=21096
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |wininet
--- Comment #35 from Juan Lang juan_lang@yahoo.com 2010-09-28 17:27:14 CDT --- (In reply to comment #34)
Yes, but the failure in Austin's log can't be fixed in Wine.
Actually, this statement is still perhaps too strong. This line in the log suggests that uTorrent may be turning off some checking: fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS; STUB
I'll attach a flag to help get a little more info in a sec.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #36 from Juan Lang juan_lang@yahoo.com 2010-09-28 17:30:13 CDT --- Created an attachment (id=31007) --> (http://bugs.winehq.org/attachment.cgi?id=31007) Patch: Trace security flags passed to InternetSetOption
Could someone please attach the console output with this patch applied? No additional debug channels needed, just the plain console output.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #37 from Austin English austinenglish@gmail.com 2010-09-28 17:41:09 CDT --- (In reply to comment #36)
Created an attachment (id=31007)
--> (http://bugs.winehq.org/attachment.cgi?id=31007) [details]
Patch: Trace security flags passed to InternetSetOption
Could someone please attach the console output with this patch applied? No additional debug channels needed, just the plain console output.
fixme:iphlpapi:GetBestInterfaceEx address family 23 not supported fixme:iphlpapi:adapterAddressesFromIndex address family 23 unsupported fixme:wininet:HTTPREQ_QueryOption Semi-STUB INTERNET_OPTION_SECURITY_FLAGS: 1 fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS; STUB err:wininet:NETCON_secure_connect SSL_connect failed: 12055
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #38 from Juan Lang juan_lang@yahoo.com 2010-09-28 17:44:20 CDT --- (In reply to comment #37)
Could someone please attach the console output with this patch applied?
(snip)
fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS; STUB
I think you missed the "with this patch applied" part of the request.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #39 from Austin English austinenglish@gmail.com 2010-09-28 17:46:55 CDT --- (In reply to comment #38)
(In reply to comment #37)
Could someone please attach the console output with this patch applied?
(snip)
fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS; STUB
I think you missed the "with this patch applied" part of the request.
Long day...
fixme:wininet:HTTPREQ_QueryOption Semi-STUB INTERNET_OPTION_SECURITY_FLAGS: 1 fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS (00000101); STUB err:wininet:NETCON_secure_connect SSL_connect failed: 12055
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #40 from Juan Lang juan_lang@yahoo.com 2010-09-28 18:13:40 CDT --- (In reply to comment #39)
fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS (00000101); STUB
Thanks. This shows one thing I was suspecting: the flag SECURITY_FLAG_IGNORE_UNKNOWN_CA is being passed, so I assume that means native wininet doesn't check whether the root certificate is trusted.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #41 from Juan Lang juan_lang@yahoo.com 2010-09-28 18:15:08 CDT --- Created an attachment (id=31008) --> (http://bugs.winehq.org/attachment.cgi?id=31008) Patch: Don't make use of OpenSSL's security checks, as crypt32 also verifies certificate chain
Does this patch help?
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #42 from Juan Lang juan_lang@yahoo.com 2010-09-28 18:16:15 CDT --- (In reply to comment #41)
Does this patch help?
Actually, I suspect it won't fix it, but it might make things different: I'm hoping the error code is different, and that a +crypt,+chain log might be a little more interesting.
http://bugs.winehq.org/show_bug.cgi?id=21096
Alex Balut alexandru.balut@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|alexandru.balut@gmail.com |
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #43 from Austin English austinenglish@gmail.com 2010-09-28 18:19:25 CDT --- (In reply to comment #42)
(In reply to comment #41)
Does this patch help?
Actually, I suspect it won't fix it, but it might make things different: I'm hoping the error code is different, and that a +crypt,+chain log might be a little more interesting.
Different error, yes: fixme:wininet:HTTPREQ_QueryOption Semi-STUB INTERNET_OPTION_SECURITY_FLAGS: 1 fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_SECURITY_FLAGS; STUB err:wininet:NETCON_secure_connect SSL_connect failed: 12045
I'll get you a new log.
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #30986|0 |1 is obsolete| | Attachment #31002|0 |1 is obsolete| |
--- Comment #44 from Austin English austinenglish@gmail.com 2010-09-28 18:24:09 CDT --- Created an attachment (id=31009) --> (http://bugs.winehq.org/attachment.cgi?id=31009) +crypt,+chain try 3
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #45 from Juan Lang juan_lang@yahoo.com 2010-09-28 18:58:32 CDT --- (In reply to comment #44)
+crypt,+chain try 3
I think this is without attachment 31008 applied, but no matter. The unadorned log puts us on the scent, I hope. I'll attach more patches to try in a sec. Please apply on top of attachment 31008.
http://bugs.winehq.org/show_bug.cgi?id=21096
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #31007|0 |1 is obsolete| |
--- Comment #46 from Juan Lang juan_lang@yahoo.com 2010-09-28 18:59:53 CDT --- (From update of attachment 31007) Not needed beyond collecting a log with it, which Austin did in comment 39.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #47 from Juan Lang juan_lang@yahoo.com 2010-09-28 19:02:08 CDT --- Created an attachment (id=31010) --> (http://bugs.winehq.org/attachment.cgi?id=31010) Patch 2/4: Store WININET_NETCONNECTION * in SSL context
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #48 from Juan Lang juan_lang@yahoo.com 2010-09-28 19:02:43 CDT --- Created an attachment (id=31011) --> (http://bugs.winehq.org/attachment.cgi?id=31011) Patch 3/4: Store security flags in WININET_NETCONNECTION
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #49 from Juan Lang juan_lang@yahoo.com 2010-09-28 19:03:33 CDT --- Created an attachment (id=31012) --> (http://bugs.winehq.org/attachment.cgi?id=31012) Patch 4/4: Honor security flags when verifying certificates
Do these patches help?
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #50 from Austin English austinenglish@gmail.com 2010-09-28 19:12:19 CDT --- (In reply to comment #45)
(In reply to comment #44)
+crypt,+chain try 3
I think this is without attachment 31008 [details] applied, but no matter. The unadorned
I think you meant 31007? If so, yeah.
log puts us on the scent, I hope. I'll attach more patches to try in a sec. Please apply on top of attachment 31008 [details].
Done, but it actually makes it worse. Utorrent starts opening itself in an infinite loop o.0. To make sure I wasn't crazy: $ wineserver -k $ wine utorrent.exe # runs 1 instance, doesn't download $ wineserver -k $ ~/wine-git/wine utorrent.exe # with your patches, runs 1 instance, no downloading, and after about 3-5 seconds, spawns a new instance, rinse, lather, repeat
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #51 from Juan Lang juan_lang@yahoo.com 2010-09-28 20:16:54 CDT --- (In reply to comment #50)
Done, but it actually makes it worse. Utorrent starts opening itself in an infinite loop o.0.
Thanks. Yeah, it's crashing due to another bug. I'll update here shortly.
http://bugs.winehq.org/show_bug.cgi?id=21096
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #31012|0 |1 is obsolete| |
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #52 from Juan Lang juan_lang@yahoo.com 2010-09-28 20:28:28 CDT --- Created an attachment (id=31013) --> (http://bugs.winehq.org/attachment.cgi?id=31013) Patch 4/7: Don't retrieve a certificate that isn't used
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #53 from Juan Lang juan_lang@yahoo.com 2010-09-28 20:30:24 CDT --- Created an attachment (id=31014) --> (http://bugs.winehq.org/attachment.cgi?id=31014) Patch 5/7: Don't call SSL_connect until initialization is complete
This was the source of the crash, SSL_connect was called before the required data were set, resulting a dereferencing a NULL pointer. (utorrent's exception handler caught it and respawned itself.)
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #54 from Juan Lang juan_lang@yahoo.com 2010-09-28 20:31:04 CDT --- Created an attachment (id=31015) --> (http://bugs.winehq.org/attachment.cgi?id=31015) Patch 6/7: Honor security flags when verifying certificates
New and improved from the previous 4/4.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #55 from Juan Lang juan_lang@yahoo.com 2010-09-28 20:33:25 CDT --- Created an attachment (id=31016) --> (http://bugs.winehq.org/attachment.cgi?id=31016) Patch 7/7: Remove unneeded error message
This isn't strictly required, it just prevents a confusing error message from appearing in the console. How's it work for you with all these patches applied? That is, with attachments 31008, 31010, 31011, 31013, 31014, 31015, and this one applied?
(I can't tell myself: utorrent's main screen is all black for me.)
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #56 from Austin English austinenglish@gmail.com 2010-09-28 20:57:28 CDT --- (In reply to comment #55)
Created an attachment (id=31016)
--> (http://bugs.winehq.org/attachment.cgi?id=31016) [details]
Patch 7/7: Remove unneeded error message
This isn't strictly required, it just prevents a confusing error message from appearing in the console. How's it work for you with all these patches applied? That is, with attachments 31008, 31010, 31011, 31013, 31014, 31015, and this one applied?
Still fails. I'll attach a new log.
(I can't tell myself: utorrent's main screen is all black for me.)
Hm, are you using 2.0.4 (latest)? You can get it quickly with winetricks (it'll put it in C:\windows so you can do 'winetricks utorrent' from any directory.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #57 from Austin English austinenglish@gmail.com 2010-09-28 20:58:05 CDT --- Created an attachment (id=31017) --> (http://bugs.winehq.org/attachment.cgi?id=31017) +crypt,+chain try 4
Bzip2 -9'ed. 23 MB uncompressed.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #58 from Juan Lang juan_lang@yahoo.com 2010-09-28 21:30:08 CDT --- Could you attach a +wininet log with all them patches applied? Thanks!
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #59 from Juan Lang juan_lang@yahoo.com 2010-09-28 21:49:25 CDT --- Answering my own question. With all these patches applied, I see:
trace:wininet:netconn_verify_cert verifying L"68.4.217.113" trace:wininet:netconn_verify_cert returning 00000000 trace:wininet:HTTP_OpenConnection 0 <-- trace:wininet:HTTP_HttpSendRequestW full request -> "GET /scrape?info_hash=%07uQ%18%ba%ef%89r%09%9e%3ad%25%5bc%20%40%b7w%26 HTTP/1.1\r\nAccept: */*\r\nHost: 68.4.217.113:7000\r\nAccept-Encoding: gzip\r\nUser-Agent: uTorrent/2040(22150)\r\nPragma: no-cache\r\n\r\n"
That is, the connection succeeds, and stuff continues to happen with the connection. So it's no longer regressing with all these patches. When you say it still fails, what do you see?
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #60 from Austin English austinenglish@gmail.com 2010-09-29 12:12:27 CDT --- (In reply to comment #59)
Answering my own question. With all these patches applied, I see:
trace:wininet:netconn_verify_cert verifying L"68.4.217.113" trace:wininet:netconn_verify_cert returning 00000000 trace:wininet:HTTP_OpenConnection 0 <-- trace:wininet:HTTP_HttpSendRequestW full request -> "GET /scrape?info_hash=%07uQ%18%ba%ef%89r%09%9e%3ad%25%5bc%20%40%b7w%26 HTTP/1.1\r\nAccept: */*\r\nHost: 68.4.217.113:7000\r\nAccept-Encoding: gzip\r\nUser-Agent: uTorrent/2040(22150)\r\nPragma: no-cache\r\n\r\n"
That is, the connection succeeds, and stuff continues to happen with the connection. So it's no longer regressing with all these patches. When you say it still fails, what do you see?
No, I'm sorry, you're right, it works. It seems I didn't apply one patch yesterday with the last set. (For the record, it wouldn't download, though it did connect to the tracker and retrieve the number of seeders/peers).
So yeah, good to go once those get in, thanks! :-)
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #61 from Juan Lang juan_lang@yahoo.com 2010-09-29 12:32:16 CDT --- (In reply to comment #60)
No, I'm sorry, you're right, it works.
Excellent, thanks. I've improved the patches a little from those attached here, and I've sent them in, starting with: http://www.winehq.org/pipermail/wine-patches/2010-September/093883.html
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #62 from David Santamaría Rogado howl.nsp@gmail.com 2010-09-29 17:18:37 CDT --- (In reply to comment #61)
(In reply to comment #60)
No, I'm sorry, you're right, it works.
Excellent, thanks. I've improved the patches a little from those attached here, and I've sent them in, starting with: http://www.winehq.org/pipermail/wine-patches/2010-September/093883.html
Good work, you too Austin English.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #63 from Jerome Leclanche adys.wh@gmail.com 2010-09-30 11:37:38 CDT --- Fixed by commits: 3e51313e37b2062dee2b4a5ee06b8d981728ff99 ce0164c3f784e1768b74296b7a19c92d030a8723 77c4ade08bbd6a76d59c2c6e45a4585470909539 181a367a1f77ae3b88e0e36dcad7b0840b920de6 98dbdadcdafaa3708e36074708ade5782f892fe4 44112c367f6a08a7dd0d841b34d0ead3d6bcac63 0e4e2a378abeee691c710d38920dcbac1f9dec9c
Nice job.
http://bugs.winehq.org/show_bug.cgi?id=21096
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #64 from Austin English austinenglish@gmail.com 2010-09-30 11:50:23 CDT --- Fixed, thanks Juan.
http://bugs.winehq.org/show_bug.cgi?id=21096
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.2.x
--- Comment #65 from Juan Lang juan_lang@yahoo.com 2010-10-01 12:31:56 CDT --- Nominating for 1.2.1.
http://bugs.winehq.org/show_bug.cgi?id=21096
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #66 from Alexandre Julliard julliard@winehq.org 2010-10-01 13:57:08 CDT --- Closing bugs fixed in 1.3.4.
http://bugs.winehq.org/show_bug.cgi?id=21096
--- Comment #67 from Alexandre Julliard julliard@winehq.org 2010-10-08 09:56:29 CDT --- (In reply to comment #65)
Nominating for 1.2.1.
It will have to wait for 1.2.2 I'm afraid.
http://bugs.winehq.org/show_bug.cgi?id=21096
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.x |---
--- Comment #68 from Alexandre Julliard julliard@winehq.org 2010-12-03 12:51:40 CST --- Removing 1.2.x milestone from bugs included in 1.2.2.
-
wine-bugs＠winehq.org