[Bug 40340] New: A broken image (a corrupt DB/filesystem?)

https://bugs.winehq.org/show_bug.cgi?id=40340

Bug ID: 40340
           Summary: A broken image (a corrupt DB/filesystem?)
           Product: WineHQ Apps Database
           Version: unspecified
          Hardware: Other
                OS: other
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P1
         Component: appdb-unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

https://appdb.winehq.org/appimage.php?iId=33144 =>

The image cannot be displayed because it contains errors.

Referenced by https://appdb.winehq.org/screenshots.php?iAppId=&iVersionId=22031

Your PHP script outputs this, instead of an actual image:

<br />
<b>Warning</b>:  imagejpeg(): Filename cannot be empty in
<b>/home/winehq/opt/appdb/include/image.php</b> on line <b>363</b><br />

[Bug 40340] A broken image (a corrupt DB/filesystem?)

https://bugs.winehq.org/show_bug.cgi?id=40340

--- Comment #2 from Artem S. Tashkinov  ---
And here https://appdb.winehq.org/screenshots.php?iAppId=3120

Seriously, what have you done? ;-)

[Bug 40340] A broken image (a corrupt DB/filesystem?)

https://bugs.winehq.org/show_bug.cgi?id=40340

--- Comment #1 from Artem S. Tashkinov  ---
Actually there are many broken files:
https://appdb.winehq.org/screenshots.php?iAppId=6824

[Bug 40340] JPG screenshots in the AppDB are not displayed

https://bugs.winehq.org/show_bug.cgi?id=40340

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

--- Comment #4 from Artem S. Tashkinov  ---
(In reply to Rosanne DiMesio from comment #3)
> Not a blocker.

It's hard to block something in regard to the appdb website.

I just wanted to draw immediate attention to this huge issue.

[Bug 40340] JPG screenshots in the AppDB are not displayed

https://bugs.winehq.org/show_bug.cgi?id=40340

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|A broken image (a corrupt   |JPG screenshots in the
                   |DB/filesystem?)             |AppDB are not displayed
                 CC|                            |[e-mail]
           Severity|blocker                     |normal
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Rosanne DiMesio  ---
Not a blocker.

Confirming.

It appears the problem affects jpgs but not pngs. I uploaded two versions of
the same image, one jpg and one png, and the png displays properly while the
jpg does not.

This is probably related to the site upgrades last week.

[Bug 40340] JPG screenshots in the AppDB are not displayed

https://bugs.winehq.org/show_bug.cgi?id=40340

Jeremy Newman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Jeremy Newman  ---
I fixed the error with the following commit:
http://source.winehq.org/git/appdb.git/?a=commit;h=f69dfc770c66885f95ae8c6e7...

Not sure why, but the current API requires the second param if imagejpeg() to
be null to output directly.

This fixes most of the images. I'm still seeing some broken images, but nothing
is coming up in the log about them.
This page for example:
https://appdb.winehq.org/screenshots.php?iAppId=&iVersionId=30073

[Bug 40340] JPG screenshots in the AppDB are not displayed

https://bugs.winehq.org/show_bug.cgi?id=40340

Jeremy Newman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Jeremy Newman  ---
The last missing images just seemed to be a caching issue, a shift-reload fixed
them.

This issue looks completely fixed now.

[Bug 40340] JPG screenshots in the AppDB are not displayed

https://bugs.winehq.org/show_bug.cgi?id=40340

--- Comment #7 from Artem S. Tashkinov  ---
(In reply to Jeremy Newman from comment #6)
> The last missing images just seemed to be a caching issue, a shift-reload
> fixed them.
>
> This issue looks completely fixed now.

Thanks!

While we're at it, please change

/include/screenshot.php, line 542, from

"<br>View&nbsp;Screenshot</a></div>";

to

"<br>View&nbsp;Screenshots</a></div>";

Most applications have more than one screenshot.

[Bug 40340] JPG screenshots in the AppDB are not displayed

https://bugs.winehq.org/show_bug.cgi?id=40340

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Rosanne DiMesio  ---
Closing fixed AppDB bugs.