[Bug 16363] New: Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Summary: Google Chrome window is rendered totally black.
           Product: Wine
           Version: 1.1.10
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=17679)
 --> (http://bugs.winehq.org/attachment.cgi?id=17679)
Wine output upon starting chrome

Everything renders fine, apart from the part that displays the webpage, making
chrome completely useless. Cannot do anything without seeing anything from the
webpage.

Started in wine 1.1.08, and still exists.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #1 from Lei Zhang   2008-12-07 02:34:38 ---
Was it ok in Wine 1.1.7? If so, please run a regression test:

http://wiki.winehq.org/RegressionTesting

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Leonardo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Leonardo   2008-12-25 17:55:46 ---
I have the same problem using Wine 1.1.11 on debian lenny 64. I'm trying to use
stable version of Google Chrome.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #3 from Adam Mizerski   2009-01-06 17:25:22 ---
Got the same (openSuSE 11.0 x86_64, wine 1.1.12)

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Lei Zhang   2009-01-06 19:17:00 ---
Confirming then. Can anyone check an older version of Wine and see if this is a
regression?

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Jeremy Jackins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Jeremy Jackins   2009-01-10 15:10:43 ---
Confirming the bug in wine 1.1.12
I checked, and the bug does NOT occur in wine 1.1.7.
Is there documentation on fixing regressions? If someone would point me in the
right direction I would be happy to work on the bug myself.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #6 from Jeremy Jackins   2009-01-10 15:14:29 ---
oops just saw the link in the second post. I will run a regression test later
today.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #7 from Jeremy Jackins   2009-01-10 19:55:04 ---
Alright, I've found the revision causing the regression:

5e2ed6bfe94eb322efe891c07aa8e58b125f36c2 is first bad commit
commit 5e2ed6bfe94eb322efe891c07aa8e58b125f36c2
Author: Alexandre Julliard 
Date:   Wed Nov 5 20:32:32 2008 +0100

ntdll,server: Fixed access checks for OpenFileMapping and MapViewOfFile.

:040000 040000 2f0316597d54dc0ee871c80465dc4dac295a0f3e
3e9d23a0110f6767160cda3ad4aadaf376c3e508 M      dlls
:040000 040000 e3944bdf24bb46aad3b8266661b79d54336690aa
29feaf47301e9cd65d2c216e6bef96c0ad5612bf M      include
:040000 040000 04899ab2458e13db1c7a3357483bfef1b9123fcc
158732825f15930c0d3cdeaddfff4e36b75f3cb5 M      server

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #8 from Austin English   2009-01-10 20:21:51 ---
(In reply to comment #7)
> Alright, I've found the revision causing the regression:
>
> 5e2ed6bfe94eb322efe891c07aa8e58b125f36c2 is first bad commit
> commit 5e2ed6bfe94eb322efe891c07aa8e58b125f36c2
> Author: Alexandre Julliard 
> Date:   Wed Nov 5 20:32:32 2008 +0100
> ntdll,server: Fixed access checks for OpenFileMapping and MapViewOfFile.
>
> :040000 040000 2f0316597d54dc0ee871c80465dc4dac295a0f3e
> 3e9d23a0110f6767160cda3ad4aadaf376c3e508 M      dlls
> :040000 040000 e3944bdf24bb46aad3b8266661b79d54336690aa
> 29feaf47301e9cd65d2c216e6bef96c0ad5612bf M      include
> :040000 040000 04899ab2458e13db1c7a3357483bfef1b9123fcc
> 158732825f15930c0d3cdeaddfff4e36b75f3cb5 M      server

Are you sure? Have you tried without that patch? Looks like it'd be hard to
revert....try building one commit before that patch, and if it works, add that
patch, and make sure it breaks.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #9 from Jeremy Jackins   2009-01-10 21:36:20 ---
yep, I'm sure. it stops working for me exactly at that revision. I've also
narrowed it down a bit more, by reverting each of the modified files from the
broken revision to their state at the working revision, and the problem seems
to occur due to some small changes in server/trace.c, server/protocol.def, and
server/mapping.c.

It seems to have something to do with these "fixed access checks"

diffs:

diff --git a/server/mapping.c b/server/mapping.c
index 34fc6ce..f5df22f 100644
--- a/server/mapping.c
+++ b/server/mapping.c
@@ -562,7 +562,7 @@ DECL_HANDLER(get_mapping_info)
     struct fd *fd;

if ((mapping = (struct mapping *)get_handle_obj( current->process,
req->han
-                                                     0, &mapping_ops )))
+                                                     req->access |
SECTION_QUER
     {
         reply->size        = mapping->size;
         reply->protect     = mapping->protect;

---------------------

diff --git a/server/protocol.def b/server/protocol.def
index 0969330..bb7b47c 100644
--- a/server/protocol.def
+++ b/server/protocol.def
@@ -1351,6 +1351,7 @@ enum char_info_mode
 /* Get information about a file mapping */
 @REQ(get_mapping_info)
     obj_handle_t handle;        /* handle to the mapping */
+    unsigned int access;        /* wanted access rights */
 @REPLY
     file_pos_t   size;          /* mapping size */
     int          protect;       /* protection flags */

---------------------

diff --git a/server/trace.c b/server/trace.c
index 38cabcb..8b6e622 100644
--- a/server/trace.c
+++ b/server/trace.c
@@ -1769,7 +1769,8 @@ static void dump_open_mapping_reply( const struct
open_map

static void dump_get_mapping_info_request( const struct
get_mapping_info_reques
 {
-    fprintf( stderr, " handle=%p", req->handle );
+    fprintf( stderr, " handle=%p,", req->handle );
+    fprintf( stderr, " access=%08x", req->access );
 }

static void dump_get_mapping_info_reply( const struct get_mapping_info_reply
*r

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #10 from Jeremy Jackins   2009-01-11 12:39:11 ---
could someone mark this as a regression?

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

--- Comment #11 from Jeremy Jackins   2009-01-11 13:29:36 ---
Alright I've narrowed it down to the specific edit that causes the problem.
This is the change (in server/mapping.c):

if ((mapping = (struct mapping *)get_handle_obj( current->process, req->handle,
                                                     0, &mapping_ops )))
    {

became

if ((mapping = (struct mapping *)get_handle_obj( current->process, req->handle,
                                                     req->access |
SECTION_QUERY, &mapping_ops )))
    {

to see for yourself, notice that the bug persists in the latest git version of
wine, but if you run the command git checkout
f9283437c98df89f91ec7a49342a4c88c7ef3f3 server/mapping.c, which reverts the
file to it's state in the revision immediately before this bug existed, it
works perfectly.

Can someone tell me where to go from here? Should I wait for a developer to
notice this? Should I create a patch that reverts the line, and submit it? I am
very new to this.

Also, sorry if I've been spamming anyones inbox with these comments.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #12 from Austin English   2009-01-11 14:01:47 ---
You can submit a patch, but I don't know if Alexandre would accept it, as the
server code is very very sensitive to regressions.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Diver  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Marcus Better  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |wineserver
   Target Milestone|---                         |1.2.0

--- Comment #13 from Dan Kegel   2009-01-28 06:40:39 ---
Setting category to wineserver
Regression, popular app, well identified cause -> nominating for 1.2

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Alexandre Julliard   2009-05-20 08:33:21 ---
Should be fixed by d5d0738fb9f87f2c01c172d1653158444f520efa.

[Bug 16363] Google Chrome window is rendered totally black.

http://bugs.winehq.org/show_bug.cgi?id=16363

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2009-05-22 11:13:52 ---
Closing bugs fixed in 1.1.22.