https://bugs.winehq.org/show_bug.cgi?id=42538
Bug ID: 42538 Summary: wined3d checks for a wrong GL_VENDOR in wined3d_guess_gl_vendor Product: Wine Version: 2.2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: kamil.hornicek@reactos.org Distribution: ---
The check >if (strstr(gl_vendor_string, "Mesa")< in wined3d/directx.c:1729 is wrong. Mesa presents itself with GL_VENDOR = "Brian Paul" and GL_RENDERER = "Mesa" as can be seen here: https://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/getstring.c#n115
Even though the code works because it later checks for GL_RENDERER == "Mesa" it still should be fixed. This was also previously fixed in wined3d_guess_card_vendor.
https://bugs.winehq.org/show_bug.cgi?id=42538
--- Comment #1 from Henri Verbeet hverbeet@gmail.com --- Is this causing an actual issue, or is this theoretical? It's true that the default implementation returns "Brian Paul"/"Mesa", but specific drivers can and do return their own strings for this. These strings have also changed between versions.
https://bugs.winehq.org/show_bug.cgi?id=42538
Kamil Hornicek kamil.hornicek@reactos.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |other
--- Comment #2 from Kamil Hornicek kamil.hornicek@reactos.org --- At first let me apologize for forgetting to set the right OS. It should read ReactOS. In our case it's not theoretical. Second - GL_VENDOR is set to "Brian Paul" since at least 2005 as you can see here https://cgit.freedesktop.org/mesa/mesa/commit/src/mesa/main/getstring.c?id=1... and you are already checking for the correct vendor in wined3d_guess_card_vendor.
Would it be possible to add yet another check for GL_VENDOR == Brian Paul as was done in wined3d_guess_card_vendor a while ago? I realize that it doesn't really fix or improve anyting for you, but at least your code would be consistent. If not, thanks for your time anyway.
https://bugs.winehq.org/show_bug.cgi?id=42538
--- Comment #3 from Henri Verbeet hverbeet@gmail.com --- (In reply to Kamil Hornicek from comment #2)
Would it be possible to add yet another check for GL_VENDOR == Brian Paul as was done in wined3d_guess_card_vendor a while ago? I realize that it doesn't really fix or improve anyting for you, but at least your code would be consistent. If not, thanks for your time anyway.
Sure, adding an explicit check for GL_VENDOR "Brian Paul" is fine. I initially read the bug report as asking for the removal of the GL_VENDOR "Mesa" check, which I think would be more problematic. I'm still curious what set of GL_VENDOR and GL_RENDERER strings causes an issue here though.
https://bugs.winehq.org/show_bug.cgi?id=42538
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@baikal.ru, | |erich.e.hoover@wine-staging | |.com, michael@fds-team.de, | |sebastian@fds-team.de Status|UNCONFIRMED |STAGED Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wined3d-wined3 | |d_guess_gl_vendor Ever confirmed|0 |1
https://bugs.winehq.org/show_bug.cgi?id=42538
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/wined3d-wined3 |er/patches/wined3d-wined3d_ |d_guess_gl_vendor |guess_gl_vendor
-
wine-bugs＠winehq.org