[Bug 21949] New: Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Summary: Verbose the d3d vertices processing code
           Product: Wine
           Version: 1.1.40
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

As of Wine 1.1.40, the vertices processing is still not perfect (See bug
19888). Thus, it may be reasonable to make the output more verbose for
unhandled cases.
Related code is located in:
./dlls/ddraw/executebuffer.c:492
named

ERR("Unhandled vertex processing !\n");

That is definitely not enough in order to debug. A good start is to add the
output of "ci->dwFlags" in there as well. It is surely a minor enhancement, but
it is really annoying to recompile the whole Wine because of a small line.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Dmitry Timoshkov   2010-03-07 03:05:06 ---
That's not a bug. If you are a developer feel free to add the required traces
for your own needs.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
          Component|directx-ddraw               |-unknown

--- Comment #2 from Dmitry Timoshkov   2010-03-07 03:05:22 ---
Closing invalid.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

--- Comment #3 from Henri Verbeet   2010-03-07 03:12:42 ---
Created an attachment (id=26660)
 --> (http://bugs.winehq.org/attachment.cgi?id=26660)
patch

Yeah, though in this case I think it's a reasonable request. Does the attached
patch work for you?

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

--- Comment #4 from [e-mail]  2010-03-07 04:47:57 ---
(In reply to comment #1)
> That's not a bug. If you are a developer feel free to add the required traces
> for your own needs.

Yep, it is not a bug. I thought "enhancement" is a good measure of importance
for this. I can't understand the problem.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

--- Comment #5 from [e-mail]  2010-03-07 04:51:31 ---
(In reply to comment #3)
> Created an attachment (id=26660)

--> (http://bugs.winehq.org/attachment.cgi?id=26660) [details]
> patch
>
> Yeah, though in this case I think it's a reasonable request. Does the attached
> patch work for you?

Surely it works. I've produced the same one myself, but I'd like to nominate
this miserable line of code into the mainline because as I've said before,
re-compiling Wine is pretty much time-demanding task.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
          Component|-unknown                    |directx-ddraw
         Resolution|INVALID                     |

--- Comment #6 from Vitaliy Margolen   2010-03-07 16:56:05 ---
Dmitry, not all bugzilla bugs have to be bugs.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

--- Comment #7 from Henri Verbeet   2010-03-15 13:07:55 ---
Committed as ae437ab5b8f10db2f67a8cf7853c962e37800779.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Austin English   2010-03-15 13:22:40 ---
Fixed.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2010-03-19 14:10:59 ---
Closing bugs fixed in 1.1.41.

[Bug 21949] Verbose the d3d vertices processing code

http://bugs.winehq.org/show_bug.cgi?id=21949

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d