http://bugs.winehq.org/show_bug.cgi?id=17764
Summary: Cannot use "Edit in Edit image window" in Canon DPP Product: Wine Version: 1.1.15 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: theholyettlz@googlemail.com
Created an attachment (id=19986) --> (http://bugs.winehq.org/attachment.cgi?id=19986) Backtrace
On Canon DPP 3.5.1 (and prior versions, I believe it started with a Wine update although I cannot remember which), using "Edit in Edit image window" in DPPViewer.exe (select one or more images, click View, Edit in Edit image window) results in the main window disappearing. DPPEditor.exe is started (as it should be, this produced the Edit image window) but for some reason is not displayed. Killing it results in the reappearance of the DPPViewer.exe window.
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #1 from Austin English austinenglish@gmail.com 2009-03-22 12:03:36 --- (In reply to comment #0)
Created an attachment (id=19986)
--> (http://bugs.winehq.org/attachment.cgi?id=19986) [details]
Backtrace
There's no backtrace there...It doesn't crash, does it? Just exits prematurely.
On Canon DPP 3.5.1 (and prior versions, I believe it started with a Wine update although I cannot remember which)
If so, run a regression test: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=17764
Carlo Pannucci carlo.pannucci@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.pannucci@gmail.com
--- Comment #2 from Carlo Pannucci carlo.pannucci@gmail.com 2009-05-16 09:02:38 --- Confirmed on wine 1.1.21
When you click on the button the following line appears in the terminal:
fixme:win:GetWindowPlacement not supported on other process window 0x10032
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #3 from Ken Sharp kennybobs@o2.co.uk 2009-06-25 07:22:33 --- *** Bug 19060 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=17764
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Severity|enhancement |normal
--- Comment #4 from Ken Sharp kennybobs@o2.co.uk 2009-06-25 07:24:28 --- Still waiting for a regression test!
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #5 from Carlo Pannucci carlo.pannucci@gmail.com 2009-06-25 08:08:39 --- (In reply to comment #4)
Still waiting for a regression test!
I'd like to do it but i don't know a good wine version (if there's one!)
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com 2009-06-25 08:14:19 --- (In reply to comment #5)
(In reply to comment #4)
Still waiting for a regression test!
I'd like to do it but i don't know a good wine version (if there's one!)
Just start with 1.1.14 (appdb shows it gold) and go one tagged version back to find out.
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #7 from Carlo Pannucci carlo.pannucci@gmail.com 2009-06-25 09:25:25 --- (In reply to comment #6)
(In reply to comment #5)
(In reply to comment #4)
Still waiting for a regression test!
I'd like to do it but i don't know a good wine version (if there's one!)
Just start with 1.1.14 (appdb shows it gold) and go one tagged version back to find out.
Ok. I've tried to have a regression test following the instructions here -> http://wiki.winehq.org/RegressionTesting and using these settings:
git bisect good wine-1.1.14 git bisect bad wine-1.1.15
When i try to start the program i can read the following lines in the terminal and nothing else happens:
fixme:system:SetProcessDPIAware stub! fixme:dwmapi:DwmIsCompositionEnabled 0x33cf94 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\smime3.dll") - Symbol NSGetModule not found fixme:iphlpapi:NotifyAddrChange (Handle 0x7cd96888, overlapped 0x7cd96890): stub 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\plc4.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\sqlite3.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\softokn3.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\plds4.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\nssdbm3.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\nssckbi.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\nspr4.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\xul.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\xpcom.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\freebl3.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\ssl3.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\nss3.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\plugins\npnul32.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\js3250.dll") - Symbol NSGetModule not found 0[7485c0]: nsNativeModuleLoader::LoadModule("C:\windows\gecko\0.9.1\wine_gecko\nssutil3.dll") - Symbol NSGetModule not found fixme:shell:DllCanUnloadNow stub wine: configuration in '/home/carlo/.wine' has been updated.
Is there something wrong in my test or the program it's incompatible with the wine version tested?
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2009-06-25 09:34:07 --- (In reply to comment #7)
Ok. I've tried to have a regression test following the instructions here -> http://wiki.winehq.org/RegressionTesting and using these settings:
git bisect good wine-1.1.14 git bisect bad wine-1.1.15
Are you sure it's really good? First of all you have to find a good version. Rebase to 1.1.14 and rebuild it fully:
--- ./configure && make depend && make install ---
If it doesn't work for 1.1.14 go further to 1.1.13 etc.
When i try to start the program i can read the following lines in the terminal and nothing else happens:
It's wine-gecko related output.
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #9 from James theholyettlz@googlemail.com 2009-06-26 16:52:48 --- OK, I've been poring back through older Wine builds in the Fedora Koji. A number of the older builds have been deleted, but the last one I found that works is 0.9.56. Something happened between there 0.9.58, which is where this stops working for me.
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #10 from Carlo Pannucci carlo.pannucci@gmail.com 2009-06-29 05:55:59 --- (In reply to comment #9)
OK, I've been poring back through older Wine builds in the Fedora Koji. A number of the older builds have been deleted, but the last one I found that works is 0.9.56. Something happened between there 0.9.58, which is where this stops working for me.
I've tried to do a regression test but i had compilation problems: as the guide says "Note that old wine versions can give trouble compiling because of changes to freetype, http://www.winehq.org/pipermail/wine-patches/2008-September/060764.html explains this and has a patch. " but i don't understand where is the patch and how apply it...
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #11 from Austin English austinenglish@gmail.com 2009-06-29 08:49:45 --- (In reply to comment #10)
(In reply to comment #9)
OK, I've been poring back through older Wine builds in the Fedora Koji. A number of the older builds have been deleted, but the last one I found that works is 0.9.56. Something happened between there 0.9.58, which is where this stops working for me.
I've tried to do a regression test but i had compilation problems: as the guide says "Note that old wine versions can give trouble compiling because of changes to freetype, http://www.winehq.org/pipermail/wine-patches/2008-September/060764.html explains this and has a patch. " but i don't understand where is the patch and how apply it...
The patch is at the lower part of that page, starting with 'diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c'.
See: http://wiki.winehq.org/Patching
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #12 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-01 04:18:52 ---
The patch is at the lower part of that page, starting with 'diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c'.
I've patched succesfully but now i've an other compilation problem:
signal_i386.c: In function ‘merge_vm86_pending_flags’: signal_i386.c:544: error: ‘VIF_MASK’ undeclared (first use in this function) signal_i386.c:544: error: (Each undeclared identifier is reported only once signal_i386.c:544: error: for each function it appears in.) signal_i386.c:555: error: ‘VIP_MASK’ undeclared (first use in this function) signal_i386.c: In function ‘raise_vm86_sti_exception’: signal_i386.c:1214: error: ‘VIP_MASK’ undeclared (first use in this function) signal_i386.c: In function ‘__wine_enter_vm86’: signal_i386.c:1614: error: ‘VIF_MASK’ undeclared (first use in this function) signal_i386.c:1615: error: ‘VIP_MASK’ undeclared (first use in this function) make[2]: *** [signal_i386.o] Errore 1 make[2]: uscita dalla directory «/home/carlo/wine-git/dlls/ntdll» make[1]: *** [ntdll] Errore 2 make[1]: uscita dalla directory «/home/carlo/wine-git/dlls» make: *** [dlls] Errore 2
Procedure followed:
1)Patched following the guide 2)./configure 3)make depend && make 4)error
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #13 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-06 05:00:34 --- (In reply to comment #12)
The patch is at the lower part of that page, starting with 'diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c'.
I've patched succesfully but now i've an other compilation problem:
signal_i386.c: In function ‘merge_vm86_pending_flags’: signal_i386.c:544: error: ‘VIF_MASK’ undeclared (first use in this function) signal_i386.c:544: error: (Each undeclared identifier is reported only once signal_i386.c:544: error: for each function it appears in.) signal_i386.c:555: error: ‘VIP_MASK’ undeclared (first use in this function) signal_i386.c: In function ‘raise_vm86_sti_exception’: signal_i386.c:1214: error: ‘VIP_MASK’ undeclared (first use in this function) signal_i386.c: In function ‘__wine_enter_vm86’: signal_i386.c:1614: error: ‘VIF_MASK’ undeclared (first use in this function) signal_i386.c:1615: error: ‘VIP_MASK’ undeclared (first use in this function) make[2]: *** [signal_i386.o] Errore 1 make[2]: uscita dalla directory «/home/carlo/wine-git/dlls/ntdll» make[1]: *** [ntdll] Errore 2 make[1]: uscita dalla directory «/home/carlo/wine-git/dlls» make: *** [dlls] Errore 2
Procedure followed:
1)Patched following the guide 2)./configure 3)make depend && make 4)error
The problem in compiling is due to the old version i wanted to compile on ubuntu 9.04. Following instructions on http://osdir.com/ml/wine-users/2009-06/msg00280.html i've successfull compiled wine and for me the 0.9.56 wine version gives the same error (fixme:win:GetWindowPlacement not supported on other process window 0x10026).
For james 0.9.56 is functional.. how could it be?
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #14 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-07 05:57:40 --- Still here in 1.1.25
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #15 from James theholyettlz@googlemail.com 2009-07-07 06:18:43 --- (In reply to comment #13)
For james 0.9.56 is functional.. how could it be?
Have you tried using the sources from the Fedora Koji in http://kojipkgs.fedoraproject.org/packages/wine/0.9.56/1.fc9/src/wine-0.9.56... ? I don't think they patch anything beyond distro-specific integration, but you never know...
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #16 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-07 13:32:23 --- Ok. It should be my mistake...
For sure wine-0.9.56 it's the lastest functional version. The bug appears with wine-0.9.57.
I tried to have a regression test. These were my steps, after installing git:
1. git bisect start 2. git bisect good 0.9.56 3. git bisect bad 0.9.57 4. patches: 4.1: Created a patch.diff file with the path in http://www.winehq.org/pipermail/wine-patches/2008-September/060764.html and then i used the line "patch -p1 < patch.diff" 4.2: Manually edited the signal_i386.c file adding this two lines at the begining: #define VIF_MASK 0x00080000 #define VIP_MASK 0x00100000 5. ./configure && make depend && make 6. Tested the bug -> Not present 7. git bisect good 8. I have this: "error: You have local changes to 'dlls/gdi32/freetype.c'; cannot switch branches" 9. Tried git reset --hard HEAD BUT the it wont compile...
What should i do??1?
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #17 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-08 05:48:32 --- (In reply to comment #16)
Ok. It should be my mistake...
For sure wine-0.9.56 it's the lastest functional version. The bug appears with wine-0.9.57.
I tried to have a regression test. These were my steps, after installing git:
- git bisect start
- git bisect good 0.9.56
- git bisect bad 0.9.57
- patches: 4.1: Created a patch.diff file with the path in
http://www.winehq.org/pipermail/wine-patches/2008-September/060764.html and then i used the line "patch -p1 < patch.diff" 4.2: Manually edited the signal_i386.c file adding this two lines at the begining: #define VIF_MASK 0x00080000 #define VIP_MASK 0x00100000 5. ./configure && make depend && make 6. Tested the bug -> Not present 7. git bisect good 8. I have this: "error: You have local changes to 'dlls/gdi32/freetype.c'; cannot switch branches" 9. Tried git reset --hard HEAD BUT the it wont compile...
What should i do??1?
DONE. To continue you have to apply the patches...
This is the result:
accfce21d3e042638a5eac8a8379eda2964fcd0a is first bad commit commit accfce21d3e042638a5eac8a8379eda2964fcd0a Author: Alexandre Julliard julliard@winehq.org Date: Tue Mar 4 20:01:41 2008 +0100
user32: Fix a couple of message test failures.
:040000 040000 e88dab46f42c141f65d73dc50fd497c6facdec62 301e659a8982251ea07164eaa96f15992bd06dc9 M dlls
http://bugs.winehq.org/show_bug.cgi?id=17764
Carlo Pannucci carlo.pannucci@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #18 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-08 05:52:36 --- Because i added Alexandre Julliard after the previous message i repost the result to send it to him:
accfce21d3e042638a5eac8a8379eda2964fcd0a is first bad commit commit accfce21d3e042638a5eac8a8379eda2964fcd0a Author: Alexandre Julliard julliard@winehq.org Date: Tue Mar 4 20:01:41 2008 +0100
user32: Fix a couple of message test failures.
:040000 040000 e88dab46f42c141f65d73dc50fd497c6facdec62 301e659a8982251ea07164eaa96f15992bd06dc9 M dlls
I think the status should not be "unconfirmed" now.
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #19 from Carlo Pannucci carlo.pannucci@gmail.com 2009-07-08 05:55:58 --- Sorry for my multiple posts.. I forgot to say that even when the bug isn't present you can read the "fixme:win:GetWindowPlacement not supported on other process window..." line.
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #20 from Carlo Pannucci carlo.pannucci@gmail.com 2009-10-23 16:09:43 --- Nearly 4 months have passed from my regression test and no answers yet... Did i commit some communication mistake? (and so no developer received a notification?)
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #21 from Carlo Pannucci carlo.pannucci@gmail.com 2009-10-23 16:15:57 ---
Nearly 4 months have passed from my regression test and no answers yet... Did i >commit some communication mistake? (and so no developer received a notification?)
For example, following instructions i added x to cc list but when i send comments i can read:
Changes submitted for bug 17764
Email sent to: wine-bugs@winehq.org, theholyettlz@googlemail.com Excluding: julliard@winehq.org, carlo.pannucci@gmail.com
...so won't he receive this message (and he didn't receive the regression test message...) ???
http://bugs.winehq.org/show_bug.cgi?id=17764
Paul Romanyszyn pgr@arcelectronicsinc.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pgr@arcelectronicsinc.com
--- Comment #22 from Paul Romanyszyn pgr@arcelectronicsinc.com 2009-10-23 16:31:14 --- (In reply to comment #21)
Excluding: julliard@winehq.org, carlo.pannucci@gmail.com
...so won't he receive this message (and he didn't receive the regression test message...) ???
Some people monitor all the bugs without being on the CC list.
Does reverting the changes from commit accfce21d3e042638a5eac8 related to winpos.c on the current git fix the problem?
http://bugs.winehq.org/show_bug.cgi?id=17764
piwacet davrosmeglos@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davrosmeglos@gmail.com
--- Comment #23 from piwacet davrosmeglos@gmail.com 2009-11-01 19:15:48 --- I apologize if I'm spamming this bugtracker, as I don't know much about computers and am not a programmer, but I do believe reversing commit accfce21d3e042638a5eac8a8379eda2964fcd0a fixes this problem, based on the following:
For the last year or two I have been using the patch below, which essentially reverses the changes to winpos.c made by the above commit, in my local gentoo build system, and it has fixed this problem for all wine builds that I have used. I'm currently using 1.1.32 with this patch, and "Edit in Edit Image Window" works perfectly. I can't say if it breaks other things as DPP is the only program I use under wine.
cat DPP.winpos.c.patch --- wine-*/dlls/user32/winpos.c.old 2008-09-05 08:28:27.000000000 -0700 +++ wine-*/dlls/user32/winpos.c 2008-09-09 19:41:26.000000000 -0700 @@ -985,7 +985,8 @@ if (!wasVisible) return FALSE; showFlag = FALSE; swp |= SWP_HIDEWINDOW | SWP_NOSIZE | SWP_NOMOVE; - if (style & WS_CHILD) swp |= SWP_NOACTIVATE | SWP_NOZORDER; + if (hwnd != GetActiveWindow()) + swp |= SWP_NOACTIVATE | SWP_NOZORDER; break;
case SW_SHOWMINNOACTIVE: @@ -1036,8 +1037,6 @@ } if (style & WS_CHILD && !(swp & SWP_STATECHANGED)) swp |= SWP_NOACTIVATE | SWP_NOZORDER; break; - default: - return wasVisible; }
if ((showFlag != wasVisible || cmd == SW_SHOWNA) && cmd != SW_SHOWMAXIMIZED && !(swp & SWP_STATECHANGED))
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #24 from Carlo Pannucci carlo.pannucci@gmail.com 2009-11-05 07:09:50 --- (In reply to comment #23)
I apologize if I'm spamming this bugtracker, as I don't know much about computers and am not a programmer, but I do believe reversing commit accfce21d3e042638a5eac8a8379eda2964fcd0a fixes this problem, based on the following:
For the last year or two I have been using the patch below, which essentially reverses the changes to winpos.c made by the above commit, in my local gentoo build system, and it has fixed this problem for all wine builds that I have used. I'm currently using 1.1.32 with this patch, and "Edit in Edit Image Window" works perfectly. I can't say if it breaks other things as DPP is the only program I use under wine.
So your message confirm my regression test.. we have only to wait for a fix (or patch wine!)
http://bugs.winehq.org/show_bug.cgi?id=17764
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32
http://bugs.winehq.org/show_bug.cgi?id=17764
BlackSir blacksir@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blacksir@gmail.com
--- Comment #25 from BlackSir blacksir@gmail.com 2010-05-07 04:14:06 --- I confirm patched user32.dll.so works well with wine-1.1.31 and Canon DPP 3.8. Thanks Piwacet!
This is the link to the problematic commit: http://is.gd/bYfnF
http://bugs.winehq.org/show_bug.cgi?id=17764
ghalas@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #26 from ghalas@wp.pl 2010-07-23 07:49:55 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=17764
Lukas Jirkovsky l.jirkovsky@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |l.jirkovsky@gmail.com
--- Comment #27 from Lukas Jirkovsky l.jirkovsky@gmail.com 2010-07-31 03:12:56 --- I can confirm that the bug is still present in wine 1.3.0
http://bugs.winehq.org/show_bug.cgi?id=17764
--- Comment #28 from piwacet davrosmeglos@gmail.com 2010-08-30 17:36:53 CDT --- With wine 1.3.1 and DPP 3.8.1 this problem is fixed for me by the patch linked to in comment #43 in this bug (#12001):
http://bugs.winehq.org/show_bug.cgi?id=12001
Specifically, the following patch fixes this problem for me:
http://www.winehq.org/pipermail/wine-patches/2010-August/092661.html
http://bugs.winehq.org/show_bug.cgi?id=17764
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dank@kegel.com Resolution| |DUPLICATE
--- Comment #29 from Dan Kegel dank@kegel.com 2010-08-31 00:39:18 CDT --- Resolving dup, then.
*** This bug has been marked as a duplicate of bug 12001 ***
http://bugs.winehq.org/show_bug.cgi?id=17764
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #30 from Dmitry Timoshkov dmitry@codeweavers.com 2010-08-31 02:56:13 CDT --- Closing duplicate.