https://bugs.winehq.org/show_bug.cgi?id=42110
Bug ID: 42110 Summary: regression: commit "xinput1_3 prefer builtin dll" aliens versus predator classic 2000 (steam) fails to launch Product: Wine Version: 1.9.23 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: xinput Assignee: wine-bugs@winehq.org Reporter: o.dierick@piezo-forte.be Distribution: ---
aliens versus predator classic 2000 (steam) fails to launch with this commit: --- commit 4b09e848b8867683007f4c90ac589b43dfdc5707 Author: Bruno Jesus 00cpxxx@gmail.com Date: Sat Oct 29 23:13:25 2016 -0200
xinput1_3: Prefer builtin DLL. ---
Reverting the commit fix the issue.
wine output with bad commit has this line: --- fixme:xinput:XInputGetCapabilities (index 3, flags 0x1, capabilities 0x33ee84) Stub! ---
wine output with commit reverted has this line twice: --- err:module:find_forwarded_export function not found for forward 'xinput1_3.XInputGetStateEx' used by L"C:\windows\system32\xinput1_4.dll". If you are using builtin L"xinput1_4.dll", try using the native one instead. ---
32 bit wineprefix, no dll overrides. winetricks corefonts used.
https://bugs.winehq.org/show_bug.cgi?id=42110
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Debian Keywords| |regression Regression SHA1| |4b09e848b8867683007f4c90ac5 | |89b43dfdc5707
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com --- Have you tested in 2.0-rcX ? This is supposed to be fixed.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #2 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- (In reply to Bruno Jesus from comment #1)
Have you tested in 2.0-rcX ? This is supposed to be fixed.
Yes, forgot to tell about that. I tested the game with each release to see if it got fixed and it did not. I decided to make a regression test because it is still present in 2.0-rc3.
https://bugs.winehq.org/show_bug.cgi?id=42110
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #3 from Bruno Jesus 00cpxxx@gmail.com --- Please attach a +loaddll,+xinput for working and now working cases. I have no idea at the moment, maybe steam has its own xinput and that is conflicting somehow.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #4 from Bruno Jesus 00cpxxx@gmail.com --- The game is on sale so I bought it, unfortunately it runs here so the logs are still required.
https://bugs.winehq.org/show_bug.cgi?id=42110
Robert Walker bob.mt.wya@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya@gmail.com
--- Comment #5 from Robert Walker bob.mt.wya@gmail.com --- Ditto... I can't reproduce this bug either - with wine 2.0-rc3. The game seems to be running fine here...
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #6 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 56650 --> https://bugs.winehq.org/attachment.cgi?id=56650 not working +loaddll,+xinput output
I restarted from scratch.
Compiled 3 wine: - release 2.0-rc3. - release 2.0-rc3 + bad commit reverted. - current git.
Made 3 new wineprefix, one for each build, with these common settings: - 32-bit; - virtual desktop to my fullscreen resolution; - no window decoration; - no window manager; - capture mouse in fullscreen directx apps; - all five userdirs offset to a subdir of $HOME (i.e. /home/olivier/Wine/[Documents,Pictures,Videos,Music,Desktop]) - user name and company name filled in the last winecfg tab; - winetricks corefonts used;
Then I repeated these steps with each prefix, one at a time, using the proper wine build: - Copied Steam.exe, app_manifest file and game folder from steamapps/common in the 3 prefixes from the same source. - Started Steam.exe with -no-cef-sandbox and let it update, register my account, validate code, quit. - Restarted Steam added -unlimitedsaves to the game startup options, then start the game and let it install dependencies. - Clicked the green button "play with steam only". - This is when the issue occurs. The game does start only when the build with the revert is used.
I restarted Steam and launched the game to make the +loaddll,+xinput logs without the steam update/install stuff.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #7 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 56651 --> https://bugs.winehq.org/attachment.cgi?id=56651 working +loaddll,+xinput output
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #8 from Robert Walker bob.mt.wya@gmail.com --- I can't reproduce this bug - with vanilla wine 1.9.23.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #9 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- I tried to detach my controllers (usb gamepad and usb wheel), makes no difference.
I'm wondering if my kernel is too old. It's Debian Wheezy 3.2.0-4-amd64.
This kernel lacks support for named pipes and support for the gcc force-alignment option, though I can't see how that relates to the commit.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #10 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- I just retested with wine-staging 2.0-rc3 from the repos, in case my builds were at fault, and the issue is there too.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #11 from Bruno Jesus 00cpxxx@gmail.com --- Is there any game error in the screen? I can't find any explanation for the game to not run.
Can you try setting xinput1_3.dll to native only?
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #12 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 56660 --> https://bugs.winehq.org/attachment.cgi?id=56660 native xinput1_3 +loaddll,+xinput output
(In reply to Bruno Jesus from comment #11)
Is there any game error in the screen? I can't find any explanation for the game to not run.
Can you try setting xinput1_3.dll to native only?
Setting xinput1_3.dll to native does workaround the issue. The log is similar to the one with the revert.
There is no visual indication to the error. The launcher just closes after pressing the green button. The game status in Steam goes from running to not running.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #13 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 56661 --> https://bugs.winehq.org/attachment.cgi?id=56661 crash dump from the game
I looked for logs in the game folder and found none, but there are crash dumps corresponding to the failures. These are .mdmp files.
I don't know how to handle them so I attached the latest dump, in case someone else can get something out of it.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #14 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Well, I thought that I would find where the crash occurs with a +relay log, but the game starts just fine with it!
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #15 from Bruno Jesus 00cpxxx@gmail.com --- Are you using any tool to get xinput support? (like x360ce)
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #16 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- (In reply to Bruno Jesus from comment #15)
Are you using any tool to get xinput support? (like x360ce)
Not that I know of. I never bothered about xinput before.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #17 from Bruno Jesus 00cpxxx@gmail.com --- Created attachment 56732 --> https://bugs.winehq.org/attachment.cgi?id=56732 debug patch
Please get a +module,+loaddll,+tid,+xinput with the attached patch.
https://bugs.winehq.org/show_bug.cgi?id=42110
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #56661|0 |1 is obsolete| |
--- Comment #18 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 56733 --> https://bugs.winehq.org/attachment.cgi?id=56733 winedbg minidump output
Hi,
I could open the minidump file with winedbg and saw that the crash was in XInputEnable() called by gameoverlayrenderer.dll.
I disabled gameoverlayrenderer in winecfg and the game started fine with builtin xinput1_3.
Then I looked for gameoverlayrenderer bugs on winehq.org and found bug 32658 that was similar except it crashed in XInputSetState().
I made a patch similar to the one that fixed bug 32658 and it fixed the issue.
As stated in that bug, it's probably a compiler bug. My gcc version is 4.7.2 too.
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #19 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Created attachment 56734 --> https://bugs.winehq.org/attachment.cgi?id=56734 patch Add DECLSPEC_HOTPATCH to XInputEnable()
https://bugs.winehq.org/show_bug.cgi?id=42110
--- Comment #20 from Bruno Jesus 00cpxxx@gmail.com --- I'm glad to hear that. Probably it does not crash with native because it does that, but I don't know how to check that. Anyway, I guess you can send your patch to wine-patches as it fixes the issue for you.
https://bugs.winehq.org/show_bug.cgi?id=42110
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |1640c9ce623ba00e52c197a3165 | |0d4dfa9d7bde7
--- Comment #21 from Bruno Jesus 00cpxxx@gmail.com --- Thank you very much for reporting, researching and fixing this =)
http://source.winehq.org/git/wine.git/commitdiff/1640c9ce623ba00e52c197a3165...
https://bugs.winehq.org/show_bug.cgi?id=42110
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #22 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.0-rc5.
https://bugs.winehq.org/show_bug.cgi?id=42110
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x
https://bugs.winehq.org/show_bug.cgi?id=42110
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |---
--- Comment #23 from Michael Stefaniuc mstefani@redhat.com --- Removing 1.8.x milestone from bugs included in 1.8.7.