[Bug 20335] New: Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

Summary: Uninitialised memory reference in
                    X11DRV_DIB_SetImageBits()
           Product: Wine
           Version: 1.1.31
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I think this is one of the first valgrind warnings
I ever ran into in wine, and it's still here.
Nowadays Wine gives better warnings, so it's a little
easier to see where these are coming from.

Running chromium's base_unittests.exe (and probably
lots of other apps) in valgrind yields this warning:

Conditional jump or move depends on uninitialised value(s)
   at XcursorImageHash (xlib.c:294)
   by XcursorNoticePutBitmap (xlib.c:365)
   by _XNoticePutBitmap (CrGlCur.c:202)
   by XPutImage (PutImage.c:1042)
   by X11DRV_DIB_SetImageBits (dib.c:3670)
   by X11DRV_SetDIBits (dib.c:4040)
   by SetDIBits (dib.c:361)
   ...
 Uninitialised value was created by a client request
   at RtlAllocateHeap (heap.c:187)
   by X11DRV_DIB_SetImageBits (dib.c:3543)
   by X11DRV_SetDIBits (dib.c:4040)
   by SetDIBits (dib.c:361)
   ...

Presumably adding HEAP_ZERO_MEMORY to the allocation
at dib.c:3543 would do the job, but maybe there's a
smarter way.

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

--- Comment #1 from Alexandre Julliard   2009-10-12 12:34:02 ---
It sounds like it's hashing padding bytes. Probably should be reported to the
X.org folks.

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

--- Comment #2 from Dan Kegel   2010-08-09 22:27:11 ---
Looks like Austin Lund noticed this, too:
http://www.winehq.org/pipermail/wine-patches/2010-August/091903.html

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

--- Comment #3 from Austin English   2010-08-16 23:18:32 ---
(In reply to comment #1)
> It sounds like it's hashing padding bytes. Probably should be reported to the
> X.org folks.

X.org bug filed:
https://bugs.freedesktop.org/show_bug.cgi?id=29600

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

Julian Seward  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Julian Seward  2010-10-25 04:37:23 CDT ---
Still alive and well in 1.2.1.

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

--- Comment #5 from Austin English  2011-01-13 10:17:39 CST ---
Still in

austin@midna:~/2011-01-12-18$ X -version

X.Org X Server 1.9.0
Release Date: 2010-08-20
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.24-28-server x86_64 Ubuntu
Current Operating System: Linux midna 2.6.35-24-generic #42-Ubuntu SMP Thu Dec
2 02:41:37 UTC 2010 x86_64
Kernel command line: root=UUID=e1074dbb-7170-4709-b092-f49b773a2898 ro quiet
splash 
Build Date: 09 January 2011  12:14:27PM
xorg-server 2:1.9.0-0ubuntu7.3 (For technical support please see
http://www.ubuntu.com/support) 
Current version of pixman: 0.18.4
    Before reporting problems, check http://wiki.x.org
    to make sure that you have the latest version.

wine-1.3.11-151-geb11dee

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

http://bugs.winehq.org/show_bug.cgi?id=20335

--- Comment #6 from [e-mail] 2013-08-05 12:26:21 CDT ---
This ticket has not been updated for over 900 days. Development recommends
to check the status on your bug every release or two and let to be known if the
bug is still present. If not, mark it fixed.

Is this still an issue with 1.7.0 or higher ?

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

https://bugs.winehq.org/show_bug.cgi?id=20335

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
have you guys abandon this bug?

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

https://bugs.winehq.org/show_bug.cgi?id=20335

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #8 from Nikolay Sivov  ---
This was removed with
http://source.winehq.org/git/wine.git/commit/5b11c96fa129953b6059e9715851be2...,
so it no longer relevant.

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

https://bugs.winehq.org/show_bug.cgi?id=20335

--- Comment #9 from Bruno Jesus  ---
(In reply to Nikolay Sivov from comment #8)
> This was removed with
> http://source.winehq.org/git/wine.git/commit/
> 5b11c96fa129953b6059e9715851be2e9ec1d7f3, so it no longer relevant.

I think this is fixed then instead of wontfix.

[Bug 20335] Uninitialised memory reference in X11DRV_DIB_SetImageBits()

https://bugs.winehq.org/show_bug.cgi?id=20335

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Austin English  ---
Closing.