[Bug 51589] New: Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Bug ID: 51589
           Summary: Buttons have no icons when using the Light Blue theme
           Product: Wine-staging
           Version: 6.14
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

I noticed that buttons on the SUMo Update app have no icons on them after
setting the Wine theme to Light Blue in winecfg.

Steps to reproduce:

1. Set Wine theme to Light Blue using winecfg.
2. Download SUMo Update portable: https://www.kcsoftwares.com/files/sumo.zip
3. Run SUMo.exe
4. Notice the buttons have no icons

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

--- Comment #1 from Guilherme S.  ---
Created attachment 70437
  --> https://bugs.winehq.org/attachment.cgi?id=70437
No theme (correct)

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

--- Comment #2 from Guilherme S.  ---
Created attachment 70438
  --> https://bugs.winehq.org/attachment.cgi?id=70438
Light blue theme (incorrect)

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Zhiyi Zhang  ---
Confirmed with wine-staging git bdb9f49. The related patch is
comctl32-version_6. When the application detects that the comctl32 version is
6, it uses theming drawing, which eventually calls
an unimplemented function DrawThemeIcon(). With wine having version 5 in
comctl32, the application disables theming for its buttons.

I will look into implementing DrawThemeIcon() later if no one else takes this.

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

--- Comment #4 from Zhiyi Zhang  ---
Created attachment 70469
  --> https://bugs.winehq.org/attachment.cgi?id=70469
Implement DrawThemeIcon

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70469|0                           |1
        is obsolete|                            |

--- Comment #5 from Zhiyi Zhang  ---
Created attachment 70470
  --> https://bugs.winehq.org/attachment.cgi?id=70470
Implement DrawThemeIcon v2

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] ---
wasn't this fixed recently upstream?

https://source.winehq.org/patches/data/212376

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |ea430bf2b751c7a43328adf5daf
                   |                            |e22ac1c971fa6

--- Comment #7 from Zhiyi Zhang  ---
Fixed by ea430bf2b751c7a43328adf5dafe22ac1c971fa6

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |uxtheme
            Product|Wine-staging                |Wine

--- Comment #8 from Zebediah Figura  ---
I'm going to call this a bug in wine exposed by a wine-staging patch, and
change the product accordingly.

[Bug 51589] Buttons have no icons when using the Light Blue theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51589

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 7.0-rc2.