[Bug 9686] New: Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

Summary: Zork: Nemesis and Zork: Grand Inquisitor seem to have
                    applied incremental filter over static parts of screen
                    image
           Product: Wine
           Version: 0.9.45.
          Platform: PC
               URL: http://appdb.winehq.org/appview.php?iVersionId=6034
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: wine-opengl
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=8106)
 --> (http://bugs.winehq.org/attachment.cgi?id=8106)
Screen after few seconds of rendering

Hello
using the following Direct3D options, I've finally managed to run Zorks:
DirectDrawRenderer=opengl 
RenderTargetLockMode=readdraw

However, the screen render still is not 100%, it looks like there is some sort
of incremental filter for static parts of picture.

See the attached pictures for more info, see the link below for demo installer
and Installation HOWTO.

Demo download and Howto install:
http://wood.sandbox.cz/zork-grand-inquisitor/

Regards
Vit

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #1 from Vit Hrachovy   2007-09-16 15:26:25 ---
Created an attachment (id=8107)
 --> (http://bugs.winehq.org/attachment.cgi?id=8107)
Screen immediately after render

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

Vit Hrachovy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Vit Hrachovy   2007-09-17 15:56:27 ---
Hello,
the following change breaks the Zork engines to unplayable state again:

commit 3961491d15f64f10f583a974c2672a669c6f541a
Author: Stefan D<C3><B6>singer 
Date:   Fri Sep 14 17:46:19 2007 +0200

wined3d: Do not invalidate the sysmem copy if a pbo exists.

diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c

Regards
Vit

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #3 from Stefan Dösinger   2007-09-17 16:20:56 ---
It looks like the game didn't used to work, something "broke" it and made it
look better, now it is "correct" and broken again. Does that sound right, or do
I miss anything?

I think a bug in the first PBO patch cascaded a different bug, now the bug is
fixed and the original bug back. However, the hiding of the bug gives some
important information.

Can you describe the "unplayable state"?

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #4 from Vit Hrachovy   2007-09-18 01:02:48 ---
Hello Stefan,
I'm currently bisecting which patch enabled the game to work almost correctly
in 0.9.45.

"Broken" state means the game starts, but seems to flip buffered image over the
real one. At the game start it flips the black screen, then after each movie or
loading sequence the last frame is flipped. Movies are displayed correctly,
though.

The 0.9.45 state is that the screen image stays on, but within few seconds it's
"brightened" heavily - see the attached screenshots. Looks like ther's always
aplpying some filter over the current screen image.
Regards
Vit

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|wine-opengl                 |wine-directx-ddraw

--- Comment #5 from Roderick Colenbrander   2007-10-03 12:06:00 ---
Moved the bug to ddraw.

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #6 from Vit Hrachovy   2008-01-01 06:48:45 ---
In Wine 0.9.52 the error still persists. However, there is more info in debug
traces now:

fixme:imm:ImmGetDefaultIMEWnd (0x10024 - (nil) 0x13ddc0 ): semi-stub
fixme:imm:ImmGetOpenStatus (0x13ddc0): semi-stub
fixme:imm:ImmReleaseContext (0x10024, 0x13ddc0): stub
fixme:win:EnumDisplayDevicesW ((null),0,0x33f5a4,0x00000000), stub!
err:d3d_surface:IWineD3DSurfaceImpl_BltOverride Unexpected render target ->
render target blit
fixme:d3d:IWineD3DDeviceImpl_Release (0x153460) Device released with resources
still bound, acceptable but unexpected
fixme:d3d:dumpResources Leftover resource 0x151db8 with type
1,WINED3DRTYPE_SURFACE
err:d3d:IWineD3DDeviceImpl_Release Context array not freed!

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #7 from Vit Hrachovy   2008-01-01 07:04:06 ---
0.9.45 - incremental filter
0.9.46 - menu shows OK, saved game restoring is overdrawn by previous menu, in
game then there is black screen, then there blinks for one frame the game
picture quickly overdrawn by last static picture from movie 
0.9.47 - menu shows, but on the first mouse movement is replaced by black
screen,then there blinks for one frame the game picture quickly overdrawn by
last static picture from movie  
0.9.48 - same as 0.9.47
0.9.49 - same as 0.9.47
       - new trace 
                fixme:d3d:dumpResources Leftover resource 0x137b18 with type
1,WINED3DRTYPE_SURFACE
                err:d3d:IWineD3DDeviceImpl_Release Context array not freed!

0.9.50 - same as 0.9.49 
0.9.51 - same as 0.9.49
0.9.52 - same as 0.9.49
       - new trace
                err:d3d_surface:IWineD3DSurfaceImpl_BltOverride Unexpected
render target -> render target blit
                fixme:d3d:IWineD3DDeviceImpl_Release (0x153460) Device released
with resources still bound, acceptable but unexpected
                fixme:d3d:dumpResources Leftover resource 0x151db8 with type
1,WINED3DRTYPE_SURFACE
                err:d3d:IWineD3DDeviceImpl_Release Context array not freed!

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #8 from Vit Hrachovy   2008-01-12 11:29:34 ---
Still broken in 0.9.53.

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #9 from Vit Hrachovy   2008-04-19 03:18:25 ---
Still broken in 0.9.59.

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

--- Comment #10 from Vit Hrachovy   2008-04-19 03:21:58 ---
Created an attachment (id=12294)
 --> (http://bugs.winehq.org/attachment.cgi?id=12294)
WINEDEBUG=+ddraw log output

DDraw log of: 
1. starting game (menu is shown)
2. moving mouse (menu vanished with black screen)
3. moving mouse to quit button and exit

Seems the game uses 2 DirectDraw interfaces - the second one for buffering,
which is inadvertedly overwriting the correct output of the first one.

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

Vit Hrachovy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #11 from Vit Hrachovy   2008-06-09 15:09:49 ---
closing. Bug 1347 contains fix.

*** This bug has been marked as a duplicate of bug 1347 ***

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Austin English   2008-10-29 14:17:30 ---
Closing abandoned.

[Bug 9686] Zork: Nemesis and Zork: Grand Inquisitor seem to have applied incremental filter over static parts of screen image

http://bugs.winehq.org/show_bug.cgi?id=9686

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d